Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
To:     Jan Kara <jack@suse.cz>
CC:     "Theodore Y . Ts'o" <tytso@mit.edu>,
        Ext4 Developers List <linux-ext4@vger.kernel.org>,
        <yangerkun@huawei.com>
From:   yangerkun <yangerkun@huawei.com>
Subject: [QUESTION] question for commit 2d01ddc86606 ("ext4: save error info
 to sb through journal if available")
Message-ID: <05ff3a17-6559-9317-a382-f0a02fa59926@huawei.com>
Date:   Wed, 25 Aug 2021 10:13:03 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.2
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Jan,

There is a question about 2d01ddc86606 ("ext4: save error info to sb 
through journal if available"). This commit describe that we can have 
checksum failure with follow case:

1. ext4_handle_error will call ext4_commit_super which write directly to 
the superblock
2. At the same time, jounalled update of the superblock is ongoing

However, after commit 05c2c00f3769 ("ext4: protect superblock 
modifications with a buffer lock"), all the update for superblock and 
the csum will be protected with buffer lock. It seems we won't get a 
csum error after that commit and the journal logic in 
flush_stashed_error_work seems useless.

Maybe there is something missing... Can you help to explain more for that...


Thanks,
Kun.