Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp201618pxb; Wed, 25 Aug 2021 00:48:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzjaCPRukbTP11gS0wCB67ZQgfXkNPhOE0XcHHRjq8FoaWaiybed/4qFqg2gnyQLgrtVFTE X-Received: by 2002:a17:906:70b:: with SMTP id y11mr21935788ejb.274.1629877680695; Wed, 25 Aug 2021 00:48:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629877680; cv=none; d=google.com; s=arc-20160816; b=Q6VBVB8RyCYqOkzJiXtBhB1XILVCFNaSLo9o4R+rPExdnG0OXN7p1peXigvuXgc9Se DCa0Q1eCQrG5fDblXb0E9Lz9yqGHeQH0Nhnv7QO5OSqm7zcsYZXRpAl70/t7CUHHti+Y XX7jVQuMQPdX0lxd2tyLej/QOyCJ0PXC0qadeSAptfRLgBCNpOuEOwF3pikqaDBgc+eE ufCH0gTWy4jCQFrgzcYkptMa3mmUet+5QWOCDZ8NkNIeQlmTXRBRwTV8mHXciWTSjk+5 n8IwKKwa83QXzs46vq/OWnDChs9gPOatHEsR4QCOEFeFkZ4RrooNRyYkZPuDyf8wFbXl rXpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=XCh0HgBm/Xso4G5+1XkG2nE3NsbRONRU5XZxGVy7/Lw=; b=Ay6vE2PdzQjBTN++cvH3hJtoVOkLr+rjsLUdZRePNLi0ZlQTUJnuYlu7eAO7lMK9Fl UKRO4a3uJ0RaX/vsylLZQB7MazKb3AG0YjZ5uAPJs+fPSaCQx4wrQyxD6At0TAlv3cmY psr/kh0OH8nM5U1TF8keOW+/qlO9/Zim4EUZYqHR1V43b2tGwhAtfuxM9SGcPQUQDicj iA6tVMRtAEud43hZRMjMlYXYwLDdwj8myHtmtSYB2kCzybppZ+vR81BcwsnB6b2zMApI neA1ESIV2+1LE6Rd4a3Fg4E+3vHPYU3zdZTc/23k/zBN+HJz39EJ+vkIhTrEMA8JcwlP q/rw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j15si20172991ejn.232.2021.08.25.00.47.29; Wed, 25 Aug 2021 00:48:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238741AbhHYHrp (ORCPT + 99 others); Wed, 25 Aug 2021 03:47:45 -0400 Received: from verein.lst.de ([213.95.11.211]:55156 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238651AbhHYHrp (ORCPT ); Wed, 25 Aug 2021 03:47:45 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 5C7676736F; Wed, 25 Aug 2021 09:46:58 +0200 (CEST) Date: Wed, 25 Aug 2021 09:46:57 +0200 From: Christoph Hellwig To: Alex Sierra Cc: akpm@linux-foundation.org, Felix.Kuehling@amd.com, linux-mm@kvack.org, rcampbell@nvidia.com, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, hch@lst.de, jgg@nvidia.com, jglisse@redhat.com Subject: Re: [PATCH v1 09/14] mm: call pgmap->ops->page_free for DEVICE_PUBLIC pages Message-ID: <20210825074657.GB29620@lst.de> References: <20210825034828.12927-1-alex.sierra@amd.com> <20210825034828.12927-10-alex.sierra@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210825034828.12927-10-alex.sierra@amd.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Tue, Aug 24, 2021 at 10:48:23PM -0500, Alex Sierra wrote: > Add MEMORY_DEVICE_PUBLIC case to free_zone_device_page callback. > Device public type memory case is now able to free its pages properly. This really should go into patch 4. And it might make sense to introduce free_device_private_page directly with the free_device_page name instead of renaming it a little later.