Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp4129009pxb; Mon, 30 Aug 2021 20:05:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyhpolzx6d5jzHuxU2FYNI7owMQddCdGA/rARI2fdmdauQGAZVS6U6WMN1gD1eeCUHZadOi X-Received: by 2002:a17:906:a991:: with SMTP id jr17mr17504463ejb.511.1630379139218; Mon, 30 Aug 2021 20:05:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630379139; cv=none; d=google.com; s=arc-20160816; b=WjEdbukqg4dwXoIJRquODFDDF3WHXbZUWRndkTrjl6VX2PDmx/y2Xr96dWf2sVwUtr ksBJ30YBl7CNyJm7G40WHegA8vtShJFylKyGrsxbitcNjz4W0Jcq7FwkRfwN7cYL457K A0qfhOFxYEMu+eNwLq0U8UYSSNah4VyHv+7GMrt4RjhVlPzmYf/YL4yX1EUJISMEaxxk tqVMk99pgulpVf9fGOW+VpplBCWwgfNudaXaT9Exu3Ys0ac9U0cycho2MpOFIxMqrieH WdESQCpP+Zl6PgzPlIyZ+J1GZT6kL8Mk5I5qZgrBloYjmonFx07Ki0Qp5iQ6RSyrPLVi QWEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=IBlxNK1lRMfZpKLlTVXfjgy2cYqLHizON5mNt5aHNNM=; b=n6EQgP/Ds7tbwQl/NbkTSIOWrYQ+O9iH1sBd7ynRxzFflYMbErCDrfKi3EcwQtvtAo AzcWE0P1UAdZQSscHjkT4/6qjRREXRR3BunmSM8CF10qGrVgAIx42ROM4W8TxDxHg3So Q6ATknzV9AWCLh8TFP+K0N/N87GT9q3EiHKME+8Nlpqy79rT3By9oTySDQohmZETybyU dr59Xqv02Mbx7HC0r3xSOUS7UcctZpwxkSwIw92T1Zdd7IWwOoyeUyW+ppWRrv3i2g6/ 4brgNk58F4rDN1+6bjwhAuddhWIpSD9hwIPEGt1971Od91O5TX5C0vJmcBs3VhRkLxlc bVIw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i16si15162827ejw.721.2021.08.30.20.05.16; Mon, 30 Aug 2021 20:05:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239452AbhHaDFd (ORCPT + 99 others); Mon, 30 Aug 2021 23:05:33 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:52541 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S235848AbhHaDFd (ORCPT ); Mon, 30 Aug 2021 23:05:33 -0400 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 17V34SgE029546 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 30 Aug 2021 23:04:28 -0400 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 4A83215C3E7E; Mon, 30 Aug 2021 23:04:28 -0400 (EDT) Date: Mon, 30 Aug 2021 23:04:28 -0400 From: "Theodore Ts'o" To: Zhang Yi Cc: linux-ext4@vger.kernel.org, adilger.kernel@dilger.ca, jack@suse.cz, yukuai3@huawei.com Subject: Re: [PATCH v4 2/6] ext4: remove an unnecessary if statement in __ext4_get_inode_loc() Message-ID: References: <20210826130412.3921207-1-yi.zhang@huawei.com> <20210826130412.3921207-3-yi.zhang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210826130412.3921207-3-yi.zhang@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu, Aug 26, 2021 at 09:04:08PM +0800, Zhang Yi wrote: > The "if (!buffer_uptodate(bh))" hunk covered almost the whole code after > getting buffer in __ext4_get_inode_loc() which seems unnecessary, remove > it and switch to check ext4_buffer_uptodate(), it simplify code and make > it more readable. > > Signed-off-by: Zhang Yi > Reviewed-by: Jan Kara Thanks, applied. - Ted