Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp778796pxb; Thu, 2 Sep 2021 15:10:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyTTARCu/4ceINScIFM7OmvGqNYOnZd/1FWbEt9ePsI1qxYx8iigzjks12JBah0ir1rK/0i X-Received: by 2002:a17:906:bc89:: with SMTP id lv9mr454444ejb.110.1630620640852; Thu, 02 Sep 2021 15:10:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630620640; cv=none; d=google.com; s=arc-20160816; b=yJu2shltb6tI8zlZJYJRrZLyqKoc61r8JE+/uEAkvMf/h5AsmwrWTERwWneOcX6nEU XTxc6No94Y3IYC3GMYMAVLpWMz2Y75orfPo7Ire16J3NSiGQGi6zrYtFjHiwJAevadIj 4mLbzQ1X13lDrJqi0Agov5jxbfqGLsH0ntu3MNS5elhrI3sMpdG0NGmWUfr79mUJ0JtQ 7J0FsLH/YtLCWuBUEzZoIC4oo5xEvKMdM0tMzPjJ6KYL5LV3OZs4ekYJhOgSMqC6cFhh Eq3hiu0FJ0wVslURjc97a08/Guv0YvLYvM8VIlMkB7LV4ZBBNjOms2j4BVV0nEMvV5ek sIyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:dkim-filter; bh=l1dnA7POZ9SG5u4+MMSNjNA3JdFATzQVZzAiyW78yEE=; b=HIgJ0JVKI8AQ10CjXc/x1Xes1V/YyNyiibzUvZQeWzPrv82B7i+mc8wtkTWGCHj20u ZxjZJiHReM9Ph4cK+PO5LneAIOn4IpjCJzCLhjm8uvXRAIcTQNkdhwTwY8pardU0OzM7 Rqk47H1s06Txz7GyddFXIelUz2XRN8dq+n141ZrufNvQ/dKMHBpQQuf0E8ORKKqCypeG iyjGiTjDpdfG813/dpd0G9FnzUhBdjJR5v5nQH1PKrhr5ikRvARZBgD1gFsFAajzVUH0 J2Ro+HzmWdgcCI4VIQKjrpyHjK/J0/1i2P+DK5cyMFps49YmQI7myYIOHJe5TnqErjXo kfXw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lwn.net header.s=20201203 header.b=MeSdkyf5; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dp12si3125582ejc.300.2021.09.02.15.10.11; Thu, 02 Sep 2021 15:10:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@lwn.net header.s=20201203 header.b=MeSdkyf5; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233108AbhIBWKf (ORCPT + 99 others); Thu, 2 Sep 2021 18:10:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43208 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231297AbhIBWK3 (ORCPT ); Thu, 2 Sep 2021 18:10:29 -0400 Received: from ms.lwn.net (ms.lwn.net [IPv6:2600:3c01:e000:3a1::42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B699C061575; Thu, 2 Sep 2021 15:09:30 -0700 (PDT) Received: from meer.lwn.net (unknown [IPv6:2601:281:8300:104d:444a:d152:279d:1dbb]) by ms.lwn.net (Postfix) with ESMTPA id 5D6A561C7; Thu, 2 Sep 2021 22:09:29 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 ms.lwn.net 5D6A561C7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lwn.net; s=20201203; t=1630620569; bh=l1dnA7POZ9SG5u4+MMSNjNA3JdFATzQVZzAiyW78yEE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MeSdkyf5+SfF4ja1WxPh8FqdCz5hHKRatKVve4nq5gKI/+WiZqKIHCZI2Sh4ZlSmi P1MWl+SHjzTo8DY4PEBOCQ/DKxjndGZrsiRpgOkplHXV+Iiekg/p6Ue/gxMCXN4WMc yEeWThtfVtwTNfyK7/cH71dDRfNwqdkDx0SOi2m6KWt/TP7Jz5ZvmKEB/Cvgmgq/R6 vHgAT+qomi9fEMXFkQ2sDZfC/ADM4rmx/qIsN5LnsKbWIF/U/YjodbE4VsDlsnwIJw lU2Rl0aa9t+AqawcJ6j0U+hFbJLWUwCCFT2InwXc+fOEf3ueCTFf/vS3vE9txpYP26 k91g5XjaI99Aw== From: Jonathan Corbet To: Theodore Ts'o Cc: Jan Kara , linux-ext4@vger.kernel.org, linux-doc@vger.kernel.org, Jonathan Corbet Subject: [PATCH 2/2] ext4: docs: Take out unneeded escaping Date: Thu, 2 Sep 2021 16:08:54 -0600 Message-Id: <20210902220854.198850-3-corbet@lwn.net> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210902220854.198850-1-corbet@lwn.net> References: <20210902220854.198850-1-corbet@lwn.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org The new file Documentation/orphan/ext4.rst escapes underscores ("\_") throughout. However, RST doesn't actually require that, so the escaping only succeeds in making the document less readable. Remove the unneeded escapes. Signed-off-by: Jonathan Corbet --- Documentation/filesystems/ext4/orphan.rst | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/Documentation/filesystems/ext4/orphan.rst b/Documentation/filesystems/ext4/orphan.rst index d096fe0ba19e..03cca178864b 100644 --- a/Documentation/filesystems/ext4/orphan.rst +++ b/Documentation/filesystems/ext4/orphan.rst @@ -12,31 +12,31 @@ track the inode as orphan so that in case of crash extra blocks allocated to the file get truncated. Traditionally ext4 tracks orphan inodes in a form of single linked list where -superblock contains the inode number of the last orphan inode (s\_last\_orphan +superblock contains the inode number of the last orphan inode (s_last_orphan field) and then each inode contains inode number of the previously orphaned -inode (we overload i\_dtime inode field for this). However this filesystem +inode (we overload i_dtime inode field for this). However this filesystem global single linked list is a scalability bottleneck for workloads that result in heavy creation of orphan inodes. When orphan file feature -(COMPAT\_ORPHAN\_FILE) is enabled, the filesystem has a special inode -(referenced from the superblock through s\_orphan_file_inum) with several +(COMPAT_ORPHAN_FILE) is enabled, the filesystem has a special inode +(referenced from the superblock through s_orphan_file_inum) with several blocks. Each of these blocks has a structure: ============= ================ =============== =============================== Offset Type Name Description ============= ================ =============== =============================== -0x0 Array of Orphan inode Each \_\_le32 entry is either - \_\_le32 entries entries empty (0) or it contains +0x0 Array of Orphan inode Each __le32 entry is either + __le32 entries entries empty (0) or it contains inode number of an orphan inode. -blocksize-8 \_\_le32 ob\_magic Magic value stored in orphan +blocksize-8 __le32 ob_magic Magic value stored in orphan block tail (0x0b10ca04) -blocksize-4 \_\_le32 ob\_checksum Checksum of the orphan block. +blocksize-4 __le32 ob_checksum Checksum of the orphan block. ============= ================ =============== =============================== When a filesystem with orphan file feature is writeably mounted, we set -RO\_COMPAT\_ORPHAN\_PRESENT feature in the superblock to indicate there may +RO_COMPAT_ORPHAN_PRESENT feature in the superblock to indicate there may be valid orphan entries. In case we see this feature when mounting the filesystem, we read the whole orphan file and process all orphan inodes found there as usual. When cleanly unmounting the filesystem we remove the -RO\_COMPAT\_ORPHAN\_PRESENT feature to avoid unnecessary scanning of the orphan +RO_COMPAT_ORPHAN_PRESENT feature to avoid unnecessary scanning of the orphan file and also make the filesystem fully compatible with older kernels. -- 2.31.1