Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210824034929.GA13415@raspberrypi>
In-Reply-To: <20210824034929.GA13415@raspberrypi>
From:   Austin Kim <austindh.kim@gmail.com>
Date:   Mon, 6 Sep 2021 08:19:38 +0900
Message-ID: <CADLLry4tZjHKpJq7cQ3Rmhc_OOvHK+Wmss=8x_8KA-aHP++oLw@mail.gmail.com>
Subject: Re: [PATCH] ext4: remove an unused variable warning with CONFIG_QUOTA=n
To:     "Theodore Y. Ts'o" <tytso@mit.edu>, adilger.kernel@dilger.ca
Cc:     linux-ext4@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        =?UTF-8?B?6rmA64+Z7ZiE?= <austin.kim@lge.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

2021=EB=85=84 8=EC=9B=94 24=EC=9D=BC (=ED=99=94) =EC=98=A4=ED=9B=84 12:49, =
Austin Kim <austindh.kim@gmail.com>=EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1:
>
> The 'enable_quota' variable is only used in an CONFIG_QUOTA.
> With CONFIG_QUOTA=3Dn, compiler causes a harmless warning:
>
> fs/ext4/super.c: In function =E2=80=98ext4_remount=E2=80=99:
> fs/ext4/super.c:5840:6: warning: variable =E2=80=98enable_quota=E2=80=99 =
set but not used
>   [-Wunused-but-set-variable]
>   int enable_quota =3D 0;
>               ^~~~~
>
> Move 'enable_quota' into the same #ifdef CONFIG_QUOTA block
> to remove an unused variable warning.
>
> Signed-off-by: Austin Kim <austindh.kim@gmail.com>
> ---
>  fs/ext4/super.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 6b03e4281f6f..6adb570f4b31 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -5845,10 +5845,10 @@ static int ext4_remount(struct super_block *sb, i=
nt *flags, char *data)
>         struct ext4_sb_info *sbi =3D EXT4_SB(sb);
>         unsigned long old_sb_flags, vfs_flags;
>         struct ext4_mount_options old_opts;
> -       int enable_quota =3D 0;
>         ext4_group_t g;
>         int err =3D 0;
>  #ifdef CONFIG_QUOTA
> +       int enable_quota =3D 0;
>         int i, j;
>         char *to_free[EXT4_MAXQUOTAS];
>  #endif
> @@ -6053,7 +6053,9 @@ static int ext4_remount(struct super_block *sb, int=
 *flags, char *data)
>                                         err =3D -EROFS;
>                                         goto restore_opts;
>                                 }
> +#ifdef CONFIG_QUOTA
>                         enable_quota =3D 1;
> +#endif
>                 }
>         }
>
> --
> 2.20.1
>

If you are available, would you please review this patch?
It will not take long.

BR,
Austin Kim