Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp847372pxb; Wed, 8 Sep 2021 13:55:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxu2+bkcUnlDaGm9VxYODX6g26BJxExt6jpWk0mLZH4hjZqZV2cFBgtsXgtu5qRUQj6mX3q X-Received: by 2002:a17:906:fb13:: with SMTP id lz19mr38269ejb.516.1631134534867; Wed, 08 Sep 2021 13:55:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631134534; cv=none; d=google.com; s=arc-20160816; b=xlbqaLZx8kZDYUFlj8F/tzmgeFBAAFSFw2o9L5+aSYHqaqiSva5kHZ9uIS/u+nYtYi lbRatVV50d8O4iJYduyZHnzRB7j4iKJUMXYxoZP/3ZxM98LDxqIJvEcGgxk+epr8g/fb USI46wDUhpHKav9xRmsMZMbZSMNKTQWEJAyqJwJJqsKiActYZVoBtevADYE4zyHlbtGe O2fKGDpGFhzO8xn4n7uZwy81OOB8xb2l65gZybzNrheHpoWfpeYN/tMTGWrd8ckBqcZS HqkcaAQhEVQ0z5NmELzu2H+J4qQl2gJOJfrCg7rhOQMZ4Hx+glc8+N3kQQ37qI8iN5Uf ERjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=sU3m59q5I8KIXHpE4A0uHYYk/DsKrSCayjV7iEizTFY=; b=aqvHfweffZds91IHodQYXReuI7Te7uNlAxH5dnQ3/sHkqYeywZQbqKUvfAwjci6u9x vEqfm2IkTbXtd6qNjloi3zxJEu+9iLRC8/Imjy/mO+v5oF43AO6Y91kiqUe7ygMExmaA StLXS10W0uxp/+rubrWWsC/SVDgkJTCpATe6w/RxXZoB28otKezQaPdOL93ZZu6KA3Oz rZz5dCXle08FQCBB205z/l2f5JCgSWb9t37oGztcRwX3aK9Rq6QiV81HLsLA2dz+gfjc 0yPDWhWBrFTdGr0w56ebsrRi4soW5D0Ylk7vKhP3GX8Hzz6ZxXlUH+vV+qmR+tHE8acy +OCQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u3si243791edc.445.2021.09.08.13.55.03; Wed, 08 Sep 2021 13:55:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349512AbhIHUz1 (ORCPT + 99 others); Wed, 8 Sep 2021 16:55:27 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:59425 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S235437AbhIHUz0 (ORCPT ); Wed, 8 Sep 2021 16:55:26 -0400 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 188Krv5F014651 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 8 Sep 2021 16:53:58 -0400 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 3A12D15C3403; Wed, 8 Sep 2021 16:53:57 -0400 (EDT) Date: Wed, 8 Sep 2021 16:53:57 -0400 From: "Theodore Ts'o" To: Christoph Hellwig Cc: Gabriel Krisman Bertazi , Shreeya Patel , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [PATCH 01/11] ext4: simplify ext4_sb_read_encoding Message-ID: References: <20210818140651.17181-1-hch@lst.de> <20210818140651.17181-2-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210818140651.17181-2-hch@lst.de> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, Aug 18, 2021 at 04:06:41PM +0200, Christoph Hellwig wrote: > Return the encoding table as the return value instead of as an argument, > and don't bother with the encoding flags as the caller can handle that > trivially. > > Signed-off-by: Christoph Hellwig Acked-by: Theodore Ts'o Thanks, - Ted