Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Theodore Ts'o" <tytso@mit.edu>
To:     adilger.kernel@dilger.ca, Hou Tao <houtao1@huawei.com>,
        harshadshirwadkar@gmail.com
Cc:     "Theodore Ts'o" <tytso@mit.edu>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: limit the number of blocks in one ADD_RANGE TLV
Date:   Thu,  9 Sep 2021 13:10:16 -0400
Message-Id: <163120740355.1583335.70349130473503343.b4-ty@mit.edu>
In-Reply-To: <20210820044505.474318-1-houtao1@huawei.com>
References: <20210820044505.474318-1-houtao1@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Fri, 20 Aug 2021 12:45:05 +0800, Hou Tao wrote:
> Now EXT4_FC_TAG_ADD_RANGE uses ext4_extent to track the
> newly-added blocks, but the limit on the max value of
> ee_len field is ignored, and it can lead to BUG_ON as
> shown below when running command "fallocate -l 128M file"
> on a fast_commit-enabled fs:
> 
>   kernel BUG at fs/ext4/ext4_extents.h:199!
>   invalid opcode: 0000 [#1] SMP PTI
>   CPU: 3 PID: 624 Comm: fallocate Not tainted 5.14.0-rc6+ #1
>   Hardware name: QEMU Standard PC (i440FX + PIIX, 1996)
>   RIP: 0010:ext4_fc_write_inode_data+0x1f3/0x200
>   Call Trace:
>    ? ext4_fc_write_inode+0xf2/0x150
>    ext4_fc_commit+0x93b/0xa00
>    ? ext4_fallocate+0x1ad/0x10d0
>    ext4_sync_file+0x157/0x340
>    ? ext4_sync_file+0x157/0x340
>    vfs_fsync_range+0x49/0x80
>    do_fsync+0x3d/0x70
>    __x64_sys_fsync+0x14/0x20
>    do_syscall_64+0x3b/0xc0
>    entry_SYSCALL_64_after_hwframe+0x44/0xae
> 
> [...]

Applied, thanks!

[1/1] ext4: limit the number of blocks in one ADD_RANGE TLV
      commit: af8137dff33d975ac84c8a5f63e057b2d0405fc3

Best regards,
-- 
Theodore Ts'o <tytso@mit.edu>