Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp1019533pxb; Wed, 15 Sep 2021 20:03:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzWu3X4sfP2IuSxlHOwQsRTjol/4HDRTqrfgOPAuNMbi8To5YCMChSkdD/HykS7yatANM+o X-Received: by 2002:a92:870b:: with SMTP id m11mr2428310ild.132.1631761392713; Wed, 15 Sep 2021 20:03:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631761392; cv=none; d=google.com; s=arc-20160816; b=QrYxhQ2PdKRLZbQgJMjhhRCLvs5hw6LjaXgXLRh5bdLU4Kz1m/V5uLxQ0JvZP6/h4Z uLRf8huzvXc+bs8iKmamF4OlC7BAZzoLkv6uCNnw/bHwxMpZqusBGcEYAe20ZfcCILMd YqEXi3CD2OdQijYS8eJWQnuPthb6N9pWZE5/1ebDdP8vXBcYV1u+6Xm+kKxsxKMecBRe ef2euaAVGLLQ3ZW+sf95sBRF3mZXyGlwNx1uqiNsIfs65Wm/1WsAujOotu8sWltT2n1C 4uS2vLhvmKGgRqxGcvcu6Cs7QrZG3cmdcSgRt6pJrKq2w2e5Un/JyuYdJtdbIMCJJZTR hgxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=rm9EU0lrNe9VMfxDoV9LVRXzW9yhmufqdArvj7nTsuo=; b=AjXX4JCucfERWjKp4HV9ZWcj6suDQN80xtsRBtLmR6224psakwk//GggPtMnL1K1C1 mWwipD7z1Uk/RwfuWtjG1+S0jSdO6COGtZZTjYJEkw2hCNaKS/MxtnmQA9j5jJU01fH5 pCFHXcY4XqGArGm8SZw3Lyyv0GGvDEQKLiaz0OdZK2uGk/SKmrm0YUEiLGKZ1MtL3Gq0 Aa0iTBb6Kt85oZtKZ+ikBXKJsbnOHVUI6HVoqqjGncg9PGO1jM8JZab36agWSjs2d131 GOn7WkfXpSo4tguozdBZnZrw4QdsvXqOTnBT9pBwkVU+0gjEsRtFsMva78SErcCXKbIw t/4A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h22si1532491jal.57.2021.09.15.20.03.00; Wed, 15 Sep 2021 20:03:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233979AbhIPDCy (ORCPT + 99 others); Wed, 15 Sep 2021 23:02:54 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:40835 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S233961AbhIPDCr (ORCPT ); Wed, 15 Sep 2021 23:02:47 -0400 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 18G31IVP017850 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 15 Sep 2021 23:01:18 -0400 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 1962815C3427; Wed, 15 Sep 2021 23:01:18 -0400 (EDT) From: "Theodore Ts'o" To: Jeffle Xu , adilger.kernel@dilger.ca Cc: "Theodore Ts'o" , joseph.qi@linux.alibaba.com, linux-ext4@vger.kernel.org, hsiangkao@linux.alibaba.com, enwlinux@gmail.com Subject: Re: [PATCH v2] ext4: fix reserved space counter leakage Date: Wed, 15 Sep 2021 23:01:12 -0400 Message-Id: <163176124738.2478144.17001941380733337.b4-ty@mit.edu> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20210823061358.84473-1-jefflexu@linux.alibaba.com> References: <20210823061358.84473-1-jefflexu@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Mon, 23 Aug 2021 14:13:58 +0800, Jeffle Xu wrote: > When ext4_insert_delayed block receives and recovers from an error from > ext4_es_insert_delayed_block(), e.g., ENOMEM, it does not release the > space it has reserved for that block insertion as it should. One effect > of this bug is that s_dirtyclusters_counter is not decremented and > remains incorrectly elevated until the file system has been unmounted. > This can result in premature ENOSPC returns and apparent loss of free > space. > > [...] Applied, thanks! [1/1] ext4: fix reserved space counter leakage commit: 8ec5146a46609a89658e5dc9bc40b70ce70ef43b Best regards, -- Theodore Ts'o