Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 17 Sep 2021 11:47:37 +0200
From:   Jan Kara <jack@suse.cz>
To:     Eric Sandeen <sandeen@redhat.com>
Cc:     linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, dan.j.williams@intel.com
Subject: Re: [PATCH 2/3] ext4: remove dax EXPERIMENTAL warning
Message-ID: <20210917094737.GE6547@quack2.suse.cz>
References: <1631726561-16358-1-git-send-email-sandeen@redhat.com>
 <1631726561-16358-3-git-send-email-sandeen@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1631726561-16358-3-git-send-email-sandeen@redhat.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Wed 15-09-21 12:22:40, Eric Sandeen wrote:
> As there seems to be no significant outstanding concern about
> dax on ext4 at this point, remove the scary EXPERIMENTAL
> warning when in use.
> 
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>

I agree. You can add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
>  fs/ext4/super.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 0775950..82948d6 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -2346,8 +2346,6 @@ static int handle_mount_opt(struct super_block *sb, char *opt, int token,
>  					     "both data=journal and dax");
>  				    return -1;
>  			}
> -			ext4_msg(sb, KERN_WARNING,
> -				"DAX enabled. Warning: EXPERIMENTAL, use at your own risk");
>  			sbi->s_mount_opt |= EXT4_MOUNT_DAX_ALWAYS;
>  			sbi->s_mount_opt2 &= ~EXT4_MOUNT2_DAX_NEVER;
>  			break;
> -- 
> 1.8.3.1
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR