Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp4521024pxb; Mon, 27 Sep 2021 20:12:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyoC4Jvn+QfX641Hq8DPCCyrBOQ2LOQoB4hs+TWMDSQcKjrTIR3w8PZ6Gm3qIq0xiUwA/PF X-Received: by 2002:a17:902:a604:b029:12c:dda2:30c4 with SMTP id u4-20020a170902a604b029012cdda230c4mr2611136plq.73.1632798731689; Mon, 27 Sep 2021 20:12:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632798731; cv=none; d=google.com; s=arc-20160816; b=fjD+PY0HH0dmdh4Ylszb6QghW6+8U8Qp9cx+9GrW7ibzMTIHfJUo55OJhptx6bZej4 etEeTgihtnkwGq2c4aBYsueI3XTqNFH8Xbu400I5gEpCTwjRZHGZUo5+lYn0BYDTUPCF wxTlW4oRL/eceqNwX0bojkDANGtOFPpn4taoImtS/w7eWT6B3843rkhbkJemFrxyk7fG hkVuDdWmA3caSVG/WCXdKtkBlr9y9wfVH8iy4y0yZKe3I4CBpSd/pyW8Fl4un/uuM664 dfpP3TG2KhsFo1OI0YMQZ+hZ4IKdmVKZM9HIHc4P0C92Xo67rZGVaKG9/cMX1HLkgUT0 FG2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:references:in-reply-to:subject :cc:to:from:mime-version:content-transfer-encoding:dkim-signature :dkim-signature; bh=k1irZcE6GgE63UfMaZ69q7wFQxdxy8PkJV1UDRuOwDA=; b=DTvZGtGQXAbXK3NVDBIPqHnJ60NZyr/mblKQ6qmxD19vek+9zH2PhkmEQzJU0eveXL LJQTaZpLBuYLkZshlC/+x0FjAlSwXBD6OJmrkaeAh4qkfJdt0e77OO7AYAT+w7kHbdNl 0hoNRdxM5HsTFMRM5wFApx9ov0fqCSC2qrjWU2+pFL30lQJPujhG3If2j6gnISueDyE9 EEcAzulTh/cozFG+MF+pWG6oIoKwsWbLqv9wdt4LXof16wG+pjaUeF3bI2DJ6Dy+D5eI QdSYqJIsSwaEg6tMvnYVd7tydhEMHjhpsPl47phpECfD0Vik2fd35MGkDU6709mljQml yUyA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=Af8PPYiG; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x22si23649867pgj.320.2021.09.27.20.11.51; Mon, 27 Sep 2021 20:12:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=Af8PPYiG; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238801AbhI1DNX (ORCPT + 99 others); Mon, 27 Sep 2021 23:13:23 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]:35268 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238748AbhI1DNX (ORCPT ); Mon, 27 Sep 2021 23:13:23 -0400 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 95E6C222DF; Tue, 28 Sep 2021 03:11:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1632798701; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k1irZcE6GgE63UfMaZ69q7wFQxdxy8PkJV1UDRuOwDA=; b=Af8PPYiGG/KoV03reINXBzNVPccmiyHVMrwNt2UIFxlU1jhXBp5nI2Gka9opvfla6EYXOa u9dubE+5BF4AwBJlVzPfA+nwLlAQkhckDkag+FkKT+kBsnwd6qmqqlWA/pOjn0C1Ffe5V9 HYSxfFfncwL3S6Y8kijKplmMugjgsEE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1632798701; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k1irZcE6GgE63UfMaZ69q7wFQxdxy8PkJV1UDRuOwDA=; b=rvEM/v30W6HdMnLZksiPaBfoRjZ8iPYI6P23HeASJG7DpSxpqPRoywlWfOvhpMFCEARX9U W3t0wcFCENMdaDDw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C1463132D4; Tue, 28 Sep 2021 03:11:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id HD3CH+SHUmHafwAAMHmgww (envelope-from ); Tue, 28 Sep 2021 03:11:32 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 From: "NeilBrown" To: "David Howells" Cc: willy@infradead.org, hch@lst.de, trond.myklebust@primarydata.com, "Theodore Ts'o" , linux-block@vger.kernel.org, ceph-devel@vger.kernel.org, "Trond Myklebust" , "Darrick J. Wong" , "Jeff Layton" , "Andreas Dilger" , "Anna Schumaker" , linux-mm@kvack.org, "Bob Liu" , "Darrick J. Wong" , "Josef Bacik" , "Seth Jennings" , "Jens Axboe" , linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-cifs@vger.kernel.org, "Chris Mason" , "David Sterba" , "Minchan Kim" , "Steve French" , "Dan Magenheimer" , linux-nfs@vger.kernel.org, "Ilya Dryomov" , linux-btrfs@vger.kernel.org, dhowells@redhat.com, viro@zeniv.linux.org.uk, torvalds@linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [RFC][PATCH v3 0/9] mm: Use DIO for swap and fix NFS swapfiles In-reply-to: <163250387273.2330363.13240781819520072222.stgit@warthog.procyon.org.uk> References: <163250387273.2330363.13240781819520072222.stgit@warthog.procyon.org.uk> Date: Tue, 28 Sep 2021 13:11:29 +1000 Message-id: <163279868982.18792.10448745714922373194@noble.neil.brown.name> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Sat, 25 Sep 2021, David Howells wrote: > Whilst trying to make this work, I found that NFS's support for swapfiles > seems to have been non-functional since Aug 2019 (I think), so the first > patch fixes that. Question is: do we actually *want* to keep this > functionality, given that it seems that no one's tested it with an upstream > kernel in the last couple of years? SUSE definitely want to keep this functionality. We have customers using it. I agree it would be good if it was being tested somewhere.... Thanks, NeilBrown