Received: by 2002:a05:6a10:d5a5:0:0:0:0 with SMTP id gn37csp895417pxb; Thu, 30 Sep 2021 21:21:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxV8cNwNJ9VcITAeXGSxHLvFNvV3qkQCtdSHGnqCRPfhwnSyNbtcc+WH3BBSPfwSbP09eud X-Received: by 2002:a05:6402:2689:: with SMTP id w9mr3034157edd.188.1633062077442; Thu, 30 Sep 2021 21:21:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633062077; cv=none; d=google.com; s=arc-20160816; b=lzj0bV1TEA2E3LPVokw1xfsC3NGptscJEZ9aP9mYD1i/vzgEzM5RWr4z7NCvTiX5NA fy75hZQqaRPJziggubWS2d7ymrqP3hwTL0VDY3FVSZHWzpSJfZSmR8SkGIe9UIXUi3a/ 7BBQ5Lxl/y9orhe6REXRp9ocmNuncojzAbDyQLD11pUKG5gnDExib1Ha2M7Rgt1pYz1i VdnrQ4v42jA8SiMsuC8uKxDrBoEpMEUIssY9jzPRgYZtuq4yTBKVMOdXljFgf9eV2g1u QM6ep2b/vNqI0P3FhZ8bFYDbnHRu0AY3JkD7/v3XhQJf8ZprXnTcRTBbC/ovNyvwuI78 LVMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=0vZt/OO1lzgTfTj+PnaLk/7E3IXGLIO6t3AepYzlrmI=; b=IqiUbJJW5b3jpuGnExqXfQSHYJiIikK1okCQ6cipX2/bXH9sYEvPxn9vEkmJd2Xalz MQiTecpt/kmMOVux5YlvK4bTMUawj7CiNCaVrVu4LfWF7/D2dhy2GQOrKSQj+QLj2lZf 5zFelxVbJ3ZCuJ6WxzXbi0n7XMOHDj5is7GE4HnyrI4gxVJQuKZ3HnYxBY1vA6FJ7TM8 DRPuutQEerItj8UuRhcR/VUrLejGFNX2/cJoR4aQg7TXXb2oMC9M6gWsXkuUTTRj5Tx8 Fj+9HiMMVoM+YV2Uxpmx/UrsW9hcGxyHKbOdmNdkh7sLLhQJ4jRJloZihEKKkvxQ+l/i VlZA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 3si7048356edw.438.2021.09.30.21.20.37; Thu, 30 Sep 2021 21:21:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232679AbhJAEOE (ORCPT + 99 others); Fri, 1 Oct 2021 00:14:04 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:44531 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229634AbhJAEOD (ORCPT ); Fri, 1 Oct 2021 00:14:03 -0400 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 1914C0Ak024627 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 1 Oct 2021 00:12:00 -0400 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 1CE5B15C34A8; Fri, 1 Oct 2021 00:12:00 -0400 (EDT) From: "Theodore Ts'o" To: linux-ext4@vger.kernel.org, Zhang Yi Cc: "Theodore Ts'o" , yukuai3@huawei.com, adilger.kernel@dilger.ca, jack@suse.cz Subject: Re: [PATCH] ext4: recheck buffer uptodate bit under buffer lock Date: Fri, 1 Oct 2021 00:11:58 -0400 Message-Id: <163306150510.267516.9802532504467884977.b4-ty@mit.edu> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20210910080316.70421-1-yi.zhang@huawei.com> References: <20210910080316.70421-1-yi.zhang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Fri, 10 Sep 2021 16:03:16 +0800, Zhang Yi wrote: > Commit 8e33fadf945a ("ext4: remove an unnecessary if statement in > __ext4_get_inode_loc()") forget to recheck buffer's uptodate bit again > under buffer lock, which may overwrite the buffer if someone else have > already brought it uptodate and changed it. > > Applied, thanks! [1/1] ext4: recheck buffer uptodate bit under buffer lock commit: f2c77973507fd116c3657df1dc048864a2b16a1c Best regards, -- Theodore Ts'o