Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 7 Oct 2021 12:37:32 -0400
From:   "Theodore Ts'o" <tytso@mit.edu>
To:     Zhang Yi <yi.zhang@huawei.com>
Cc:     linux-ext4@vger.kernel.org, adilger.kernel@dilger.ca, jack@suse.cz,
        yukuai3@huawei.com
Subject: Re: [RFC PATCH 2/3] ext4: check for inconsistent extents between
 index and leaf block
Message-ID: <YV8iTPcMBUQN80Ob@mit.edu>
References: <20210908120850.4012324-1-yi.zhang@huawei.com>
 <20210908120850.4012324-3-yi.zhang@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210908120850.4012324-3-yi.zhang@huawei.com>
Precedence: bulk

On Wed, Sep 08, 2021 at 08:08:49PM +0800, Zhang Yi wrote:
> Now that we can check out overlapping extents in leaf block and
> out-of-order index extents in index block. But the .ee_block in the
> first extent of one leaf block should equal to the .ei_block in it's
> parent index extent entry.

I don't believe this is always guaranteed.

The punch hole operation can remove some or part of the first entry in
the leaf block, and it won't update the parent index.  So it's OK for
the first entry of the leaf block to be greater than entry in the
parent block.  However, if the first entry of the leaf block is less
than the entry in the parent block, that's definitely going to be a
problem.

						- Ted