Received: by 2002:a05:6a10:d5a5:0:0:0:0 with SMTP id gn37csp1540941pxb; Thu, 7 Oct 2021 09:45:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwYIiJgPd6SnI1K12hAh8DSoEikvzIihv8w5d4a6hY208BsLZdBl9eQ5pq005eTpA/l/uW4 X-Received: by 2002:aa7:9609:0:b0:44c:b15f:4c4b with SMTP id q9-20020aa79609000000b0044cb15f4c4bmr5192663pfg.60.1633625136382; Thu, 07 Oct 2021 09:45:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633625136; cv=none; d=google.com; s=arc-20160816; b=rw5phUESJJts43v2JxUTqiBAd8KNN3nrzpvnMkdGWQUf9hZ4lqsU39A5AOcRpHkJWD dQX0t/uRdgs2PhLFclH4lvyma+PJrWQUaB9R1PG4DikWeTNuW/gzbpa5n4TLQ5yv8iMF VYdEB3mWlxeATpACvjlycCs5YA5J+aJKw+iF9oyKADuGOYydPFCNjg/IXLuhDCKAbUJ4 9Xzpbb3ovdog/r79RwaQ78HJG6lf7EDIPkEDnMczIdIxL1f403KuUA0FupntQYSebIIz c/aVpR+mcuWn2oSY7Y0E9nTMq39X8cpDXSNfcs9TV95HDWRh3nqAnnU+ugGLcwZHX3Mr 8q2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=yfyC35ChpjD8LQFS0ccu5ak0tNcATZaHHiUyO5gVEvk=; b=XgVhdV1JcfdD9VjJpH0ZLIr1orCVzUObx4AWIUwMTXE6aaED7kMb/kYvCFCxk0wFTy GBC6FAhNEAEc1wtKr4GEB3m7zxt0o4eGgBwmmzoKJJq5cEEXfRDo8KhOb6aVDvtkOsAM itCZZOurmUUHkDBo0oTqd8jgOIHaDQrsRg7smapZsUy5vzbb8zH8yEEPshzk14lEHuj0 pPhjmoC4LJ6VDOC58MPkdgTEAqR4ghEu9+v88SdArJ4313TGQG5m3fmE2ofnYCJJh+ne Nov+JAxCxrZ4AhlhaAEhq8PnIEeUqhJp6vTKUy0RJ6/stFfktIuf6e+K4ePhOZLm/Vrf W2AQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u189si74576pgd.384.2021.10.07.09.45.22; Thu, 07 Oct 2021 09:45:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242749AbhJGQqd (ORCPT + 99 others); Thu, 7 Oct 2021 12:46:33 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:35407 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S242701AbhJGQqd (ORCPT ); Thu, 7 Oct 2021 12:46:33 -0400 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 197GiSI4024035 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 7 Oct 2021 12:44:28 -0400 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 289C015C3E70; Thu, 7 Oct 2021 12:44:28 -0400 (EDT) Date: Thu, 7 Oct 2021 12:44:28 -0400 From: "Theodore Ts'o" To: Zhang Yi Cc: linux-ext4@vger.kernel.org, adilger.kernel@dilger.ca, jack@suse.cz, yukuai3@huawei.com Subject: Re: [RFC PATCH 1/3] ext4: check for out-of-order index extents in ext4_valid_extent_entries() Message-ID: References: <20210908120850.4012324-1-yi.zhang@huawei.com> <20210908120850.4012324-2-yi.zhang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210908120850.4012324-2-yi.zhang@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, Sep 08, 2021 at 08:08:48PM +0800, Zhang Yi wrote: > After commit 5946d089379a ("ext4: check for overlapping extents in > ext4_valid_extent_entries()"), we can check out the overlapping extent > entry in leaf extent blocks. But the out-of-order extent entry in index > extent blocks could also trigger bad things if the filesystem is > inconsistent. So this patch add a check to figure out the out-of-order > index extents and return error. > > Signed-off-by: Zhang Yi Looks good, Reviewed-by: Theodore Ts'o