Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v1 00/12] MEMORY_DEVICE_COHERENT for CPU-accessible
 coherent device memory
To:     Matthew Wilcox <willy@infradead.org>,
        Andrew Morton <akpm@linux-foundation.org>
Cc:     Alex Sierra <alex.sierra@amd.com>, linux-mm@kvack.org,
        rcampbell@nvidia.com, linux-ext4@vger.kernel.org,
        linux-xfs@vger.kernel.org, amd-gfx@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, hch@lst.de, jgg@nvidia.com,
        jglisse@redhat.com, apopple@nvidia.com
References: <20211012171247.2861-1-alex.sierra@amd.com>
 <20211012113957.53f05928dd60f3686331fede@linux-foundation.org>
 <YWXd0leFtLepunVa@casper.infradead.org>
From:   Felix Kuehling <felix.kuehling@amd.com>
Message-ID: <1bcea911-58c6-c730-35b2-e8f1f8eddcd8@amd.com>
Date:   Tue, 12 Oct 2021 16:24:25 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
In-Reply-To: <YWXd0leFtLepunVa@casper.infradead.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OXRjS2lISGFWNkxsTWd5QlhMWWpTVGFWWTF0bDE5bDBHaXk4MDhOTDZBQUZS?=
 =?utf-8?B?aHBQL1p2U2tCaXFBbFB2L0J0MTJzRTlPL2NCcnhLdnQ1NTR0RzlGT1RPZ0NW?=
 =?utf-8?B?d09zY3BleFFObk5kUGZQTXhrNVhZL2JGVWlJYldRaU4vd2t3THQwdEd5Q3NO?=
 =?utf-8?B?UkQ3ZThCdTh0OHdnZ0U5RHM3WThHYzF2QitqZkw2aTFCM24rak1QNE40R1N5?=
 =?utf-8?B?NnZwcG9UYVoxaUxBYklBb1ovRU9TR2JBS0ZUOFdLRmJsY0JoLyttTTlQdGkz?=
 =?utf-8?B?azJLZW45QUJjOWhzQjBDcmdoL0xCM1JobFlxNFhzU1BxNW9MbmxKdVRYT2hR?=
 =?utf-8?B?YzkzTkV3OGdvbHZLeURsOHY5K09hcmFHRGd4VEp1bEFQdmVzRkI0MVdGYXY1?=
 =?utf-8?B?ODFoOVM2dTRYc2M2NWJDOGlOUnZPZzYwdXNoaVJiM2VYcm9PYVNPQStybzcy?=
 =?utf-8?B?QnBoVEdrZkhibEV6OWpiejJmVGxFL2ZlemVpQ0VrQ2VwZFF0RXd0RTB6eWlo?=
 =?utf-8?B?RVovRkdHSnRUWE00UHZ0ZDlISmUxdG1hNGY3cE0vVitGbis4WDY1eHlKTmpj?=
 =?utf-8?B?RUtWYjQ3NFFRVFJLamh3aFpzV2JZZ0xrYUloYlBWc0pGVHk4c1I0a3lxM2lB?=
 =?utf-8?B?RU4yaklSN1EvaE8rTGZWNHJuazJ3R0FQb2QzVjlaKzkweEJheTUySGIzN3dP?=
 =?utf-8?B?RGpRTXBJTHFjR285emNLdXdZYlhWLzZaRVlQTUZmWjFHdDkrTEhDWkYxSlFD?=
 =?utf-8?B?Y1Zza01aRjV4KzNWSEFIRW1qSS9NZDhoN1lTQ0toRHpXVHZObHFmcnlmMnBt?=
 =?utf-8?B?dGd3WVh5WGdzMEpaekt1QUR1R0tuV2hBNXlDcThWVTFDMjhJWFVHS3VpbWdj?=
 =?utf-8?B?ajFoOFc4VStENXNQNHZTMzdmLzRRU2l6ZFg3YWFOOFNHbVIvN0xLQUNQSVU4?=
 =?utf-8?B?NS95dlU0c0xTYXVIYjFoRUl3UXhTWEJBSXk4bC8yTUYzZTEvcmtIWFp0NzZV?=
 =?utf-8?B?T3V1dER1elVBQTRGQVArdUVBMTk2WThKSTNqVFlabWlBTXVXOVFEZzZxSHB3?=
 =?utf-8?B?aFlSeDQyT1NFVmVJT3BFQUhjSlVGdDhGaWN4dm0yMlVIS2pmbkIrd0tzQmRi?=
 =?utf-8?B?SEFvY1VCYk9NVFZ5bkhxTFRud2JsL1kxNHM3dzU1cmlXWnFiWnNyL1V5OHJr?=
 =?utf-8?B?R1JINVFPclF5WWtmMCt5TmN5UEpqV3RvOHYvWVZwLzh6aUtJUzJXck81dDdE?=
 =?utf-8?B?TVIxcFQwTFN0VmNGN3ErK2d0TmlTNisrQjVzTnB2dTFrSnErL0wxSEVYcTVl?=
 =?utf-8?B?bm9DZzZuZGlveHZkWjVJSmExb0YxVW5WSmd5TWc3c0ZLYjFUUGM4KzBoK3Jk?=
 =?utf-8?B?aTBYdzc4YjQyVXdQclhwRHFSMU1MV0w3SENMZjE5TEk5WXZLV21YY3JpcVVL?=
 =?utf-8?B?cG1SR0F3QWRISklFWDZTclcrRGR2Uktrb2U2NFcrNkw3OS9NS0dWaTJjTmh3?=
 =?utf-8?B?QXZWRC92dzMvWUFOaVRGTjdUTHArNHlKYmZVbmFTSTVoVWJyK0FYUTBEWnVs?=
 =?utf-8?B?cWFwMEYzVW9FU1B6d3lwUWY5U0hnQ2V6T21jMFFiT1I1bCtMQ2RYNGpacEty?=
 =?utf-8?B?cDM2aHpDbWM2Kzl3K2tqMUZQLzFreDlKeExDTG1tRjg5ZDRhUGFKdlZlRGw5?=
 =?utf-8?B?MUxtMG9MSHdhZElCemQxWmNxWnN2RmlyS2N2bm0xQ1EvMWNFc0lwNDJyL2Np?=
 =?utf-8?B?bm5ISlE5RFF2bTlyajQrcGRDWUxLWXcyaHM0UlI2QzRiamNRMFhsOEhhWFZq?=
 =?utf-8?B?UDZScFFib1NMV3oyeVhZQT09?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 314dcfec-4399-4574-ef80-08d98dbe49ee
X-MS-Exchange-CrossTenant-AuthSource: DM5PR1201MB2491.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 20:24:27.5313
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ByR8m+Cis0cHUjsBNF7TijElqt/m/qDdu2o3tbB/XzUo0BkeRcokv0B2GpEsyUYUatkysCoGPbaHyV/DgSUO4g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1514
Precedence: bulk
List-ID: <linux-ext4.vger.kernel.org>
X-Mailing-List: linux-ext4@vger.kernel.org


Am 2021-10-12 um 3:11 p.m. schrieb Matthew Wilcox:
> On Tue, Oct 12, 2021 at 11:39:57AM -0700, Andrew Morton wrote:
>> Because I must ask: if this feature is for one single computer which
>> presumably has a custom kernel, why add it to mainline Linux?
> I think in particular patch 2 deserves to be merged because it removes
> a ton of cruft from every call to put_page() (at least if you're using
> a distro config).  It makes me nervous, but I think it's the right
> thing to do.  It may well need more fixups after it has been merged,
> but that's life.

Maybe we should split the first two patches into a separate series, and
get it merged first, while the more controversial stuff is still under
review?

Thanks,
  Felix