Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <b9fdcc41-2ec5-d628-968b-0aea1091cf9a@oracle.com>
Date:   Wed, 13 Oct 2021 09:13:57 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Subject: Re: [PATCH 16/29] jfs: use bdev_nr_sectors instead of open coding it
Content-Language: en-US
To:     Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
Cc:     Coly Li <colyli@suse.de>, Mike Snitzer <snitzer@redhat.com>,
        Song Liu <song@kernel.org>, David Sterba <dsterba@suse.com>,
        Josef Bacik <josef@toxicpanda.com>,
        Theodore Ts'o <tytso@mit.edu>,
        OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
        Ryusuke Konishi <konishi.ryusuke@gmail.com>,
        Anton Altaparmakov <anton@tuxera.com>,
        Konstantin Komarov <almaz.alexandrovich@paragon-software.com>,
        Kees Cook <keescook@chromium.org>,
        Phillip Lougher <phillip@squashfs.org.uk>,
        Jan Kara <jack@suse.com>, linux-block@vger.kernel.org,
        dm-devel@redhat.com, drbd-dev@lists.linbit.com,
        linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org,
        linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org,
        linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org,
        linux-ext4@vger.kernel.org, jfs-discussion@lists.sourceforge.net,
        linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org,
        linux-ntfs-dev@lists.sourceforge.net, ntfs3@lists.linux.dev,
        reiserfs-devel@vger.kernel.org
References: <20211013051042.1065752-1-hch@lst.de>
 <20211013051042.1065752-17-hch@lst.de>
From:   Dave Kleikamp <dave.kleikamp@oracle.com>
In-Reply-To: <20211013051042.1065752-17-hch@lst.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NVEzdEVTUXJEV2hEVDZYNjQ0YXBVSEJiQ1pYZDNGVnR0cnk4NmtaODAzOXgw?=
 =?utf-8?B?Vmx0Y0ZKV2xJbHllOHFYdzZSM2Q0akc4ZmZxa25mc09URWtrKzRyeEROSEpa?=
 =?utf-8?B?TFNZTnU1VEhyTlNNUEUreDhQZ1g1UHl3N1UrMlBvTitkNEhPMlRZbFRJek9i?=
 =?utf-8?B?SHFMT3o3T0RrSWM3MUVLSWRleEF2RGpsWlhEbUVldi90RTlONzVRdlJYK2hr?=
 =?utf-8?B?L3hiYjlLUzQ3OHNwVnZLTjNLdXUxR3I1Q1ZQRlJHeWJUMUdybytEWGRuU3Zx?=
 =?utf-8?B?bWxOdFFIN3M2K1QrYkFzdk5PbGRadDQxRE5JTy81RTVpaEY2OE4wVjFIMjJM?=
 =?utf-8?B?dG1Jb0xNOGRMcFIrNUVMaW4zREMwOTRPWU56YjNGY2NvM3FrS2JzbTZwYk4w?=
 =?utf-8?B?ZlFCSTZ4Z043TG8yNGE3WGhqanhmZ3Rqb2hYbk9rUk1Dd2hWMmhic2owbVdk?=
 =?utf-8?B?UCtFUENxbWdYS3hPY01rOXhHamZ5b0Q3Nm93NkRDUDZyOXF6VFJhVkxFNHZX?=
 =?utf-8?B?c1hZM2VSbm9DNmY4NUlRc1hiWGFrUkF3OXVWNmhmRy9ZNGpoQkM2THhOeXNS?=
 =?utf-8?B?M3phcmUwQ1A0cWNnUzBzcXhNd1RFaFl1aWo1THZVTDdEK3ZhTDR3b1dOSDlD?=
 =?utf-8?B?cnJpTDZseHJIbDlXdVE3QllnQzdBdzF3N1REcWZTL0ZrcktKUnZsVzBuSmxv?=
 =?utf-8?B?V1g1emdwZXd0WUZGWXdZS25HTjdoamMxYUFMWWNBQmtTRGQrSmU1UCtnTWNB?=
 =?utf-8?B?TUNGWk9STjVBVk1yemRsS2YwMzMwOVlqOVMzSmNzSVhhcmlsa1pLQ1RjcDA2?=
 =?utf-8?B?OTNRb3JybVpWOVl3NThnSC8xQnNjRXc4cFptWDVGUDFDc0pTcHZNYlVjOGxU?=
 =?utf-8?B?ck11YWk4YU1uaEtuYzhhWU9uTWlGNHNJK2NCbUdRNHRkekwxek9RQ2pzTXZk?=
 =?utf-8?B?ZVZVbzh1eXJPQUhBNno5Y3daaTRtdVYvTFNaUklTU1ZtOEFNMXM5Ty80UkFM?=
 =?utf-8?B?b3ZVZmhLbk5vSlV1Uy84Y1lZdGlnL2hDRGhpRFJmbitrRzduWjJUZXhsVWx2?=
 =?utf-8?B?WXVZYnN6UUFvSk9DemtjM0w2Vk9WdUZUVDlxRktjNkQ3cnVTekFoMExZRFJR?=
 =?utf-8?B?VmhwbkYrUXZqNGI0MDE1Mm9COGtmZ1FHNnJxU0lLbkZ4MzljNklDK0FUaEk3?=
 =?utf-8?B?TWpTdWE5dHRtOWNNNy9yMjZ6cVVDbnpSb0JlY3M4Y1RkWW42NlRWR0E1SjFa?=
 =?utf-8?B?RVZ4cFRVWTl6cWZpb0tYVjJ4eE5nbjB6cFVVYlpacy9saVFQbWx3YzlqRzc2?=
 =?utf-8?B?OE5lQ292eGw0dVJYd0lnVFU0dXdiUDJLc1ptd05ESmZMT2trYWxFM1BEREdE?=
 =?utf-8?B?Y2htQTZTeUs1cG9LZVBIdEVkSDdFZE1BNTVkSW1IV01lQU5GRGNBenlwU2Zk?=
 =?utf-8?B?ZWdVTHVyeitybVU2QlhFVC83SVZLMEZmampOclNtSlYwYmlGYkNuY2dXMWZZ?=
 =?utf-8?B?YTZtRVlJK2JIOVVzK2VVRkd2Qll4U0NjNW1LTnYzNlc2UEVKb0R4dmlSRE4w?=
 =?utf-8?B?OW50dGpQRkFSblJ4eHlhdGNnOW9uUUx4UnZwb2VKdGRHelJ5T2NUbU5XWXU1?=
 =?utf-8?B?enU3WVR5dEl3SnpNSE0yZUxHQ200MmMzdCtaQU9Da1A1SHpad09zWHV5a2Vm?=
 =?utf-8?B?L2lDdlpiZEl5dFo0QkgzUEs1OUxib0pvME1HZDNtVDFkbTBOb1BqTHhxZW1K?=
 =?utf-8?Q?VI18e6RseJEkIpxqv3v/kKFWYkcbHH6XLkDS6+k?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c789bfcb-a9be-437a-6e35-08d98e53b3f6
X-MS-Exchange-CrossTenant-AuthSource: SA2PR10MB4665.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2021 14:14:00.4497
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oemYySOM6+n6GAH7CbntjzwlNKDkc12H/mzkMjBkvra40/0815D1QHXR/U9EynaUM+/M9IZZ45v4wMQn/VgiOjVw6FnCGu0r2AZR6uDQweo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR10MB4425
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10135 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0 bulkscore=0
 malwarescore=0 adultscore=0 mlxscore=0 spamscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001
 definitions=main-2110130097
X-Proofpoint-ORIG-GUID: Cxu06FmlAK2C1-boAQ76mTgZwMKZZ5Ud
X-Proofpoint-GUID: Cxu06FmlAK2C1-boAQ76mTgZwMKZZ5Ud
Precedence: bulk
List-ID: <linux-ext4.vger.kernel.org>
X-Mailing-List: linux-ext4@vger.kernel.org

On 10/13/21 12:10AM, Christoph Hellwig wrote:
> Use the proper helper to read the block device size.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Acked-by: Dave Kleikamp <dave.kleikamp@oracle.com>

> ---
>   fs/jfs/resize.c | 2 +-
>   fs/jfs/super.c  | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/jfs/resize.c b/fs/jfs/resize.c
> index bde787c354fcc..51a8b22e71030 100644
> --- a/fs/jfs/resize.c
> +++ b/fs/jfs/resize.c
> @@ -199,7 +199,7 @@ int jfs_extendfs(struct super_block *sb, s64 newLVSize, int newLogSize)
>   	txQuiesce(sb);
>   
>   	/* Reset size of direct inode */
> -	sbi->direct_inode->i_size =  i_size_read(sb->s_bdev->bd_inode);
> +	sbi->direct_inode->i_size = bdev_nr_sectors(sb->s_bdev) << SECTOR_SHIFT;
>   
>   	if (sbi->mntflag & JFS_INLINELOG) {
>   		/*
> diff --git a/fs/jfs/super.c b/fs/jfs/super.c
> index 9030aeaf0f886..992870160903d 100644
> --- a/fs/jfs/super.c
> +++ b/fs/jfs/super.c
> @@ -551,7 +551,7 @@ static int jfs_fill_super(struct super_block *sb, void *data, int silent)
>   		ret = -ENOMEM;
>   		goto out_unload;
>   	}
> -	inode->i_size = i_size_read(sb->s_bdev->bd_inode);
> +	inode->i_size = bdev_nr_sectors(sb->s_bdev) << SECTOR_SHIFT;
>   	inode->i_mapping->a_ops = &jfs_metapage_aops;
>   	inode_fake_hash(inode);
>   	mapping_set_gfp_mask(inode->i_mapping, GFP_NOFS);
>