Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp3822522pxb; Wed, 13 Oct 2021 13:47:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzN8WyLTIt+2AVaVejEGh5TLF4xs3nTdJsyeMU5OOcSic/NFxLIL3ZpsYdMRmSJoJLV7xVm X-Received: by 2002:a05:6402:19ba:: with SMTP id o26mr2424527edz.1.1634158043919; Wed, 13 Oct 2021 13:47:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634158043; cv=none; d=google.com; s=arc-20160816; b=w3McRGnkArOvmfy+fTGndTm2t2Wm5UYbbxueF9NvNU5tnfnr4TZ4z20ySW1S2QQV0h FKnUiW7YMwz4C1Qh/skz9c8p+bRNx1DsKs5d+KZELUDz1LGexj8pxl6U206NgaHGe87q XVJYGl6bFqfN5fDYhEL5ap9mayIghekoK/7RsZhuTO1FPe2aRi01aF5RpJkbfJKMF2pI DfbpPxP7BLmGfuMQ9kv6FrGN81vYiEuGEJ1YYo8B9SrfsK2lpFl2X023RopTrThXAeHo K0NGxNcpIDQyz/2RI95KBt84gJChZDrLUI2jVcv5PC4qoQN8q/llJX8zfWnqweJ+xbq0 Eczw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=ZfgqY4I4ttJtq/KLaDelsR3A71GGWpsKBcYkcahTV9Q=; b=XEHNbIi+HPuAVxEjHIQWgfVXhR5VWficvy35upKTRmQa93bJxPYk6n9b8/uOALgJhg LuOrajKhfNQaoAQ4SkDF0VMj8MZX+kV8EdsB9pOo39FnTF0jwyEqDfXmwQE95yncwrcs w4K2dCFgvCyt3lf8WihNT9dqaXJTVZCrTXe1hJa4JOzItsrxMri3qy6UD2FE5vBbRb+b D2ow+OwoS+QOpvYKyK/42Uul5JxMlRkX3bBXW4K3QeyB1dUEZqmR4nqw03hFDCiTWq7n eopkHs72xshsA+3UEfKs/sDCOriB/HSIOTzkf5IAaQvLeca7phJmPgMjIBSkFdCAqjYq i80g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y14si1090603eda.615.2021.10.13.13.46.36; Wed, 13 Oct 2021 13:47:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229526AbhJMUsZ (ORCPT + 99 others); Wed, 13 Oct 2021 16:48:25 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:59844 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229496AbhJMUsZ (ORCPT ); Wed, 13 Oct 2021 16:48:25 -0400 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 19DKkIL7003446 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 13 Oct 2021 16:46:18 -0400 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 2E1F015C00CA; Wed, 13 Oct 2021 16:46:18 -0400 (EDT) From: "Theodore Ts'o" To: Eric Whitney , linux-ext4@vger.kernel.org Cc: "Theodore Ts'o" Subject: Re: [PATCH] Revert "ext4: enforce buffer head state assertion in ext4_da_map_blocks" Date: Wed, 13 Oct 2021 16:46:14 -0400 Message-Id: <163415796177.214938.9752602885736039327.b4-ty@mit.edu> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20211012171901.5352-1-enwlinux@gmail.com> References: <20211012171901.5352-1-enwlinux@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Tue, 12 Oct 2021 13:19:01 -0400, Eric Whitney wrote: > This reverts commit 948ca5f30e1df0c11eb5b0f410b9ceb97fa77ad9. > > Two crash reports from users running variations on 5.15-rc4 kernels > suggest that it is premature to enforce the state assertion in the > original commit. Both crashes were triggered by BUG calls in that > code, indicating that under some rare circumstance the buffer head > state did not match a delayed allocated block at the time the > block was written out. No reproducer is available. Resolving this > problem will require more time than remains in the current release > cycle, so reverting the original patch for the time being is necessary > to avoid any instability it may cause. > > [...] Applied, thanks! [1/1] Revert "ext4: enforce buffer head state assertion in ext4_da_map_blocks" commit: 52264b162a51eadb0adcb55297cf91905c6ede98 Best regards, -- Theodore Ts'o