Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp4050411pxb; Wed, 13 Oct 2021 19:34:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxXwvY6C4zqBs/VkXOoQltTGeLPZkHrmUIiaJOyXjdRTsFYM+Birte/NCmJ55LEBMueLxQV X-Received: by 2002:a05:6a00:1703:b0:44c:caeb:482b with SMTP id h3-20020a056a00170300b0044ccaeb482bmr2643753pfc.60.1634178845364; Wed, 13 Oct 2021 19:34:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634178845; cv=none; d=google.com; s=arc-20160816; b=qn0n1sbpuLuRyNrAeSApPcC61DEwmnDHca1lfGlaKocffE3jXffmIMJWiCSlTiUkjv VtJiQZcaGwApFOtU3tN8obwim5GCM1OZqmiKljUisqQsENeHf2I40/dEPPPprJn8emqN UJv7odFdk4WqWqXLuXpuOGD1F5CW4oGqN9JGBWWU2mrKWU8D5812Lr83LIYV/M8PU540 oVtcZzYG/G1bD+zgd1lmuesRjy72Y9fxgc+AU0ce/p0iNNCUq8tuuBnauh4IYPyxr2Ta U0hF48C2FFq+kllVbU7W48PqAM7Fcyb3SAo1vkTSSdyuP5SDjCDZclRbFOt+sObQzMB5 MMhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=174C0lT9Lc8h6mSkVJyI+TAGlzYxx9W/acWzYCa+27E=; b=MTTuATJX3OU9qX51wu92inPk/0hucGbKMhX5ZKqj4ghu/yexYQhG/HWFzs/Ad9rXRv b0okpNXjw4PBHLGZB07IQKR4Q+FVEmSS8aIFxjuYGyfQRH9RR7ju0pWnY/ZMr+5LHMyU BvfkenQsux+nULUQIz1jatOHt8pbv6r4kHx8jRUCfgnAer4spgNjPJgJFo48B1yAvzzM HKexin4nrqLIscfbHjzqlBV9G2NAKuBjsRL69GcS+S/nnbA2DvVfApynAf3PB1H5QJYO QnQwYrGiTc555jIoPJIO0ND4FwHSpEqV3n+kBCbj8U0YOEPs9mK6blkl7inwhqW3rlt0 2EVw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r25si2078375pgv.370.2021.10.13.19.33.52; Wed, 13 Oct 2021 19:34:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229496AbhJNCfC (ORCPT + 99 others); Wed, 13 Oct 2021 22:35:02 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:44929 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229879AbhJNCfC (ORCPT ); Wed, 13 Oct 2021 22:35:02 -0400 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 19E2WgE9011854 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 13 Oct 2021 22:32:43 -0400 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 5D22715C00CA; Wed, 13 Oct 2021 22:32:42 -0400 (EDT) From: "Theodore Ts'o" To: Zhang Yi , linux-ext4@vger.kernel.org Cc: "Theodore Ts'o" , yukuai3@huawei.com, jack@suse.cz, adilger.kernel@dilger.ca Subject: Re: [RFC PATCH 0/3] ext4: enhance extent consistency check Date: Wed, 13 Oct 2021 22:32:39 -0400 Message-Id: <163416151699.223555.16012336427055541414.b4-ty@mit.edu> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20210908120850.4012324-1-yi.zhang@huawei.com> References: <20210908120850.4012324-1-yi.zhang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, 8 Sep 2021 20:08:47 +0800, Zhang Yi wrote: > Now that in the error patch of extent updating procedure cannot handle > error and roll-back partial updates properly, so we could access the > left inconsistent extent buffer later and lead to BUGON in > errors=continue mode. For example, we could get below BUGON if we > update leaf extent but failed to update index extent in > ext4_ext_insert_extent() and try to alloc block again. > > [...] Applied, thanks! [1/3] ext4: check for out-of-order index extents in ext4_valid_extent_entries() commit: efbcc1015b07e3e8bafa97394b743812c180a9dd [2/3] ext4: check for inconsistent extents between index and leaf block commit: a992bc717652fb15b435884c587ae5249415239c [3/3] ext4: prevent partial update of the extent blocks commit: 916ff8d5ea0e24fd43f113b6b5326d5ea8f68310 Best regards, -- Theodore Ts'o