Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp4784966pxb; Thu, 14 Oct 2021 11:54:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxrEOHkJM4VzZ17rqVFtKVIxih1qrrlrQ9dgC/fCXOUBWwOcLH9iMpysEFAweHltcpfyYwJ X-Received: by 2002:a17:902:7e84:b0:13e:d793:20d8 with SMTP id z4-20020a1709027e8400b0013ed79320d8mr6607327pla.67.1634237674639; Thu, 14 Oct 2021 11:54:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634237674; cv=none; d=google.com; s=arc-20160816; b=M4Zfn8HoCangt5/lJvfMPIj0QbrCj5T1eUbncRWxYiJmDUdP34zCYT3eqmAk9evPwH UVIxvGYNAwE6V8PU+OUeNMCNKsv8C/v1wDU/DhzKqSrYsr9QP/8YH5HRp0HVB67vZNaf 1Inkce3E7JLS99wxvMEHlZC3wV5KvoXyLCjeD6k1aOsnrkDzoQoBNEZ/efko1vv+45gp J+YZ4MCIWdT+AC05YsG9wI+oP3Qtp8HOvJTlYQWUGxd51O0oQe/S2bPZPvlkZ6s+CXtH H+XqtApczfZeRtqOfXBp4Xs0uAtzlE9t8zP288c4SOYY+S2HhQ04FkwB41jNWedzllys GoHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=AP05hDHW3jnp/8SKRcKLGgYaYjlel0b7xcFX3XAvvcQ=; b=ozSbJy01RTVfAfdSAb13tRMeYMYMrsqVPRGtpSSZwH6vVtteChSsEGqDClRCDnxfdq xP48nK2J6lp62fSTQz3PjpRC17nzUjdqDiDJifH52qht5S+2qc748crzcf0iSdYsn9wd zXOH0GdMJCKyfIa+JG7FynDwc18gkwI/pkTq3P3Ma2fc+L1uf/QMPsaklLD6msrRXIYf tubEgAYbHCpIpn07j7eUh8DS/QcLklDoyakA/KuheZciawgnTJQOxvqSj7z54ggYZ4YY rPs1HETUzU0oqOMX79ivEoUt9hXKNBfrp3oIJDWKZfrwCzP8JJFpZE9znKVgP42E02S9 6D9Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=WrkEY1NX; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l8si4389447pfd.212.2021.10.14.11.54.21; Thu, 14 Oct 2021 11:54:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=WrkEY1NX; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232605AbhJNQ4C (ORCPT + 99 others); Thu, 14 Oct 2021 12:56:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45344 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230244AbhJNQ4B (ORCPT ); Thu, 14 Oct 2021 12:56:01 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D6A1C061570; Thu, 14 Oct 2021 09:53:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=AP05hDHW3jnp/8SKRcKLGgYaYjlel0b7xcFX3XAvvcQ=; b=WrkEY1NXq2B+vb3ir5rv+AxuPg cQLMnetlragb8L7WOZfh2WRUI5amnBlq8PlDunGKpTP6nGfIOIcYnWFF9UuTTFHIVKNRkM+vx+2Dy COMPWhQnxXy5qu73bdmTU7k0CJi1gGHXUvMqopwf5oBqTkX1+Q9pDzR3CrmrDDfC0EKlK4c8ZaMK7 sDvAfPn5lhegMNYQnZ7pKkzJ51QUPqeOSUOnmsleGDbkMn9aU+nkXYPeWigSuK38OwbcmnkhuI+9K mGfn626q1LkPL8F2E1A8enzyO5vqH5MPRzxIZ3FVVVW2IH8w34E9HLHyAbDdNUkG177gXsh8NBe0L iOqMMBMQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mb3y7-008TLK-Fz; Thu, 14 Oct 2021 16:52:58 +0000 Date: Thu, 14 Oct 2021 17:52:35 +0100 From: Matthew Wilcox To: Alex Sierra Cc: akpm@linux-foundation.org, Felix.Kuehling@amd.com, linux-mm@kvack.org, rcampbell@nvidia.com, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, hch@lst.de, jgg@nvidia.com, jglisse@redhat.com, apopple@nvidia.com Subject: Re: [PATCH v1 2/2] mm: remove extra ZONE_DEVICE struct page refcount Message-ID: References: <20211014153928.16805-1-alex.sierra@amd.com> <20211014153928.16805-3-alex.sierra@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211014153928.16805-3-alex.sierra@amd.com> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu, Oct 14, 2021 at 10:39:28AM -0500, Alex Sierra wrote: > From: Ralph Campbell > > ZONE_DEVICE struct pages have an extra reference count that complicates the > code for put_page() and several places in the kernel that need to check the > reference count to see that a page is not being used (gup, compaction, > migration, etc.). Clean up the code so the reference count doesn't need to > be treated specially for ZONE_DEVICE. > > Signed-off-by: Ralph Campbell > Signed-off-by: Alex Sierra > Reviewed-by: Christoph Hellwig Reviewed-by: Matthew Wilcox (Oracle)