Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <2056d9b3-cf07-36fc-ad60-381e4a4e6d7b@oracle.com>
Date:   Fri, 15 Oct 2021 09:16:58 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Subject: Re: [PATCH 27/30] jfs: use sb_bdev_nr_blocks
Content-Language: en-US
To:     Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
Cc:     Coly Li <colyli@suse.de>, Mike Snitzer <snitzer@redhat.com>,
        Song Liu <song@kernel.org>, David Sterba <dsterba@suse.com>,
        Josef Bacik <josef@toxicpanda.com>,
        Theodore Ts'o <tytso@mit.edu>,
        OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
        Dave Kleikamp <shaggy@kernel.org>,
        Ryusuke Konishi <konishi.ryusuke@gmail.com>,
        Anton Altaparmakov <anton@tuxera.com>,
        Konstantin Komarov <almaz.alexandrovich@paragon-software.com>,
        Kees Cook <keescook@chromium.org>,
        Phillip Lougher <phillip@squashfs.org.uk>,
        Jan Kara <jack@suse.com>, linux-block@vger.kernel.org,
        dm-devel@redhat.com, drbd-dev@lists.linbit.com,
        linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org,
        linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org,
        target-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org,
        jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org,
        linux-nilfs@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net,
        ntfs3@lists.linux.dev, reiserfs-devel@vger.kernel.org
References: <20211015132643.1621913-1-hch@lst.de>
 <20211015132643.1621913-28-hch@lst.de>
From:   Dave Kleikamp <dave.kleikamp@oracle.com>
In-Reply-To: <20211015132643.1621913-28-hch@lst.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S2luS1NLaytZdTN5aEkzY0lyWitTM0ZQeE5HcEpIaytsbDJKczI0ajJrQjJV?=
 =?utf-8?B?ZG9wbThCQmxSekZ2VGZXNXY0bmdNSlB0M3BBUS9KSFE0bnZZamF2bjBsTzhx?=
 =?utf-8?B?RmkxQWxLRGluOVI0WDR4djF0RDZFWnpGTFpibTlkYUNxRHBuQXJiV093R0du?=
 =?utf-8?B?U0xrM1Vna3pSeS9lamt4Y0cyT2h5b3VUK1B0eEsxT2FIeUxDU3pLSFYvOEx4?=
 =?utf-8?B?QzhlZ010cDN4SHFzWlE0a1h1UXJMeGRmNUZFQllvSkcwbEIvMmQyeUtpNzJu?=
 =?utf-8?B?N1RLb0t6V3Rod2ovdHBPTEFlWGRlYUl1ZkJQTDRKeEVBRUdJMUFLSWxuUmFX?=
 =?utf-8?B?U21pMXhTTEpOV0JraTlBZ29PMnFBdDlNcjgzYjAvOUNkRE00emRGVVVLQnZ0?=
 =?utf-8?B?QXVaR0VPV2JTZnE1MGhyYjkyL1FGSlNqdklsTm5HeTd6L3hKV2RCaVhpL1RY?=
 =?utf-8?B?OWJGZDk2NDVTdlVmQ0lUVjcxdDg1WFFENGVZSElQdS9NWGFKVlZKbXJWMHkr?=
 =?utf-8?B?Q3g3V1NDalFySlhqc3FpeHUxME9qcHFzRmdpemFranRCUWQrbnNPa05PNlpQ?=
 =?utf-8?B?TDZnV2lVSFhRKzc0ZWxZNkNxcUpPSlNhaEZ1Wkt4YTFUM21uNWVJVmZLSnpw?=
 =?utf-8?B?b0UrY2tLQzMycloxTUxkM0ZRRmxuMGMyMHpHRVpjQjFSYkFaanpuQjJWOVFV?=
 =?utf-8?B?VHUyYmdzSjBYT1J5VC9TZHpIeENvSW9iNnAxaWg5STVUQWYyUGFtRng1aSts?=
 =?utf-8?B?VzFzSE1JdDQ0NWpMalBibkxlcGVlZ0prOGVRaWVnRlB0MkxsblVtZGdOQkhB?=
 =?utf-8?B?S1podU1OVUxqSUhPN3B1YjBOUlJWSTExSmdHUFpFOWRsR0NCeHRwd3FmK1Vh?=
 =?utf-8?B?RHhMSi9wam92emxzTWhxaGZoL0tyREJwZkF0ZnJTcjJlSlQ3S3RBQ24vRlpj?=
 =?utf-8?B?SEJHRVV5NXhMVVRoTzl0TzNmWUd4UHp5ZkExdkw1NzF0RmFLV2tVS3ppMGIr?=
 =?utf-8?B?eC9BYjhTZkI1UGR1dXRiYXYzVldqZzc4RVBybjFCdG4yVTMzVEtoaTFrQ0Rn?=
 =?utf-8?B?aEc2MVRMNmZKdFB4YXB5TmFpenBTWjVvYXBSWHkvbUY5NG5mNzRvelRySXpP?=
 =?utf-8?B?R3IwaWVENkFvL0RJaHF1dTNnSnNKemZmVGs4MHZSTWFnd3RjMXFXT1RINU84?=
 =?utf-8?B?c0lGUjdjYTBGTjRncnAyYUhhdXdjSk9nQUpDZTUzbEEvSHNPK3U2US92emJz?=
 =?utf-8?B?Unc3R2Q1Z0lCMUZadUFjTkNKRzNvRVBmSHF0TzByK1hzK1pvTW9OSVhtNzVJ?=
 =?utf-8?B?RmtCTDIvcldEZUxRVzdua3VzaGI4dWZwRkVqcTBlNGJsN0RTZGUrUjI5L3NE?=
 =?utf-8?B?K1dHL01NK3FCanFhUjJ2WXNIVk91Sk8vZ1dXdDNlK2owUGNWdDkyV0VRc0hR?=
 =?utf-8?B?VlQ0UkFqb3FzWjlCbWRpYXJ6WVNoRGFYTXFZL2JSaXRxTU56UzJ0N0RuVDBD?=
 =?utf-8?B?YWJaK1B5MjFwcDZ4NTY2bzZvT0ViVnVUVXNKY0txUUlob3RtMVJvcmErMy9l?=
 =?utf-8?B?aTlSVzNiMkVEVXprSmU1a3d2WmFZZm9reXh0Ym1BRE5mcTdnc1pMeS9hVCtm?=
 =?utf-8?B?Z0RtbzJBRlFvQTVEc2VqYTBLVkNOcENhZktNMm8xT09CVVc3R1ZENUgvY3h4?=
 =?utf-8?B?U0NFbVJGNWtWeHR3bU02alFZcFVkLzBNZzFjL1BieXY5YXJWV2NydTRnNXBF?=
 =?utf-8?Q?SL9q4IASgEJXnPU/oEClDG2+Wt1oTSdnu2zyD0G?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a68a63bc-24cc-410f-8bc4-08d98fe6746d
X-MS-Exchange-CrossTenant-AuthSource: SA2PR10MB4665.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 14:17:01.1497
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YCIK4X547/RT0fkwgewmVs2SS5HUYyhv/NqprpcA+dyb/QSB58dJwqI9yNN9oBbVZmFNRsl1275KtJxNIdbGLxe/cN/b9mwFUw69fl4/n1s=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR10MB5688
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10137 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0
 adultscore=0 bulkscore=0 mlxscore=0 spamscore=0 mlxlogscore=999
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109230001 definitions=main-2110150088
X-Proofpoint-ORIG-GUID: yYGcjkkCYRt6EPBT5USWKbM7HCwwUtZM
X-Proofpoint-GUID: yYGcjkkCYRt6EPBT5USWKbM7HCwwUtZM
Precedence: bulk
List-ID: <linux-ext4.vger.kernel.org>
X-Mailing-List: linux-ext4@vger.kernel.org

On 10/15/21 8:26AM, Christoph Hellwig wrote:
> Use the sb_bdev_nr_blocks helper instead of open coding it.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Kees Cook <keescook@chromium.org>

Acked-by: Dave Kleikamp <dave.kleikamp@oracle.com>

> ---
>   fs/jfs/resize.c | 3 +--
>   fs/jfs/super.c  | 3 +--
>   2 files changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/jfs/resize.c b/fs/jfs/resize.c
> index a42dbb0d3d28a..8b9a72ae5efa7 100644
> --- a/fs/jfs/resize.c
> +++ b/fs/jfs/resize.c
> @@ -86,8 +86,7 @@ int jfs_extendfs(struct super_block *sb, s64 newLVSize, int newLogSize)
>   		goto out;
>   	}
>   
> -	VolumeSize = i_size_read(sb->s_bdev->bd_inode) >> sb->s_blocksize_bits;
> -
> +	VolumeSize = sb_bdev_nr_blocks(sb);
>   	if (VolumeSize) {
>   		if (newLVSize > VolumeSize) {
>   			printk(KERN_WARNING "jfs_extendfs: invalid size\n");
> diff --git a/fs/jfs/super.c b/fs/jfs/super.c
> index 9241caa161163..24cbc9946e01c 100644
> --- a/fs/jfs/super.c
> +++ b/fs/jfs/super.c
> @@ -284,8 +284,7 @@ static int parse_options(char *options, struct super_block *sb, s64 *newLVSize,
>   		}
>   		case Opt_resize_nosize:
>   		{
> -			*newLVSize = i_size_read(sb->s_bdev->bd_inode) >>
> -				sb->s_blocksize_bits;
> +			*newLVSize = sb_bdev_nr_blocks(sb);
>   			if (*newLVSize == 0)
>   				pr_err("JFS: Cannot determine volume size\n");
>   			break;
>