Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 04/30] drbd: use bdev_nr_sectors instead of open coding it
To:     Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
Cc:     Coly Li <colyli@suse.de>, Mike Snitzer <snitzer@redhat.com>,
        Song Liu <song@kernel.org>, David Sterba <dsterba@suse.com>,
        Josef Bacik <josef@toxicpanda.com>,
        Theodore Ts'o <tytso@mit.edu>,
        OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
        Dave Kleikamp <shaggy@kernel.org>,
        Ryusuke Konishi <konishi.ryusuke@gmail.com>,
        Anton Altaparmakov <anton@tuxera.com>,
        Konstantin Komarov <almaz.alexandrovich@paragon-software.com>,
        Kees Cook <keescook@chromium.org>,
        Phillip Lougher <phillip@squashfs.org.uk>,
        Jan Kara <jack@suse.com>, linux-block@vger.kernel.org,
        dm-devel@redhat.com, drbd-dev@lists.linbit.com,
        linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org,
        linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org,
        target-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org,
        jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org,
        linux-nilfs@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net,
        ntfs3@lists.linux.dev, reiserfs-devel@vger.kernel.org,
        Chaitanya Kulkarni <kch@nvidia.com>
References: <20211015132643.1621913-1-hch@lst.de>
 <20211015132643.1621913-5-hch@lst.de>
From:   Lee Duncan <lduncan@suse.com>
Message-ID: <211d2871-6232-8111-987f-077a95d92a1a@suse.com>
Date:   Fri, 15 Oct 2021 11:00:57 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
In-Reply-To: <20211015132643.1621913-5-hch@lst.de>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZXM2cEQ2U2prbWVjcklZNVllMXFhSG9IMVZta25VcnJhbEx1bmtLQnNQMmYx?=
 =?utf-8?B?MmJVdGdTamtVZDB5UWFTMUZ0OURHK2pacEJiRVcrVklYajV2ZHJldEo2NkVt?=
 =?utf-8?B?Y3B6UHZhN1NBZXFtWmxDSzZuaGhmSENNa01JYjNyQlRITnRoNDZZVjc3V0N2?=
 =?utf-8?B?RjNJR1dTZExsMXEyREVOQ2ZSWFBBdUw0bmFtUEZmT2Y2OEg4RzhPM3BKRUJU?=
 =?utf-8?B?QVY0SnRwUDh0TUlTbHhsT2ptZ1VONFIrU2M0ckpqMzl1NGdjcC81RXI5Z0hu?=
 =?utf-8?B?ZTFGeEVBdDVBRWpxOGc2N0RmL1V5R1VVQTF0ZmtQWitaOWZvem15MmpEU2ZW?=
 =?utf-8?B?UnhyT0xxZmhPeWg3bHl0M0pYTkNJSGExcFlzZXdJR01uN0RRV2VvS1RrRExV?=
 =?utf-8?B?UGI0MDgyWFRWbWdCdzVzWEpaYTd2bUxpQ2NhNjd2cE9pRFhkczZIWm5yekdB?=
 =?utf-8?B?NVl6UlAzWnAxbTliVG80YWVIYm1DRXU3Yk81cWJURUM0ME9panNqcDA3YW9B?=
 =?utf-8?B?Zk5rejdmbDdFQXQzMDVwdTRqandUMGcxR0FWNGF6aEhmZmYyNURqRnlsUmlu?=
 =?utf-8?B?bUNZb09KMnE0MUZwb2dFRHVpQ2lmcHVJbnFGTXRRdFowc2RaU3dBemFIRDdE?=
 =?utf-8?B?OWp6YXg3SU1wMGtZbE5GVTkyc3Q0dHhTKzRPdGZQWGNkTGRYc0V0VFprcDdp?=
 =?utf-8?B?RVlvNHRFcFhxZUU5UUpIZGV0SWpGdkx5TU90Y0hrZmFqcGNjaTlndlk5U0lY?=
 =?utf-8?B?eXNnZVZldlBWQnFLSmI3YzlqbFJFRUs0TER5RGhranB2RUF1L3RCakJHREZD?=
 =?utf-8?B?UFVPU3pCeDBMS1hlczlTMkk2OWF1UTdSWk9HK3AxdUJWMzZ5SkZZNFBjOG9T?=
 =?utf-8?B?S0FqVU8wWHlBZFVXZnpJN0wvWDNVZGxSRnFreFFrTU1FWXRpalRsRDF0eHMv?=
 =?utf-8?B?aVB1VFlSeDczOUVacXZqRmJnSjRWdnBnWU9BcnBnaVZVZEgzZ1JOTk92ZzRT?=
 =?utf-8?B?dkh6S3c1QnZGZHhsbnRhWkU1OEhBMVhBYWovWFhKS055SjhpNFgrNzM0SXA4?=
 =?utf-8?B?MWJXbDcvcjB4dkVuYmtjWUhtVlM1bVVaUVJJL0crRDRRdVRzODVtdXdoMWVT?=
 =?utf-8?B?OGRxM1d4aDBnYktKTUg2S013R2hBdm9QY2xWckF2TlpPODVJT2x4Y2lOQXhD?=
 =?utf-8?B?YURtNDlkSUtiMXhqblM2cmcrTFRHOUlmcXBocG94WnJlZlVXeWhDamtNZEMy?=
 =?utf-8?B?TzA2NzJqd0pMM1lmZVNEc2NDSXZVa0JseWpsY2s5SWpWd3paV3ZQR2tQeVpV?=
 =?utf-8?B?Y2NyVlZneVJFTzZScGJZZjBTZHB4VWhuRzl3YTZTbitqWjRkK1VGOHZlWFIx?=
 =?utf-8?B?MHczbDZvV3pSKzRCeWdyVDJzNzR3UDVXa040RTN5RkoyQzg4OTdZTkRzL0d3?=
 =?utf-8?B?OXIwT3VyRzBvU3REN1JJVE8yU2NsNlY2WkdyWnd4MGpGQWZraUp1VUNOa1g1?=
 =?utf-8?B?WTNxVGdZeHFuYkwzckJFNVRzVjB0VnhlNitUN2dadldIZWEzMGtZTjdZUWlK?=
 =?utf-8?B?V2RZRGh4Y01wVHl2V05zUUdvSkV5R1RKZ1VzYVN3QVhqTkVzZFlPSXFKM2sv?=
 =?utf-8?B?cWR0T3ErT3JOZERQTkJWanU2UW91NTlTSTNLZ2JXTkt1ZllSMHNZVWhmSjFQ?=
 =?utf-8?B?cmZvYmVQQUIyL095R3ZXZ090VTZDUXo1U3VsZXFSaUdzUTh3dVFoSENidFZT?=
 =?utf-8?Q?yYYSVh23XQ7xzudDAxPur6QoGlMl+DNkP0H7Acd?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ee094ca9-ed7b-4cfc-69c7-08d99005c276
X-MS-Exchange-CrossTenant-AuthSource: AM5PR04MB3089.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 18:01:06.4190
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QQbtyz182hOsB6th+TGOR3dIkXI5fdd4rfcypUNe3HYsgkin8mJedRs6CL6MH72z32HjahC/KExYTRxvgHHYZw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8197
Precedence: bulk
List-ID: <linux-ext4.vger.kernel.org>
X-Mailing-List: linux-ext4@vger.kernel.org

On 10/15/21 6:26 AM, Christoph Hellwig wrote:
> Use the proper helper to read the block device size.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Kees Cook <keescook@chromium.org>
> Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
> ---
>  drivers/block/drbd/drbd_int.h | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/block/drbd/drbd_int.h b/drivers/block/drbd/drbd_int.h
> index 5d9181382ce19..75fda53eed8cf 100644
> --- a/drivers/block/drbd/drbd_int.h
> +++ b/drivers/block/drbd/drbd_int.h
> @@ -1826,8 +1826,7 @@ static inline sector_t drbd_md_last_sector(struct drbd_backing_dev *bdev)
>  /* Returns the number of 512 byte sectors of the device */
>  static inline sector_t drbd_get_capacity(struct block_device *bdev)
>  {
> -	/* return bdev ? get_capacity(bdev->bd_disk) : 0; */
> -	return bdev ? i_size_read(bdev->bd_inode) >> 9 : 0;
> +	return bdev ? bdev_nr_sectors(bdev) : 0;
>  }
>  
>  /**
> 

Reviewed-by: Lee Duncan <lduncan@suse.com>