Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 15 Oct 2021 15:50:36 -0400
From:   "Theodore Ts'o" <tytso@mit.edu>
To:     Avi Deitcher <avi@deitcher.net>
Cc:     linux-ext4@vger.kernel.org
Subject: Re: algorithm for half-md4 used in htree directories
Message-ID: <YWnbjI9Fo0gKmwS5@mit.edu>
References: <CAF1vpkgPAy3FJ9mN22OVQ41jQAYoRdoCdqzYwRYYPXD4uucdpg@mail.gmail.com>
 <3A493D20-568A-4D63-A575-5DEEBFAAF41A@dilger.ca>
 <CAF1vpkigHMdKphnNjDm7=rR6TTxViHGGHi3bb64rsHG7KbqYzQ@mail.gmail.com>
 <CAF1vpkhwSOfGfErUUrp0YU5hSt58TtykTECiJXTcgqDtG0WVVg@mail.gmail.com>
 <YWSck57bsX/LqAKr@mit.edu>
 <CAF1vpkiKx3jArgjNBrid9-MSHBweGsFL0zu0UgDX_dq_hrkUgw@mail.gmail.com>
 <YWXGRgfxJZMe9iut@mit.edu>
 <CAF1vpkggQpYrg7Z2VVK69pPBo0rSjDUsm8nB8dyES27cmDEf2g@mail.gmail.com>
 <YWnSMXcR5anaYTEU@mit.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YWnSMXcR5anaYTEU@mit.edu>
Precedence: bulk

Oh, and taking a quick look at your program, here's at least one of
the bugs:

static void calculate(char *name) {
                      ^^^^^^^^^^
...
    __ext4fs_dirhash(name, sizeof(name), &hinfo);
                           ^^^^^^^^^^^^

With apologies to the movie "The Princess Bride"[1]:

    You fell victim to one of the classic blunders!  The most famous
    is to never get involved in a land war in Asia, but only slightly
    less well-known is this: 'taking the size of a C pointer is
    generally not what you had wanted to do'!  :-)

[1] https://www.youtube.com/watch?v=R7TFPQqglb4

    	  	    	       - Ted