Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp2952909pxb; Mon, 18 Oct 2021 05:29:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJygP/jYFs5wbtY/3YuS+UGYUUinV5HdmWvCVab07dzFc4hfxlpC7ym9vH2Bdgc8nUqRprv1 X-Received: by 2002:a17:906:7113:: with SMTP id x19mr30288898ejj.557.1634560146839; Mon, 18 Oct 2021 05:29:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634560146; cv=none; d=google.com; s=arc-20160816; b=joGQrLQz9bUCHWJ9H0csTLIfY99aNWn7OeRB3GbJc/5AmWO37qpeSH8NL+bQas+/lz MfrogsuFKnesQH6xghoNgJ54dlLdYJGo8ZcS95opSIHeguOUZyGKjHmYz0kZC0wfCBSx bkPPydbTpY8NbVFb3WrW1cPwmLRbS/NWx49Wzp4sg7Dh5R4wu+qJpZnNEvDpLbpgM/sJ P/BX/59NwfDFHpDdALkqQ+xBcsBUgpUs8mseGgma5em/lhzUphSkK5PHhFwbwpPbBOWd 4RiJ0YGsDuyblF9njDODyZhcq0Aw74kZd7agjqRyqPa+6k5Sbx4Rnfa1tZ97cfdpZqJP EjGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:mail-followup-to:message-id:subject:cc:to:from:date; bh=5qipqSjcfFnmY/FeGEgSODVnnLjEmejogL6cMCrvYqs=; b=J96+5jw3g7vAhA/9pAMBW6IsOCsSitK3l2216mZGtZnzvSYfJueG687unVwX3nqKFH bo4vAuWKpNCK3kq/bMOOVj1m9OoC4MXkUxDtJKYenqHPgh3XzhVQGl7obOQLuWxTkchw qPWzH3ceAkc6fVkJZAjLMyJxpGsgxYVoD6kIGTlFj/xFTYQBLEa3jyhO4Y44N3G4S1jw GGDGMeCR/tIOETd0wCF973D3tVTtbjYbAtl6APKQ8jwlvKqbFCgyFDlWIPrzaoK2xXup bJ6sTEJ4EOMyIX+/d855JeEwjpvr838tA5XNbdhKaqYk8KHHFFDa6pw5/rBIioV8cOvr IBFw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g13si20548742ejw.289.2021.10.18.05.28.21; Mon, 18 Oct 2021 05:29:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230005AbhJRM1e (ORCPT + 99 others); Mon, 18 Oct 2021 08:27:34 -0400 Received: from out30-42.freemail.mail.aliyun.com ([115.124.30.42]:49747 "EHLO out30-42.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229781AbhJRM1e (ORCPT ); Mon, 18 Oct 2021 08:27:34 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R791e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04426;MF=hsiangkao@linux.alibaba.com;NM=1;PH=DS;RN=12;SR=0;TI=SMTPD_---0Usi8-QT_1634559919; Received: from B-P7TQMD6M-0146.local(mailfrom:hsiangkao@linux.alibaba.com fp:SMTPD_---0Usi8-QT_1634559919) by smtp.aliyun-inc.com(127.0.0.1); Mon, 18 Oct 2021 20:25:21 +0800 Date: Mon, 18 Oct 2021 20:25:19 +0800 From: Gao Xiang To: Christoph Hellwig Cc: Dan Williams , Mike Snitzer , Ira Weiny , dm-devel@redhat.com, linux-xfs@vger.kernel.org, nvdimm@lists.linux.dev, linux-s390@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH 07/11] dax: remove dax_capable Message-ID: Mail-Followup-To: Christoph Hellwig , Dan Williams , Mike Snitzer , Ira Weiny , dm-devel@redhat.com, linux-xfs@vger.kernel.org, nvdimm@lists.linux.dev, linux-s390@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, virtualization@lists.linux-foundation.org References: <20211018044054.1779424-1-hch@lst.de> <20211018044054.1779424-8-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20211018044054.1779424-8-hch@lst.de> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Mon, Oct 18, 2021 at 06:40:50AM +0200, Christoph Hellwig wrote: > Just open code the block size and dax_dev == NULL checks in the callers. > > Signed-off-by: Christoph Hellwig > --- > drivers/dax/super.c | 36 ------------------------------------ > drivers/md/dm-table.c | 22 +++++++++++----------- > drivers/md/dm.c | 21 --------------------- > drivers/md/dm.h | 4 ---- > drivers/nvdimm/pmem.c | 1 - > drivers/s390/block/dcssblk.c | 1 - > fs/erofs/super.c | 11 +++++++---- For erofs part, Reviewed-by: Gao Xiang Thanks, Gao Xiang