Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <CAF1vpkgPAy3FJ9mN22OVQ41jQAYoRdoCdqzYwRYYPXD4uucdpg@mail.gmail.com>
 <3A493D20-568A-4D63-A575-5DEEBFAAF41A@dilger.ca> <CAF1vpkigHMdKphnNjDm7=rR6TTxViHGGHi3bb64rsHG7KbqYzQ@mail.gmail.com>
 <CAF1vpkhwSOfGfErUUrp0YU5hSt58TtykTECiJXTcgqDtG0WVVg@mail.gmail.com>
 <YWSck57bsX/LqAKr@mit.edu> <CAF1vpkiKx3jArgjNBrid9-MSHBweGsFL0zu0UgDX_dq_hrkUgw@mail.gmail.com>
 <YWXGRgfxJZMe9iut@mit.edu> <CAF1vpkggQpYrg7Z2VVK69pPBo0rSjDUsm8nB8dyES27cmDEf2g@mail.gmail.com>
 <YWnSMXcR5anaYTEU@mit.edu> <YWnbjI9Fo0gKmwS5@mit.edu>
In-Reply-To: <YWnbjI9Fo0gKmwS5@mit.edu>
From:   Avi Deitcher <avi@deitcher.net>
Date:   Mon, 18 Oct 2021 19:56:13 +0300
Message-ID: <CAF1vpkiK6=gvqD27sLaDnB79ekjKzYjwEP5=u9+D_mQi_5oJwA@mail.gmail.com>
Subject: Re: algorithm for half-md4 used in htree directories
To:     "Theodore Ts'o" <tytso@mit.edu>
Cc:     linux-ext4@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Yes, it definitely was my silly use of sizeof() instead of strlen().
Switch to strlen(), and my test program's output (using little-endian
for each u32) gives the exact same output.

Looks like I owe you that beer (and happy to share it with you) next
time we are in the same place!

On Fri, Oct 15, 2021 at 10:50 PM Theodore Ts'o <tytso@mit.edu> wrote:
>
> Oh, and taking a quick look at your program, here's at least one of
> the bugs:
>
> static void calculate(char *name) {
>                       ^^^^^^^^^^
> ...
>     __ext4fs_dirhash(name, sizeof(name), &hinfo);
>                            ^^^^^^^^^^^^
>
> With apologies to the movie "The Princess Bride"[1]:
>
>     You fell victim to one of the classic blunders!  The most famous
>     is to never get involved in a land war in Asia, but only slightly
>     less well-known is this: 'taking the size of a C pointer is
>     generally not what you had wanted to do'!  :-)
>
> [1] https://www.youtube.com/watch?v=R7TFPQqglb4
>
>                                - Ted


-- 
Avi Deitcher
avi@deitcher.net
Follow me http://twitter.com/avideitcher
Read me http://blog.atomicinc.com