Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp3234130pxb; Mon, 18 Oct 2021 10:49:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyvuQXEqTgEG1jZlflyNIf0Ver6J0U/VwOx1Jn84Bk2gAQv5V1ZARyqWJ1C3tegsUMkR3+m X-Received: by 2002:a17:907:7691:: with SMTP id jv17mr30027196ejc.378.1634579382916; Mon, 18 Oct 2021 10:49:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634579382; cv=none; d=google.com; s=arc-20160816; b=cythxGeX9t8J4L8MZO7iBUEHx1vZp22WQxWaJih92E/lrx+ZvBH5VSOHCPF2UFJPTv 108M1sEZANMLWvkd7hRAEkNyG1Dn8Pzf4/FCh0eoXmqLe4dMph1HjIIjr0g/frDYiGkq O5eUL8lf4Om3WYVeB9hNwOTQuk12L3M7aAfwkTYQ5rRtgBFC/4YwH6kDBxeNOOrVm5Ww /poJ5XCAwRCQtvoOAjo0BznICtcCk3DKZedp3Sn1Glv5HJqE/5Oz6fZ25UHpsLp5qEow pxQAcMgXUBWk3dgR/0pjzAxyoQnF/EbUcDgfCBnkkn9/cnTD2gb0dUgwYF/j8uo28QDU kyWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=m4iEGbscF67yNO4NRuzcQmEmbPSlh65Fo1hYQ3vpXzc=; b=vCsAx+nDK6MORwzLRn7AQWQGh+R7CbeDusf9odocrdcaefrC+yRR1v07RBWcofphLk qlgywL88GD2fLf9FZQ8o/ZzAPtBzO7zoD78ne2NXJbU9ETs0Oif4eRskqpQO25fgj484 CouE59HlLNKtsfM7h4CjaA3TL4D8cm2m9MyM6Jjsdi/zU/1/BkKfRZoMMjJH4fiKigku oCYtNMOP3EAL0qWoED0/55dZW1bLsajsMADxRvWpgPEFgLaUAP9LvmdrFZOO7HQThY4a h8Xv1YBh1gPaRedKDC4RlGBcC0CSpiR7lHf/dHqdk50O3D7Qv6kgncZ7d6HpZ1uUTDQK MYBw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s5si24384774ejs.270.2021.10.18.10.49.18; Mon, 18 Oct 2021 10:49:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234157AbhJRRvU (ORCPT + 99 others); Mon, 18 Oct 2021 13:51:20 -0400 Received: from verein.lst.de ([213.95.11.211]:35328 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231404AbhJRRvU (ORCPT ); Mon, 18 Oct 2021 13:51:20 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 67F2A68BFE; Mon, 18 Oct 2021 19:49:01 +0200 (CEST) Date: Mon, 18 Oct 2021 19:49:01 +0200 From: Christoph Hellwig To: Jens Axboe Cc: Christoph Hellwig , Coly Li , Mike Snitzer , Song Liu , David Sterba , Josef Bacik , Theodore Ts'o , OGAWA Hirofumi , Dave Kleikamp , Ryusuke Konishi , Anton Altaparmakov , Konstantin Komarov , Kees Cook , Phillip Lougher , Jan Kara , linux-block@vger.kernel.org, dm-devel@redhat.com, drbd-dev@lists.linbit.com, linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net, ntfs3@lists.linux.dev, reiserfs-devel@vger.kernel.org Subject: Re: don't use ->bd_inode to access the block device size v3 Message-ID: <20211018174901.GA3990@lst.de> References: <20211018101130.1838532-1-hch@lst.de> <4a8c3a39-9cd3-5b2f-6d0f-a16e689755e6@kernel.dk> <20211018171843.GA3338@lst.de> <2f5dcf79-8419-45ff-c27c-68d43242ccfe@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2f5dcf79-8419-45ff-c27c-68d43242ccfe@kernel.dk> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Mon, Oct 18, 2021 at 11:40:51AM -0600, Jens Axboe wrote: > static inline loff_t bdev_nr_bytes(struct block_device *bdev) > { > - return i_size_read(bdev->bd_inode); > + return bdev->bd_nr_sectors; This hunk needs to go into bdev_nr_sectors, and the bdev_nr_bytes probably wants to call bdev_nr_sectors and do the shifting.