Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp3549493pxb; Mon, 18 Oct 2021 18:07:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxWRk9MGU2ejWZy8C7K6MhJoqwv0J7ElP3IbXmj88ZEGY1pUH5yHylsle61k51EoK0vmI31 X-Received: by 2002:a17:902:d202:b0:13a:709b:dfb0 with SMTP id t2-20020a170902d20200b0013a709bdfb0mr30220991ply.34.1634605657088; Mon, 18 Oct 2021 18:07:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634605657; cv=none; d=google.com; s=arc-20160816; b=f7nkxfYnqoVilgvjq90yrGJz5gF/RKXwoGZw+xcIEjHGD78ycvLjkd/iHPkuMfuMB5 AT3Vp2ySXsvp8i7P9QkBE0yE9i1ob30N5wpPHemrvT2TCEgOVEAsUGfyTaKKqp9XaTyW qDJwXXhsPfPT0yRZ6CS+fMkOTJSOeYQbTu3J5e5lQhCwh8JgUngnuRomULTQdvMsH/Fh ECk4tpX3kBOo390K91sf5zaBqvsQ3UVNoXb8Z3/RelMAU1ll4+z1MGZF/9tYa/AGljPQ paWX3f3WSBBZgT3OBr3xoH980R+MrvfqzJVRip0tJOURF9v+sSdhKaMHxnj/52ccDbea h6uA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=HZB3VynRj4BSJ+DoffwFLiPJvzPYXkayF1wJVNoXqZo=; b=QDX95AeqLjOBdaFYYocQX8N0Ltd039afRK2PFtqszU/MY/82vpfuPx7uR0LsOarcGB QYO1/D2yQ2gTsqvKyH21QNep9tevDq/AN0ZDGYGGQJbQqJaqVxGLhe4wbsrg5FehYBAY clSOMeeRfkryh7FpPrxe3dDVG1bOEchydn5SdU9L/TzqQukt4wdl6ErAtKTQ2xeuFBKt ZV9aL25Ymjm2Y0XMVbJO7L9otMjvXJKW3C4BMWCQvhtLwIQKx/3Y/ga0FVoPylyCTThb bPkK44UaUfUQSy1I136z3i2wNLRYbeYqHaXaWWWlKm0gmBMyos5xf+frhTfV3N/YSDqG DlPw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="qa7Rg2/+"; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v7si1437709pjk.36.2021.10.18.18.07.18; Mon, 18 Oct 2021 18:07:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="qa7Rg2/+"; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230110AbhJSBGd (ORCPT + 99 others); Mon, 18 Oct 2021 21:06:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229529AbhJSBGd (ORCPT ); Mon, 18 Oct 2021 21:06:33 -0400 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28A58C06161C; Mon, 18 Oct 2021 18:04:21 -0700 (PDT) Received: by mail-lf1-x136.google.com with SMTP id x27so3607526lfa.9; Mon, 18 Oct 2021 18:04:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=HZB3VynRj4BSJ+DoffwFLiPJvzPYXkayF1wJVNoXqZo=; b=qa7Rg2/+uz+UIDCny84Tw5bep3SlaUI84n/FAaUaxIzAubmeoa1ydJFT64PdI4Dc2i AgPnjhE+kBzSH4MdsJeGrFG4f0xqH2HBhd6pbyQr8O8l98NNiVXw+7LLIlFbcV+xxCqf RA02zj7IDRlPmKt2XOaxe9T0CtUPo6hRSub6+1M9syuYXVu4HWpZ0mdRM4b+vfFK8OI9 lTRtKN80UFv+SDfLWbeeA+TcDubhn33n9WeCF3bZ9pFOuoi5rOJVIPb1Sykzu+pmiRnV qHPYjU4GPUjtfi/yhGpy4ABO9h9df+GLOdeLNWFNTfyVWJ/R/s+xiv91lAtBOCzSytMJ pKbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=HZB3VynRj4BSJ+DoffwFLiPJvzPYXkayF1wJVNoXqZo=; b=f/rmWlpawhtZOPU9HDTdtyCwrb1+SPRjg0R/Vpb39hAE7SEp2KSwaAI/pecP3intm5 HjyxBLMa/+usWFBt8nmfh8/6KaMl+mS67ElvXXqmEav4suiRI+Ykv4IVkpY+Gt0gP1yP eP/5Wh0lmTstCKs3W0JFu+JK4Ld0i3BIPrrxCBic/WQWfOaNDH/73evsWY6aPckqgDop ikGhB20xqi6i5tAk1ZwRqfz7aROkrb1D5zQwZ32ZkfI1TLa8/AiPoD++EMahx5jVYrq6 Jsh1l25PclxpWLexHVwoQMlq++ISs30LmLYvhGwJjV3w2f1X1nee4VuF0WSt3Ca5Rb+y hDhw== X-Gm-Message-State: AOAM531Znok5UQDii88R/iFyx6NDHNcgH7f2fDY4ZiCiSQq1YJ7Gl39T 9R8rMztxXNRyX2qVRG7Enh5SH/9wDN23KQ== X-Received: by 2002:a05:6512:1284:: with SMTP id u4mr3097377lfs.614.1634605459500; Mon, 18 Oct 2021 18:04:19 -0700 (PDT) Received: from kari-VirtualBox (85-23-89-224.bb.dnainternet.fi. [85.23.89.224]) by smtp.gmail.com with ESMTPSA id f10sm1533239lfs.56.2021.10.18.18.04.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Oct 2021 18:04:18 -0700 (PDT) Date: Tue, 19 Oct 2021 04:04:16 +0300 From: Kari Argillander To: Jens Axboe Cc: Christoph Hellwig , Coly Li , Mike Snitzer , Song Liu , David Sterba , Josef Bacik , Theodore Ts'o , OGAWA Hirofumi , Dave Kleikamp , Ryusuke Konishi , Anton Altaparmakov , Konstantin Komarov , Kees Cook , Phillip Lougher , Jan Kara , linux-block@vger.kernel.org, dm-devel@redhat.com, drbd-dev@lists.linbit.com, linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net, ntfs3@lists.linux.dev, reiserfs-devel@vger.kernel.org Subject: Re: don't use ->bd_inode to access the block device size v3 Message-ID: <20211019010416.vgecxu6wnvwi7fii@kari-VirtualBox> References: <20211018101130.1838532-1-hch@lst.de> <4a8c3a39-9cd3-5b2f-6d0f-a16e689755e6@kernel.dk> <20211018171843.GA3338@lst.de> <2f5dcf79-8419-45ff-c27c-68d43242ccfe@kernel.dk> <20211018174901.GA3990@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Mon, Oct 18, 2021 at 11:53:08AM -0600, Jens Axboe wrote: snip.. > diff --git a/include/linux/genhd.h b/include/linux/genhd.h > index 7b0326661a1e..a967b3fb3c71 100644 > --- a/include/linux/genhd.h > +++ b/include/linux/genhd.h > @@ -236,14 +236,14 @@ static inline sector_t get_start_sect(struct block_device *bdev) > return bdev->bd_start_sect; > } > > -static inline loff_t bdev_nr_bytes(struct block_device *bdev) > +static inline sector_t bdev_nr_sectors(struct block_device *bdev) > { > - return i_size_read(bdev->bd_inode); > + return bdev->bd_nr_sectors; > } > > -static inline sector_t bdev_nr_sectors(struct block_device *bdev) > +static inline loff_t bdev_nr_bytes(struct block_device *bdev) > { > - return bdev_nr_bytes(bdev) >> SECTOR_SHIFT; > + return bdev_nr_setors(bdev) << SECTOR_SHIFT; setors -> sectors > } > > static inline sector_t get_capacity(struct gendisk *disk) > > -- > Jens Axboe >