Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 25 Oct 2021 11:42:27 +0200
From:   Lukas Czerner <lczerner@redhat.com>
To:     Laurent GUERBY <laurent@guerby.net>
Cc:     linux-ext4@vger.kernel.org
Subject: Re: How to force EXT4_MB_GRP_CLEAR_TRIMMED on a live ext4?
Message-ID: <20211025094227.yio3cjpboxumt5ml@work>
References: <1634984680.26818.10.camel@guerby.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1634984680.26818.10.camel@guerby.net>
Precedence: bulk

On Sat, Oct 23, 2021 at 12:24:40PM +0200, Laurent GUERBY wrote:
> Hi,
> 
> When using fstrim on an ext4 filesystem trim are not issued for
> EXT4_MB_GRP_WAS_TRIMMED space which is a useful optimization.
> 
> Is there a way to force a complete trim on a mounted ext4 filesystem??
> 
> My (limited) understanding of the code is that
> EXT4_MB_GRP_CLEAR_TRIMMED should be called to do so.
> 
> My use case is having live migrated a virtual machine root disk from
> one storage to another, the target supporting trim, but since fstrim in
> the VM post migration does mostly nothing (assumes most space was
> trimmed) I cannot release space to the new storage.

Hi,

interesting. I don't think this scenario was ever considered so no,
there is no way to bypass the optimization other than just unmount and
mount the file system again, which I can understand is inconvenient for
root file system ;)


> 
> I tried mount -o remount but without effect.?e2fsprogs don't seem to
> have an option/tool to do this either.
> 
> I've seen suggestion that rebooting will do the job but the whole point
> of live migration is to avoid reboot :).
> 
> I did end up creating dummy files to fill the filesystem and then
> removing them, but this is far less efficient than what a filesystem
> tool could do.

Yeah, that's bad. The information is stored in the buddy cache in memory
and AFAIK is only dropped on unmount. I'll have to think about how to
clear either the cache or selectively just the flag.

What would be more convenient way of doing this for you, -o remount, or
using let's say tune2fs ? I am not promising anything yet, but I'll think
about how to implement it.


Meanwhile other than umount/mount, or actually writing to the dummy files,
you can try to use fallocate to allocate all the remaining space in the
file system and subsequently removing it. That should be more efficient,
but don't forget to sync after remove to make sure the space is released
before you call fstrim.

You could also force fsck on ro file system and use -E discard to trim the
free space but I can't say I recommend it.

-Lukas

> 
> Thanks in advance for your help,
> 
> Sincerely,
> 
> Laurent
>