Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp1064655pxb; Wed, 27 Oct 2021 18:36:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxBJvDnEEPKIwfboT9Gba3gfz4eIEQnMgdrM/mbt3G9muUdR5UnTGzoqYoYZBdDGL6x2bm6 X-Received: by 2002:a17:906:284e:: with SMTP id s14mr1467220ejc.332.1635385013824; Wed, 27 Oct 2021 18:36:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635385013; cv=none; d=google.com; s=arc-20160816; b=qj6Q8IFQIvyNx9CdtFOJJkukna+b6ecIpMCfMqs0wnxYQq/wfiPsNIUfs502JngiaH X7j11Cykv0tB9usGG5Fd0ZhW8vGTJ8K0QsPDJQR9E/U5yu2Ga+l1k5tgCYb4XauDNa2U 8qJCFodDhOynmnoX78zY2xjzShMAuP1+uuma3vJ0dnXSfNP6AA2SQXdo6fjAprVgUzos vX0oHMp9R5hXsEVvuN4L/5oR+wDzFuNP/U4msGUEFqsZF3MpMCsf+3qfyRTILGasyG+/ aNMgBLxCFBfOVWDDHAKyemc/IaK0A00BxwM57+xhc0AFpqUn4/rKg8C1pwxh7euvYKcW pyWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=h7Igm7cptJn/BPiAKOvXNcYjYvau2fVkwbEBPR40Qac=; b=NPnXwzPM+8kWuhJJ8eCN0ccyz78yHqwmLiqLZ0q/SAXYJ9aNh48KlQX8WNrTToOgpY VJFNTDDrGmnO3f2sGdG7TlYWd3t2qqVy4C9tkfINZ7YfbNDryiKVys5HlKwcWYtcIzuX G9Rh5fw+krIsOW4uwC1GXidCz9AaaSABiK+Yx/6gZD+Y16vtP8xLqbmMK1FlyHTRZI9F 7wcv+0f0/7lj3BQ3Exw2wYFQCesGNNLZxLhba76s3RCgxUazkPe8CdI7GY6hn0FDkkzd Gzt1JnXipGukMTSfFLAOGTFn4gupk+hUg+bHfCzZt2EyLrwxidR05PlU3kr/73eMHdjZ 0ZGg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel-com.20210112.gappssmtp.com header.s=20210112 header.b=nDN9pMyc; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k9si1792921eje.178.2021.10.27.18.36.30; Wed, 27 Oct 2021 18:36:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@intel-com.20210112.gappssmtp.com header.s=20210112 header.b=nDN9pMyc; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229675AbhJ1Biu (ORCPT + 99 others); Wed, 27 Oct 2021 21:38:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55060 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229534AbhJ1Bit (ORCPT ); Wed, 27 Oct 2021 21:38:49 -0400 Received: from mail-pf1-x429.google.com (mail-pf1-x429.google.com [IPv6:2607:f8b0:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2EE9C061570 for ; Wed, 27 Oct 2021 18:36:23 -0700 (PDT) Received: by mail-pf1-x429.google.com with SMTP id k26so4452804pfi.5 for ; Wed, 27 Oct 2021 18:36:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=h7Igm7cptJn/BPiAKOvXNcYjYvau2fVkwbEBPR40Qac=; b=nDN9pMycEij+MvvSNlzKvOXo8vpzX9jkSPwoFJ+o4gm3MZL73HDZVz6xJnzjMcbY/h uxqb8I8SZcSxzyFyBYzX7/LIRnqjurLkxyKCXt7vyn4OmQMNyDT08nPuKyqwzm30Iyl3 YY7ptNRp5CFdB0o2rG3ZcydKtS+P5TBWxjp9noe/kCn6hPByhWq1BSGoPPpBqB7Delwx 7OpBf+W0FVyg/SVq09iZbg3g6KwhgjDGpF6ftYJKhyxVAQrctr7Lax8JbvRVtA2fECbQ ljET309ufBhSYyMPecwX45v0eqgX6tTFFZvO7U3Ppi7VtOy0tKDgD/ePUmL2riKDB8uo 7IaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=h7Igm7cptJn/BPiAKOvXNcYjYvau2fVkwbEBPR40Qac=; b=4826IV8dTuTHGZ7WGx/w62fHwSF9McypP/UNGXppX1+661/RoK7cw1OnHvEg2oUSS9 Xc/q4HIRmwOaznf1PAdHOB/JhBJd2CPQMqrci52eR0w9o3l6pMDAKeHtHTZcGAenbhzj zHrIXkteKSJHR2QTNfleXTC3XNU8/mMRcMjxFB0jXkPRybovoSvHDpz2tx6j0NKiJ3Lf X5QPS4z/BeNW0nKYAFhHUbx/t017MmduvNm2ZnrG9Hetc14/RlRTbwQbJMWeZRAZem6A FIaahMkYgXL6ZB9j7iBc5fw70FbI1827Ly5TqR5STeLipS+WToGQ/eC9BuF9bhM5GM60 gLvg== X-Gm-Message-State: AOAM531yyxHooKWwotx/DjY7KQwsRkvfzmxWQjFuLyOVtYoU+tqbwDqb 0yJ3d3qMlInUPaZj0W17BXwWDHkRnjFtB/t+zuc9jg== X-Received: by 2002:a05:6a00:140e:b0:444:b077:51ef with SMTP id l14-20020a056a00140e00b00444b07751efmr1317245pfu.61.1635384983516; Wed, 27 Oct 2021 18:36:23 -0700 (PDT) MIME-Version: 1.0 References: <20211018044054.1779424-1-hch@lst.de> <20211018044054.1779424-10-hch@lst.de> In-Reply-To: <20211018044054.1779424-10-hch@lst.de> From: Dan Williams Date: Wed, 27 Oct 2021 18:36:11 -0700 Message-ID: Subject: Re: [PATCH 09/11] dm-log-writes: add a log_writes_dax_pgoff helper To: Christoph Hellwig , Mike Snitzer Cc: Ira Weiny , device-mapper development , linux-xfs , Linux NVDIMM , linux-s390 , linux-fsdevel , linux-erofs@lists.ozlabs.org, linux-ext4 , virtualization@lists.linux-foundation.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Sun, Oct 17, 2021 at 9:41 PM Christoph Hellwig wrote: > > Add a helper to perform the entire remapping for DAX accesses. This > helper open codes bdev_dax_pgoff given that the alignment checks have > already been done by the submitting file system and don't need to be > repeated. Looks good. Mike, ack?