Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 3 Nov 2021 15:14:57 -0400
From:   Eric Whitney <enwlinux@gmail.com>
To:     Theodore Ts'o <tytso@mit.edu>
Cc:     Eric Whitney <enwlinux@gmail.com>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] Revert "ext4: enforce buffer head state assertion in
 ext4_da_map_blocks"
Message-ID: <20211103191457.GA3838@localhost.localdomain>
References: <20211012171901.5352-1-enwlinux@gmail.com>
 <163415796177.214938.9752602885736039327.b4-ty@mit.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <163415796177.214938.9752602885736039327.b4-ty@mit.edu>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

* Theodore Ts'o <tytso@mit.edu>:
> On Tue, 12 Oct 2021 13:19:01 -0400, Eric Whitney wrote:
> > This reverts commit 948ca5f30e1df0c11eb5b0f410b9ceb97fa77ad9.
> > 
> > Two crash reports from users running variations on 5.15-rc4 kernels
> > suggest that it is premature to enforce the state assertion in the
> > original commit.  Both crashes were triggered by BUG calls in that
> > code, indicating that under some rare circumstance the buffer head
> > state did not match a delayed allocated block at the time the
> > block was written out.  No reproducer is available.  Resolving this
> > problem will require more time than remains in the current release
> > cycle, so reverting the original patch for the time being is necessary
> > to avoid any instability it may cause.
> > 
> > [...]
> 
> Applied, thanks!
> 
> [1/1] Revert "ext4: enforce buffer head state assertion in ext4_da_map_blocks"
>       commit: 52264b162a51eadb0adcb55297cf91905c6ede98
> 
> Best regards,
> -- 
> Theodore Ts'o <tytso@mit.edu>

Hi Ted:

This reversion isn't visible in the 5.15 kernel.  We'll want to get this in as
a bug fix to 5.15.1 if possible.  Please let me know if there's anything I can
do to expedite.

Thanks,
Eric