Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Andreas Dilger <adilger@dilger.ca>
Message-Id: <BEFE9A1D-A336-4C19-9B9A-5343EC3D4364@dilger.ca>
Content-Type: multipart/signed;
 boundary="Apple-Mail=_3E73D08C-3831-44DA-8C02-F90DCC391293";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: [PATCH 1/2] ext4: Change s_last_trim_minblks type to unsigned
 long
Date:   Wed, 3 Nov 2021 14:20:05 -0600
In-Reply-To: <20211103145122.17338-1-lczerner@redhat.com>
Cc:     linux-ext4@vger.kernel.org, tytso@mit.edu
To:     Lukas Czerner <lczerner@redhat.com>
References: <20211103145122.17338-1-lczerner@redhat.com>
Precedence: bulk


--Apple-Mail=_3E73D08C-3831-44DA-8C02-F90DCC391293
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii

On Nov 3, 2021, at 8:51 AM, Lukas Czerner <lczerner@redhat.com> wrote:
>=20
> There is no good reason for the s_last_trim_minblks to be atomic. =
There is
> no data integrity needed and there is no real danger in setting and
> reading it in a racy manner. Change it to be unsigned long, the same =
type
> as s_clusters_per_group which is the maximum that's allowed.
>=20
> Signed-off-by: Lukas Czerner <lczerner@redhat.com>
> Suggested-by: Andreas Dilger <adilger@dilger.ca>

Reviewed-by: Andreas Dilger <adilger@dilger.ca>

Could also add for reference:

Fixes: 3d56b8d2c74c ("ext4: Speed up FITRIM by recording flags in =
ext4_group_info")

> ---
> fs/ext4/ext4.h    | 2 +-
> fs/ext4/mballoc.c | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>=20
> diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
> index 3825195539d7..92a155401f61 100644
> --- a/fs/ext4/ext4.h
> +++ b/fs/ext4/ext4.h
> @@ -1660,7 +1660,7 @@ struct ext4_sb_info {
> 	struct task_struct *s_mmp_tsk;
>=20
> 	/* record the last minlen when FITRIM is called. */
> -	atomic_t s_last_trim_minblks;
> +	unsigned long s_last_trim_minblks;
>=20
> 	/* Reference to checksum algorithm driver via cryptoapi */
> 	struct crypto_shash *s_chksum_driver;
> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
> index 72bfac2d6dce..eda550ec3956 100644
> --- a/fs/ext4/mballoc.c
> +++ b/fs/ext4/mballoc.c
> @@ -6374,7 +6374,7 @@ ext4_trim_all_free(struct super_block *sb, =
ext4_group_t group,
> 	ext4_lock_group(sb, group);
>=20
> 	if (!EXT4_MB_GRP_WAS_TRIMMED(e4b.bd_info) ||
> -	    minblocks < atomic_read(&EXT4_SB(sb)->s_last_trim_minblks)) =
{
> +	    minblocks < EXT4_SB(sb)->s_last_trim_minblks) {
> 		ret =3D ext4_try_to_trim_range(sb, &e4b, start, max, =
minblocks);
> 		if (ret >=3D 0)
> 			EXT4_MB_GRP_SET_TRIMMED(e4b.bd_info);
> @@ -6475,7 +6475,7 @@ int ext4_trim_fs(struct super_block *sb, struct =
fstrim_range *range)
> 	}
>=20
> 	if (!ret)
> -		atomic_set(&EXT4_SB(sb)->s_last_trim_minblks, minlen);
> +		EXT4_SB(sb)->s_last_trim_minblks =3D minlen;
>=20
> out:
> 	range->len =3D EXT4_C2B(EXT4_SB(sb), trimmed) << =
sb->s_blocksize_bits;
> --
> 2.31.1
>=20


Cheers, Andreas


--Apple-Mail=_3E73D08C-3831-44DA-8C02-F90DCC391293
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - http://gpgtools.org

iQIzBAEBCAAdFiEEDb73u6ZejP5ZMprvcqXauRfMH+AFAmGC7vYACgkQcqXauRfM
H+AiGA//RtyquN9vP8a20nqdfPYyLHz8m7OTUyroI6n4HeEzkGmBpnmY6P3Kq66A
yX9lfSBayq8A0a/2H2f36s80zgRRZWVnd0jawmDEY5toN0bxAbiDNSFx/xnm1t0X
vOsGmWteXhSwFPFliN9+5OVXVUvJaWrMAzSKDqu0KLCVdIhH+rtFD9HPcfhw0AJx
hV3T1oiTyJO+W0NW8PMSXuZm7M7F0jYrM+btYvxq0bquqnsop4/f79S71RokVxTD
3Bl/oJtKHfBv5mBQ1CkKgj+Hd5Ss0vvq8whAo4xbzzlBQ5ts+YldF43FCf6sdfRn
6lP46Wmc4M1bKSKKHr96Qllw3ibrXJ3+1t6+orpfTCTewoFoMe3g4+AnCkg6qSqi
UyPMEd0KVBxoi/TGRqPMkg4u0i6xnoSAlDZ/T1P0cXvCXiOGWod0DxYSR+Kreon0
B/AJO8QrUsbuVKGLjzGWtEuf151wQi6via1H9a2m62KPn4l9skMEc4l0X/H5vfjF
o55vnETmCAlAI1hmARRZLHW//AYbgq3hKKBC/hgN2h3ENsWKofwCgUW3p4N+X5hr
hDlVbC3THdsj7QeHAH+tSEmMsaJixHNuyEg9jtNvN3sjUaCY4wAuNAombXxQusUm
DZu/5Z+zTTmq4xKaX6KOQaLXj1XY54YL/gjxTSd8mNFlFsOvQu4=
=k7r/
-----END PGP SIGNATURE-----

--Apple-Mail=_3E73D08C-3831-44DA-8C02-F90DCC391293--