Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 3 Nov 2021 23:33:18 -0400
From:   "Theodore Ts'o" <tytso@mit.edu>
To:     Lukas Czerner <lczerner@redhat.com>
Cc:     fstests@vger.kernel.org, linux-ext4@vger.kernel.org, guan@eryu.me
Subject: Re: [PATCH v4] ext4: add test for all ext4/ext3/ext2 mount options
Message-ID: <YYNUfvH52COSOnai@mit.edu>
References: <20211026093112.26221-1-lczerner@redhat.com>
 <20211102105911.5790-1-lczerner@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211102105911.5790-1-lczerner@redhat.com>
Precedence: bulk

> +_has_kernel_config()
> +{
> +	option=$1
> +	config="/lib/modules/$(uname -r)/build/.config"
> +	grep -qE "^${option}=[my]" $config
> +}

In my test infrastructure, /lib/modules/$Kver/build/.config doesn't
exist.  That's because I build the kernel without any modules, and
then launch kvm using its --kernel command-line option.  This really
helps with development velocity, since the developer doesn't need to
waste time installing the kernel, and/or building a kernel rpm or
dpkg.  Instead, kvm can just launch the kernel directly out of the
build tree:

/usr/bin/kvm ... --kernel /build/ext4/arch/x86/boot/bzImage ..

So it would be nice if _has_kernel_config also checks to see if
/proc/config.gz exists, and if so, tries to use it.

Thanks,

			       	   	 - Ted