Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 13 Jan 2022 13:08:07 +0100
From:   Lukas Czerner <lczerner@redhat.com>
To:     Jon Hunter <jonathanh@nvidia.com>
Cc:     linux-ext4@vger.kernel.org, tytso@mit.edu,
        linux-fsdevel@vger.kernel.org,
        "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH v3 12/13] ext4: switch to the new mount api
Message-ID: <20220113120807.xlyg4wmbbhajuftu@work>
References: <20211021114508.21407-1-lczerner@redhat.com>
 <20211021114508.21407-13-lczerner@redhat.com>
 <286d36c9-e9ab-b896-e23c-2a95c6385817@nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <286d36c9-e9ab-b896-e23c-2a95c6385817@nvidia.com>
Precedence: bulk

On Thu, Jan 13, 2022 at 11:29:24AM +0000, Jon Hunter wrote:
> Hi Lukas,
> 
> On 21/10/2021 12:45, Lukas Czerner wrote:
> > Add the necessary functions for the fs_context_operations. Convert and
> > rename ext4_remount() and ext4_fill_super() to ext4_get_tree() and
> > ext4_reconfigure() respectively and switch the ext4 to use the new api.
> > 
> > One user facing change is the fact that we no longer have access to the
> > entire string of mount options provided by mount(2) since the mount api
> > does not store it anywhere. As a result we can't print the options to
> > the log as we did in the past after the successful mount.
> > 
> > Signed-off-by: Lukas Czerner <lczerner@redhat.com>
> 
> 
> I have noticed the following error on -next on various ARM64 platforms that
> we have ...
> 
>  ERR KERN /dev/mmcblk1: Can't open blockdev
> 
> I have bisected this, to see where this was introduced and bisect is
> pointing to this commit. I have not looked any further so far, but wanted to
> see if you had any ideas/suggestions?

Hi,

this error does not come from the ext4, but probably rather from vfs. More
specifically from get_tree_bdev()

        bdev = blkdev_get_by_path(fc->source, mode, fc->fs_type);
        if (IS_ERR(bdev)) {
                errorf(fc, "%s: Can't open blockdev", fc->source);
                return PTR_ERR(bdev);
        }

I have no idea why this fails in your case. Do you know what kind of
error it fails with? Any oher error or warning messages preceding the one you
point out in the logs?

I assume that this happens on mount and the device that you're trying to
mount contains ext4 file system? Ext4 is not the only file system
utilizing the new mount api, can you try the same with xfs on the device?

Does this happen only on some specific devices? I see that the error
is mentioning /dev/mmcblk1. Is it the case that it only affects MMC ?
Does this happen when you try to mount a different type of block device
with ext4 on it?

Any specific mount options you're using? Is it rw mount? If so, any
chance the device is read only?

Do you have any way of reliably reproducing this?

Thanks!
-Lukas
> 
> Cheers
> Jon
> 
> -- 
> nvpublic
>