Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5057DC433EF for ; Tue, 23 Nov 2021 21:17:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240431AbhKWVU1 (ORCPT ); Tue, 23 Nov 2021 16:20:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239683AbhKWVUR (ORCPT ); Tue, 23 Nov 2021 16:20:17 -0500 Received: from mail-pg1-x535.google.com (mail-pg1-x535.google.com [IPv6:2607:f8b0:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 38131C061574 for ; Tue, 23 Nov 2021 13:17:09 -0800 (PST) Received: by mail-pg1-x535.google.com with SMTP id m15so205979pgu.11 for ; Tue, 23 Nov 2021 13:17:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PQeh1LIqbqFtSovgn5WZ7VLYBwfefd3KuHYAxcJ6bdE=; b=z/Kv5aF3II2Q1LX6Aazu4oeYGV1DsHDm6VPftSCm/GsXUqcvpUYlHGhNQfvcAEzM+t KHEErzvzy9AE7efI2veDZidjjq+fK6s2UJs7fEhnYmQiPFx9rvXEwel822roodlc/FcK DEv5SfZdo4Mf/qMs7Jb75ZFTHTDu0awILjq9sqTvXs+VIsFn7y/1XB/C+/lY4NwLFtHP cHAfa2a7eS26AcezybSCXTWBbxiGPri9iUr8Wx/IV+DiOD4YHSNiMvTZGqn4/3tFE8gU fEqZVpI1Dt83hXy63DNbfv4vosQWDr6RKn8ZmI1PKEqbMIgBEyzoH/HXIZQqJ3XqzuZq V9lQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PQeh1LIqbqFtSovgn5WZ7VLYBwfefd3KuHYAxcJ6bdE=; b=d37NS1a7DX+T7ECWzLLFl/doCOBlJQstJ7hU5OMhnHACZrYz7ZjU7C87t+Q9i31TZH ykO06xamtJBwa//QMVutDpMCKOA/mmfhDFPzYN/UiyLr7RA6ucc9NQU/hMz6KnTx0QKR r1hXr6Vr93mJRN1ogscu2gRC/q3F83MlecpoPRdMvG7EHuJgDHStMGcYxC4XNcnCVHAp /1i/qeFg+FzRfyZPvnErhREuzPOZr/S+tbaeryUV3WvtnIadixfdMT9Sj884/jpV2Ntx ic/jvgXieX6dJYvhkHm7xcYp8HSXzE/Nk/VzX64/R1ai8oizE199Er1g7if6a5ituD/m KskA== X-Gm-Message-State: AOAM531+b9T0Dde62tFTzmOEqKb6w/AbrvFK/z1ABVFomgMCi5rrhjuh Af9T5rh2JLX/aebFhDEmfJTz+CgE9wuROlcB4a/Aiw== X-Google-Smtp-Source: ABdhPJxo6xmNJWXyaaVPBEUy4anrM6xGk5zJ5S54bOFTPTbJYWg88+GG8ODe3guk693xmG8x/Zkzy+Ul3gB1uuDCJIA= X-Received: by 2002:a63:5401:: with SMTP id i1mr6112849pgb.356.1637702228750; Tue, 23 Nov 2021 13:17:08 -0800 (PST) MIME-Version: 1.0 References: <20211109083309.584081-1-hch@lst.de> <20211109083309.584081-17-hch@lst.de> In-Reply-To: <20211109083309.584081-17-hch@lst.de> From: Dan Williams Date: Tue, 23 Nov 2021 13:16:58 -0800 Message-ID: Subject: Re: [PATCH 16/29] fsdax: simplify the offset check in dax_iomap_zero To: Christoph Hellwig Cc: Mike Snitzer , Ira Weiny , device-mapper development , linux-xfs , Linux NVDIMM , linux-s390 , linux-fsdevel , linux-erofs@lists.ozlabs.org, linux-ext4 , virtualization@lists.linux-foundation.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Tue, Nov 9, 2021 at 12:34 AM Christoph Hellwig wrote: > > The file relative offset must have the same alignment as the storage > offset, so use that and get rid of the call to iomap_sector. Agree. Reviewed-by: Dan Williams