Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71446C4332F for ; Tue, 23 Nov 2021 21:48:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238823AbhKWVvx (ORCPT ); Tue, 23 Nov 2021 16:51:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52604 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239091AbhKWVvo (ORCPT ); Tue, 23 Nov 2021 16:51:44 -0500 Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C54AC061748 for ; Tue, 23 Nov 2021 13:48:34 -0800 (PST) Received: by mail-pj1-x1030.google.com with SMTP id o6-20020a17090a0a0600b001a64b9a11aeso499016pjo.3 for ; Tue, 23 Nov 2021 13:48:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TYkPf9vJ648gXjsCEnGEexU4+Ifkiqg1wwbcGn6CCJ4=; b=VQApAlcktwMcpaq5jFhkMxeNGyvexkKC3i6bBW7J48mF8DsF1/7CQAqKNzOE+eTccI MukZz7spVxbYqcrXVw8V1NPJ/pO4n52l7m+S0Ph4Ybr+mw2kgqAqtZa3pLex/+BZstf8 /wFsj02Qj6TChPn0/3voEI1RYYWUipBK72irmVx+QhYrnrndgBztGcQeijJ0cPmWiSB8 zysPKFzjgdDt9boZOOp48eyCMBg3PV9MBTwiNrvClt0hBzUO02OKjJgpyz/mrusiP8R+ CYs52zo3lmHwTSmYl1Jahz6zyoWzMdW1LqR6lyuLMEqjEjPScDcZZh/xx6IU/yB7SEwD h9EA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TYkPf9vJ648gXjsCEnGEexU4+Ifkiqg1wwbcGn6CCJ4=; b=LWkOF/RlS3JKWXf62Bu0am+gPfQWbpvhAoyDDd29Ii5QXoHuiGgFVQDR8wxQBjTuZX XCXKGJ9HNREYYh8/0/7NlfyoGdj8SUe5mM08/mJRhWmPHZ5NWDFPlF/3BYoarPA22BDZ CDlUoGcXG3Ct/SSlZx883jq8YJxkeweVvKg9bw+gpIBAgd5Fh9SbU4fjPBNng0eLXrxl R6T0+pchLkzJ+OLSHE509iJM1Qg6qbNCia+ik1/hgPPNRk8KxWmaSf7QKrBRDk/mn7rF zVKPG8yF2YjWA5yqpODujNoo8WxZJ7/nrqu++aD4vJXceWicisKe+rqOEaas/XQl/D6T q4iw== X-Gm-Message-State: AOAM5307xdPJmPEP0u3P8TH+H4Vak6k2EvVqH+gKKiAxI+hZglgIYRMq /8DeTjkdPFl1zpbBpyBgxnkq20ZHOtGSbNIsnrGa8w== X-Google-Smtp-Source: ABdhPJyT9foSDeohZagrJ9StTFco2dwZgw3K6Q2oNHo7YSNAudlmobBOmJCjxwVnaF6MiMXxVYrJ5EOKlp8j1MbCkKE= X-Received: by 2002:a17:90a:e7ca:: with SMTP id kb10mr7435174pjb.8.1637704113737; Tue, 23 Nov 2021 13:48:33 -0800 (PST) MIME-Version: 1.0 References: <20211109083309.584081-1-hch@lst.de> <20211109083309.584081-20-hch@lst.de> In-Reply-To: <20211109083309.584081-20-hch@lst.de> From: Dan Williams Date: Tue, 23 Nov 2021 13:48:23 -0800 Message-ID: Subject: Re: [PATCH 19/29] ext2: cleanup the dax handling in ext2_fill_super To: Christoph Hellwig Cc: Mike Snitzer , Ira Weiny , device-mapper development , linux-xfs , Linux NVDIMM , linux-s390 , linux-fsdevel , linux-erofs@lists.ozlabs.org, linux-ext4 , virtualization@lists.linux-foundation.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Tue, Nov 9, 2021 at 12:34 AM Christoph Hellwig wrote: > > Only call fs_dax_get_by_bdev once the sbi has been allocated and remove > the need for the dax_dev local variable. Looks good. Reviewed-by: Dan Williams