Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74294C4332F for ; Wed, 24 Nov 2021 02:49:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231624AbhKXCwf (ORCPT ); Tue, 23 Nov 2021 21:52:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34940 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234203AbhKXCw0 (ORCPT ); Tue, 23 Nov 2021 21:52:26 -0500 Received: from mail-pg1-x52d.google.com (mail-pg1-x52d.google.com [IPv6:2607:f8b0:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A82AC061746 for ; Tue, 23 Nov 2021 18:49:17 -0800 (PST) Received: by mail-pg1-x52d.google.com with SMTP id h63so767012pgc.12 for ; Tue, 23 Nov 2021 18:49:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=w9SdtjSRKyAYQmT41K4AZZGwYb4w19IPMcYn2fMN2dE=; b=ic6A7wlPP4NKkUtI3F1gI85ivlPVa2/lSDRF8Q7wubnSu6f7h04uQc/NmShkxWWq1R 5YVX5PyQS6icvNDeSu+Q5SAFIyD1yWrEohSPRHGAM0U80r/1UVrc1M5tkOzbuMom4O54 1FLUzZRSXGaQAUxBGkDtbRBlcgI/X1q34NCzbxL0/h1k+OT0m2DEdJxNf5uYBo+yQUWi tmtbKwN0VhChOm0hu6sUiBfGI5twjAA/MYoygg7APmhPoWaH/03oMqUw/a4XtP1nLkRy COKRo5xekU2xjc7aQKQeECLQQpxXtktld4XRoPYuhnzVfHtuR3OjCxP0rbhzS8FBgJxr bd0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=w9SdtjSRKyAYQmT41K4AZZGwYb4w19IPMcYn2fMN2dE=; b=oN5eoj58rGbo6gUjaqo3tKRiXkGWEvpJ94KP9IjnG25w3OlSXchtQlGi5P0RHhIEiq oePvJ2zh8/fqPYIVfgquDut2XN1C5fX7SVeHMxUvP0c84N4n8kSmOqapZE30sU/6W0R+ aXMzXHjsDK7mmEZjjhpGURUX4JYAiKnC+cDqyFIFCZvjsdTQ9RyUm+rUj0/jWRc8uZ9e wyC4LKVm2m6ZPEGBySHT87rL3fjGK6bla+g1ACyhVDQ7pZhemYD7vsq4k4NA0LZeSMU6 ADiSBqUn9tcidxgK6o4mA1mx5q0wYsSnaSEmWOQh8HWJybV0/YvlgHDb01P/Uk0/IAxy RJ5Q== X-Gm-Message-State: AOAM532uK55ED4BtCLCg7tzuv7C6UEmo1zzEL7PmJe+4+qzkkpmNq7TC MnExm+Gh2z/+jUJtjtk7uzdhoje5EnOWNYsapixCSg== X-Google-Smtp-Source: ABdhPJzS8LHGzaz1OBnNTW7y/EU5nRSgH9NtL2R6nqEjsoFplqiXZU89WIILPbZV7BRWoAlxpdKj2qQGIACFTFGS2MI= X-Received: by 2002:a05:6a00:140e:b0:444:b077:51ef with SMTP id l14-20020a056a00140e00b00444b07751efmr2420437pfu.61.1637722157095; Tue, 23 Nov 2021 18:49:17 -0800 (PST) MIME-Version: 1.0 References: <20211109083309.584081-1-hch@lst.de> <20211109083309.584081-24-hch@lst.de> In-Reply-To: <20211109083309.584081-24-hch@lst.de> From: Dan Williams Date: Tue, 23 Nov 2021 18:49:06 -0800 Message-ID: Subject: Re: [PATCH 23/29] xfs: use IOMAP_DAX to check for DAX mappings To: Christoph Hellwig Cc: Mike Snitzer , Ira Weiny , device-mapper development , linux-xfs , Linux NVDIMM , linux-s390 , linux-fsdevel , linux-erofs@lists.ozlabs.org, linux-ext4 , virtualization@lists.linux-foundation.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Tue, Nov 9, 2021 at 12:34 AM Christoph Hellwig wrote: > > Use the explicit DAX flag instead of checking the inode flag in the > iomap code. It's not immediately clear to me why this is a net benefit, are you anticipating inode-less operations? With reflink and multi-inode operations a single iomap flag seems insufficient, no?