Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A213AC433F5 for ; Wed, 24 Nov 2021 07:10:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240624AbhKXHNo (ORCPT ); Wed, 24 Nov 2021 02:13:44 -0500 Received: from verein.lst.de ([213.95.11.211]:35973 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231555AbhKXHNl (ORCPT ); Wed, 24 Nov 2021 02:13:41 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id 9250868AFE; Wed, 24 Nov 2021 08:10:28 +0100 (CET) Date: Wed, 24 Nov 2021 08:10:28 +0100 From: Christoph Hellwig To: Dan Williams Cc: Christoph Hellwig , Mike Snitzer , Ira Weiny , device-mapper development , linux-xfs , Linux NVDIMM , linux-s390 , linux-fsdevel , linux-erofs@lists.ozlabs.org, linux-ext4 , virtualization@lists.linux-foundation.org Subject: Re: [PATCH 22/29] iomap: add a IOMAP_DAX flag Message-ID: <20211124071028.GC7229@lst.de> References: <20211109083309.584081-1-hch@lst.de> <20211109083309.584081-23-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Tue, Nov 23, 2021 at 06:47:10PM -0800, Dan Williams wrote: > On Tue, Nov 9, 2021 at 12:34 AM Christoph Hellwig wrote: > > > > Add a flag so that the file system can easily detect DAX operations. > > Looks ok, but I would have preferred a quick note about the rationale > here before needing to read other patches to figure that out. The reason is to only apply the DAX partition offsets to actual DAX operations, and not to e.g. fiemap. I'll document that more clearly.