Date:   Mon, 29 Nov 2021 10:55:47 +0100
From:   Lukas Czerner <lczerner@redhat.com>
To:     Eryu Guan <guan@eryu.me>
Cc:     fstests@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] common/rc: set maximum label length for ext4
Message-ID: <20211129095547.wrrv6vbc2rcaeiwg@work>
References: <20211123101119.5112-1-lczerner@redhat.com>
 <YaOTRYYkEwlbnvPb@desktop>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YaOTRYYkEwlbnvPb@desktop>
Precedence: bulk

On Sun, Nov 28, 2021 at 10:33:41PM +0800, Eryu Guan wrote:
> On Tue, Nov 23, 2021 at 11:11:19AM +0100, Lukas Czerner wrote:
> > Set maximum label length for ext4 in _label_get_max() to be able to test
> > online file system label set/get ioctls.
> 
> Some background info included in commit log would be good, e.g. ext4
> didn't support get/set label ioctl but we're going to add that support
> in both kernel and e2fsprogs.
> 
> And I noticed the kernel patch is still in review, and has no comments
> so far. So I'd like to wait and make sure the new ioctl will be accepted
> first.

Sure, just note that the maximum label length for ext4 will be 16 with, or
without the ioctls. This patch just fixes what was missing in the first
place.

Thanks!
-Lukas

> 
> Thanks,
> Eryu
> 
> > 
> > Signed-off-by: Lukas Czerner <lczerner@redhat.com>
> > ---
> >  common/rc | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/common/rc b/common/rc
> > index 8e351f17..50d6d0bd 100644
> > --- a/common/rc
> > +++ b/common/rc
> > @@ -4545,6 +4545,9 @@ _label_get_max()
> >  	f2fs)
> >  		echo 255
> >  		;;
> > +	ext2|ext3|ext4)
> > +		echo 16
> > +		;;
> >  	*)
> >  		_notrun "$FSTYP does not define maximum label length"
> >  		;;
> > -- 
> > 2.31.1
>