Date:   Tue, 30 Nov 2021 12:40:06 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     harshadshirwadkar@gmail.com
Cc:     linux-ext4@vger.kernel.org
Subject: [bug report] ext4: fast commit recovery path
Message-ID: <20211130094006.GA29296@kili>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.10.1 (2018-07-13)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?oaSjPC0+2hKQ29crW8XpVEfEwMbzUUTBg7qWzU6JYrfMlQvo6fD1swyBunN/?=
 =?us-ascii?Q?bEQza+xi963C0bjAmkvO1bcNBhLxgnJlHr6akyEFLJHvNyj++9YcudAMYCAh?=
 =?us-ascii?Q?yl2930bmQw3e4UC8fkHLSj+YRLjZJJp4u6DhOzUhtxgPJzWmsqWgJ7MODbRr?=
 =?us-ascii?Q?pLDKV6RIlN5QJFvCWn9FRDm8SQQOWTkWUntoyWCJX4paWDoQ9FS79uvz0RiG?=
 =?us-ascii?Q?yLxCDMHPd5pAN61/GQYfoFxEU7AU5OIJnZgZeriyfBNohxGgzRPMGR2AVoDj?=
 =?us-ascii?Q?UaoRpkivYKn8cxBAnSNqvDivDI+CTiHm6e94PGQUxYlL7dK9v1dRlwwu9cjh?=
 =?us-ascii?Q?mLu/Me7Dm0gqFHdIRYLlhSYpmCzNdVtJYIa+U4YHSdKHtF9FXwTqsyGZF+5r?=
 =?us-ascii?Q?zqStdTAJRHUoyNuwfbq//cKUGCUEKGMrAuDu9trQRZLKCBnsVP+w6sU5xfaP?=
 =?us-ascii?Q?LQM/LijRAPp37XRrG5cIAaq8xyGmLJ6wIDguip9Uo166UIoavJ2bzm4k5oFx?=
 =?us-ascii?Q?I10jlyi47IhnjO1q4X7XnR6sOOkt5QuE2+UgkpxxHAqh85QTJcbydaWdQWu2?=
 =?us-ascii?Q?eVnCG4qV7maV0d5jj2v/3aSMlP8NZIwYbS8Gr/zFlZKnsNlLVI9PlEFbY1Sg?=
 =?us-ascii?Q?KQuDkG0cmoCkqDS2HRYyWaYPxQxvLcXREyv2kg9phFxXN6GmUZrcwYVH8xX4?=
 =?us-ascii?Q?NGs/4jr+c34p4+3gQ52mZxusX3uOd0bwswattvB5s/likRVaB4/rGgpUE4JY?=
 =?us-ascii?Q?sViyXPIz/3QLftXgy8ryf9hZSw4pCO/USxgQFrcnoies5hhBAScqSz+ODBiF?=
 =?us-ascii?Q?FieGh5bXrqi1WVRaYSJQtmyiw8i9t7ljIyN//bFF+2WehOVdP/dAJDSwHoFY?=
 =?us-ascii?Q?PTTVVVBzF16yxVcTgYop+vfYhrGl0fwtADSeeALtzvGkqeWTYci+VcaUHCjd?=
 =?us-ascii?Q?pl5zU5vR/ahNrCftf8GzyYDUqoW0EGHzN9wnL+8UApO62pbLgUDF8oiKBziT?=
 =?us-ascii?Q?5Ra+GiB59ppgA7rDGvtcUW0hI2S/iK5ursVNj35kIAaFR7FYIHjryNNnHbOO?=
 =?us-ascii?Q?jkyAowp0VHTDpVGnH5PVtEI8h2DhVZyftmGcqysiNqyv8QocAM8OFIoNOUuu?=
 =?us-ascii?Q?7sncy8TyMp7JXQz4EkYHycO/jzWBQHmaCpGOHmTOat6+9S+08uBBVRaegl67?=
 =?us-ascii?Q?+3PUKfIowdHB5cafyZITserKoiEAjTo4UNw6ynsBXN/CqCmmALsjrBy47zlU?=
 =?us-ascii?Q?0/vk3vDlrfRSWKeqegXNpv9SSpK/Gt1o99nijUxkalli9p9gGdkYrmrrxR58?=
 =?us-ascii?Q?Z+VwN2buhFpphA7xeb7DGSlCBf8rEOSHnfSTCTk2ggr3B1tTBTkILAn+p/tj?=
 =?us-ascii?Q?nBrQaI/vLtI3x4JzNKgF9GaWE/TWTC/gq3tjtC74gc4NQ8FgMAszkKQyJb4z?=
 =?us-ascii?Q?fbPrjdY1FT+p7TM0VCWhNtaRRxa9LbE49WLko8U2+JtMtPgFV/kAVwXsAA5y?=
 =?us-ascii?Q?pq6X1N3AKA7gSXFpqcyTW+L/p5sHDzbfxKw8A3BoeYRdzJ6UwKHIFHCeiSdb?=
 =?us-ascii?Q?IusBQFaJE/ZaD0NEOYiwilu8V7YLsxtogQT2CIPbjJgaAFD0cyPCLKm1mbDG?=
 =?us-ascii?Q?b7w5hDfjr8gC3uD0o2MJ73lF1SH7e5ixk6TW/SZmHeB3hM4rfOlNHhpzt398?=
 =?us-ascii?Q?PTvUiggzKDa91ezR6FiKygrXaS0=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ec6145b5-0370-4911-a803-08d9b3e56b1c
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2021 09:40:17.8716
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bWPJ3s6GGEcj4QAaHb/l5M7R27+F1QBusmmhoiQMqf9Ah2rdo2LmRt0uK5uh+17fPW+mz6PYhFUyWskflygjg1yERLaWgu4Erknu5jgrHYQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR10MB5555
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10183 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0 mlxscore=0
 suspectscore=0 mlxlogscore=747 spamscore=0 phishscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2111300054
X-Proofpoint-GUID: ehtiIGqrYfJlMQlW6UFozG51nH41ZT3D
X-Proofpoint-ORIG-GUID: ehtiIGqrYfJlMQlW6UFozG51nH41ZT3D
Precedence: bulk
List-ID: <linux-ext4.vger.kernel.org>
X-Mailing-List: linux-ext4@vger.kernel.org

Hello Harshad Shirwadkar,

The patch 8016e29f4362: "ext4: fast commit recovery path" from Oct
15, 2020, leads to the following Smatch static checker warnings:

	fs/ext4/inode.c:4533 __ext4_get_inode_loc_noinmem()
	error: uninitialized symbol 'err_blk'.

	fs/ext4/inode.c:4548 ext4_get_inode_loc()
	error: uninitialized symbol 'err_blk'.

fs/ext4/inode.c
    4523 static int __ext4_get_inode_loc_noinmem(struct inode *inode,
    4524                                         struct ext4_iloc *iloc)
    4525 {
    4526         ext4_fsblk_t err_blk;
    4527         int ret;
    4528 
    4529         ret = __ext4_get_inode_loc(inode->i_sb, inode->i_ino, NULL, iloc,
    4530                                         &err_blk);
    4531 
    4532         if (ret == -EIO)
--> 4533                 ext4_error_inode_block(inode, err_blk, EIO,

Only the last return -EIO sets err_blk.  The first return -EIO leaves it
uninitialized.

    4534                                         "unable to read itable block");
    4535 
    4536         return ret;
    4537 }

regards,
dan carpenter