Date:   Tue, 7 Dec 2021 15:31:39 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Alex Sierra <alex.sierra@amd.com>
Cc:     akpm@linux-foundation.org, Felix.Kuehling@amd.com,
        linux-mm@kvack.org, rcampbell@nvidia.com,
        linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org,
        amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        hch@lst.de, jglisse@redhat.com, apopple@nvidia.com,
        willy@infradead.org
Subject: Re: [PATCH v2 11/11] tools: add hmm gup test for long term pinned
 device pages
Message-ID: <20211207193139.GK6385@nvidia.com>
References: <20211206185251.20646-1-alex.sierra@amd.com>
 <20211206185251.20646-12-alex.sierra@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211206185251.20646-12-alex.sierra@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?2/x9azX4DEWJcXerCpkxkNb+KFqEVcmnr8qQ2MqrhHSZF7kRpeCpK/67zjE3?=
 =?us-ascii?Q?uSvGkaYmMtULMiO1LuYb1ABTggAW9bilUid5XPxm6zIh1m1lU0s9B1gFfYl1?=
 =?us-ascii?Q?owsX2xV3T3mbDGmTRtsFfohi2Fm5usT9ycvjnoOVjd1yggDLuM03zWrsh+24?=
 =?us-ascii?Q?+vzJHfOQ2tmc3348B0Qb9jf+YAxm73nEg5a8bN0v+39PIMtn5l8fXCi8w37E?=
 =?us-ascii?Q?Bm6Q4fhql+pzwfh03YFpCC0goE86pcbDuX2pkpez6V8djoUHEFAHCpmovKss?=
 =?us-ascii?Q?I4fqJ0Rk1IKL423HeLeGfuB9Eu6dH789X/IZkOYKm57WW9+SHUhrQLnKtIpK?=
 =?us-ascii?Q?p4RcjiOo89B+S4OGMfesg0VAEnqVzFw0w+zG55a0ueBDUF2ahk3Ch5Z7ld1C?=
 =?us-ascii?Q?s+uk+cGUCEGnw/+9mFPgELrRY52jFoB2qDoOevA+KhyxZhf4oZBfyRZ1KYxy?=
 =?us-ascii?Q?t44nWtGL0Fd28GUeszzA/DUEhBHBXjYEWxeYkygcuZWENlO1bK60EuXFonRk?=
 =?us-ascii?Q?VCNF1foV4Qxrw8/XWnk2bRYGbbXiKLDZH88qtFGS1dU9tQVJzwkduLaH52i8?=
 =?us-ascii?Q?yt+OcCQC3WEErKM0nDkWm7+MtV9GWjSlTviN4/hC+V/xtr3+r2j8jNq1ein8?=
 =?us-ascii?Q?Sf3v0BLD3oo3j4Q+SAnUUxtGilLnDLhwpy/cYRsLGQx+lPH5vZMKLIxe5Ok3?=
 =?us-ascii?Q?vBPkT85DOtRXV736w4sEHZDjz2zu7LIubh9/unOAI3X4E12iRYXKHB+DM1e3?=
 =?us-ascii?Q?SPDjP3bEi9KONXiOQA1pYVFS3gTDxQ90AFxAVCZvU4T3IIGVWfPRxDjcphuu?=
 =?us-ascii?Q?JfynY8TdYN+rEI7yNbyhxy7TbMiaSdLVS4dzRBoIPeN5cEZmTnhubyrqTThu?=
 =?us-ascii?Q?HB65eIRpZyJouhyWgtzZyhaDbpsxd5TfdVPEcWeysJmHtdgXVv8wLww44P3A?=
 =?us-ascii?Q?ITfcNyGoMZ23bxlWp645QXzU9xEAArF8L/GJFXWPt1VITo3x8koJbqATTR2Y?=
 =?us-ascii?Q?DBeXu2/Qiqg1K/ymuZaJs8SaGcNxkixLClhIfoScwc41C7q94p6ov/7JoCF+?=
 =?us-ascii?Q?kdQ9zJcI8Nh77/Om756cLkI+zFd5gxnThGJX3Ck+W8fkezXLMDxV5rwRePe5?=
 =?us-ascii?Q?4BHLG0I8N4Ab52kQGzy98Ns1RifkwydaEn9kgJua3Iumz+3FNVJtijHEqcoA?=
 =?us-ascii?Q?xuTNw5Kg25fWzl2M2BUKhbcjyUOODXQL5pYNClYl5KUHll1dvgOwyCCcCcL/?=
 =?us-ascii?Q?f3/3U6zW7/wSdhRU1ZEqTHmGlvDdOv8jef5oP1HuXmDdcx3d2vgGROwLnIzJ?=
 =?us-ascii?Q?xNxhGUdOwqYffiHc7o6sdt74AtXmOyNHEMOdQXTraQv7nabAoD9t+YCk7tAB?=
 =?us-ascii?Q?nuBFxQVrAYGUSQpzSjRUZjFKrlZy4Mo+/19DqT4uvY1O4kX5MDaBl5NPb+zv?=
 =?us-ascii?Q?B3RV4lM8JqinGOBF9Sz1OHu8PsI5vcX9lKkzaV70D4BK5AQRIxvFAD2JmgCk?=
 =?us-ascii?Q?/M1DiFok3xjXmsCzQlw5Rz3QLyMBYH44UtnMdJtEOHfPq6wgcOTfoxAGP17K?=
 =?us-ascii?Q?aESjSix8Qbk8vLrwjAI=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 78cb335a-e3b6-4c94-93ae-08d9b9b831fd
X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB5506.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2021 19:31:41.5177
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eyXyvdjGF5TmUFTTisORxh9JRuBNm9JPwZxU/z4/FzBXLj9Q7mP+lT8Lywqu1Nc1
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5361
Precedence: bulk
List-ID: <linux-ext4.vger.kernel.org>
X-Mailing-List: linux-ext4@vger.kernel.org

On Mon, Dec 06, 2021 at 12:52:51PM -0600, Alex Sierra wrote:
> The intention is to test device coherent type pages that have been
> called through get user pages with PIN_LONGTERM flag set.
> 
> Signed-off-by: Alex Sierra <alex.sierra@amd.com>
>  tools/testing/selftests/vm/Makefile    |  2 +-
>  tools/testing/selftests/vm/hmm-tests.c | 81 ++++++++++++++++++++++++++
>  2 files changed, 82 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/vm/Makefile b/tools/testing/selftests/vm/Makefile
> index d9605bd10f2d..527a7bfd80bd 100644
> +++ b/tools/testing/selftests/vm/Makefile
> @@ -141,7 +141,7 @@ $(OUTPUT)/mlock-random-test $(OUTPUT)/memfd_secret: LDLIBS += -lcap
>  
>  $(OUTPUT)/gup_test: ../../../../mm/gup_test.h
>  
> -$(OUTPUT)/hmm-tests: local_config.h
> +$(OUTPUT)/hmm-tests: local_config.h ../../../../mm/gup_test.h
>  
>  # HMM_EXTRA_LIBS may get set in local_config.mk, or it may be left empty.
>  $(OUTPUT)/hmm-tests: LDLIBS += $(HMM_EXTRA_LIBS)
> diff --git a/tools/testing/selftests/vm/hmm-tests.c b/tools/testing/selftests/vm/hmm-tests.c
> index 8eb81dfba4b3..9a0b7e44a674 100644
> +++ b/tools/testing/selftests/vm/hmm-tests.c
> @@ -36,6 +36,7 @@
>   * in the usual include/uapi/... directory.
>   */
>  #include "../../../../lib/test_hmm_uapi.h"
> +#include "../../../../mm/gup_test.h"
>  
>  struct hmm_buffer {
>  	void		*ptr;
> @@ -60,6 +61,8 @@ enum {
>  #define NTIMES		10
>  
>  #define ALIGN(x, a) (((x) + (a - 1)) & (~((a) - 1)))
> +/* Just the flags we need, copied from mm.h: */
> +#define FOLL_WRITE	0x01	/* check pte is writable */

This is so fragile, you should have a dedicated flag here for asking
for this of PIN_LONGTERM_BENCHMARK

Jason