From:   Andreas Dilger <adilger@dilger.ca>
Message-Id: <F12B316D-D695-4B38-ABEA-D5F558696E9A@dilger.ca>
Content-Type: multipart/signed;
 boundary="Apple-Mail=_C2822BFF-7698-448F-9046-0070E99BBA67";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: [PATCH] ext4: compare inode's i_projid with EXT4_DEF_PROJID
 rather than check EXT4_INODE_PROJINHERIT flag
Date:   Thu, 9 Dec 2021 15:53:55 -0700
In-Reply-To: <Ya+3L3gBFCeWZki7@mit.edu>
Cc:     Roman Anufriev <dotdot@yandex-team.ru>,
        linux-ext4 <linux-ext4@vger.kernel.org>, Jan Kara <jack@suse.cz>,
        Wang Shilong <wangshilong1991@gmail.com>,
        Dmitry Monakhov <dmtrmonakhov@yandex-team.ru>,
        "Darrick J. Wong" <darrick.wong@oracle.com>
To:     "Theodore Y. Ts'o" <tytso@MIT.EDU>
References: <1638883122-8953-1-git-send-email-dotdot@yandex-team.ru>
 <alpine.OSX.2.23.453.2112071702150.70498@dotdot-osx>
 <Ya+3L3gBFCeWZki7@mit.edu>
Precedence: bulk


--Apple-Mail=_C2822BFF-7698-448F-9046-0070E99BBA67
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
	charset=us-ascii

On Dec 7, 2021, at 12:34 PM, Theodore Y. Ts'o <tytso@MIT.EDU> wrote:
> 
> On Tue, Dec 07, 2021 at 05:05:19PM +0300, Roman Anufriev wrote:
>>> Commit 7ddf79a10395 ("ext4: only set project inherit bit for directory")
>>> removes EXT4_INODE_PROJINHERIT flag from regular files. This makes
>>> ext4_statfs() output incorrect (function does not apply quota limits
>>> on used/available space, etc) when called on dentry of regular file
>>> with project quota enabled.
> 
> Under what circumstance is userspace trying to call statfs on a file
> descriptor?

Who knows what users do?  Calling statfs() on a regular file works fine
(returns stats for the filesystem), so I don't see why it wouldn't be
consistent when calling statfs() on a file with projid set?

Darrick, how does XFS handle this case?  I think it makes sense to be
consistent with that implementation, since that was the main reason to
remove PROJINHERIT from regular files in the first place.

> Removing the test for EXT4_INODE_PROJINHERIT will cause
> incorrect/misleading results being returned in the case where we have
> a directory where a directory hierarchy is using project id's, but
> which is *not* using PROJINHERIT.

One alternative would be to check the PROJINHERIT status of the parent
directory after calling statfs() on the regular file?  That should
keep the semantics for PROJINHERIT the same, but avoid inconsistent
results if called on a regular file:

#ifdef CONFIG_QUOTA
-	if (ext4_test_inode_flag(dentry->d_inode, EXT4_INODE_PROJINHERIT) &&
+	if (ext4_test_inode_flag(S_ISDIR(dentry->d_inode) ? dentry->d_inode :
+			   dentry->d_parent->d_inode, EXT4_INODE_PROJINHERIT) &&
	    sb_has_quota_limits_enabled(sb, PRJQUOTA))
		ext4_statfs_project(sb, EXT4_I(dentry->d_inode)->i_projid, buf);
#endif

Roman, does that work for you?

Cheers, Andreas


--Apple-Mail=_C2822BFF-7698-448F-9046-0070E99BBA67
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - http://gpgtools.org

iQIzBAEBCAAdFiEEDb73u6ZejP5ZMprvcqXauRfMH+AFAmGyiQMACgkQcqXauRfM
H+CCSw//c5KRr2+fNWWTam4EL3ayPROZZIzSu4GS3zoR1Ox8nWQLMuYuKm8ScxbO
INKFQgdWuJTy6+751KO8vWSU1F8kIRJYOM8cYUbyTp5xH2r/7Rnw32oXvXEDu993
ahe91eje2AtenQNugfR11YxXtTxBNyCxde97DfvFStyoLpGJOekPKcNsiHfda2mc
e2sYQKA0z5bF959O0fnOLDAYjP5Vw8AM6hS4LZaFho0V1D4u6xeJdf8OO6GN/z/3
TLRxicnax9FxdejBoNM1YsVXnXg7R3piL5sd+/X9EeRxNGUvyaxvWPd9qyGawMhh
PcRkEsQ7dsvJfwxsxDosyNLL9fg/d4kDK5OyHRWsfD1uP0NcIhWqrHQKJCvSgsG7
NW/xf/38/Ruu4JXWdaaGO7CbLt43jizTdWF6N9A+xzs1xxtQr/TgWrvzh/ODaC3M
rAwLUH44XxUSMHq9MrCdogwmN45u1QGInlOm0A7XKARHPkWiqcpoZITSkmfkler9
zL+q5OdCm1Spn/yyNtkVxuyCYJfXEyfNiWJkLhdWe9dhslSSRak8L0dYm318Rmdf
jOD1vVz4AzvGZImiLLsoxMI2fgWq7H3fwT1vMH5rnOb3kFEVry8huNbH4NJsq1zT
GpBAusFyPXZVY+tkldMFEizvBk5P1rXf0m+DOawdk6dUJLYp27E=
=zXs8
-----END PGP SIGNATURE-----

--Apple-Mail=_C2822BFF-7698-448F-9046-0070E99BBA67--