Message-ID: <b5817114-8122-cf0e-ca8e-b5d1c9f43bc2@gmail.com>
Date:   Fri, 17 Dec 2021 16:11:32 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Content-Language: en-US
To:     Lukas Czerner <lczerner@redhat.com>, linux-ext4@vger.kernel.org,
        linux-fsdevel@vger.kernel.org
From:   Heiner Kallweit <hkallweit1@gmail.com>
Subject: Problem with data=ordered ext4 mount option in linux-next
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On linux-next systemd-remount-fs complains about an invalid mount option
here, resulting in a r/o root fs. After playing with the mount options
it turned out that data=ordered causes the problem. linux-next from Dec
1st was ok, so it seems to be related to the new mount API patches.

At a first glance I saw no obvious problem, the following looks good.
Maybe you have an idea where to look ..

static const struct constant_table ext4_param_data[] = {
	{"journal",	EXT4_MOUNT_JOURNAL_DATA},
	{"ordered",	EXT4_MOUNT_ORDERED_DATA},
	{"writeback",	EXT4_MOUNT_WRITEBACK_DATA},
	{}
};

	fsparam_enum	("data",		Opt_data, ext4_param_data),