MIME-Version: 1.0
References: <20211223032337.5198-1-yinxin.x@bytedance.com>
In-Reply-To: <20211223032337.5198-1-yinxin.x@bytedance.com>
From:   harshad shirwadkar <harshadshirwadkar@gmail.com>
Date:   Thu, 23 Dec 2021 12:13:22 -0800
Message-ID: <CAD+ocbxLHJ2KK44gT0u7zei--UBJ1CRRKyra8Hhx1CvtCcOpQA@mail.gmail.com>
Subject: Re: [PATCH 0/2] ext4: fast commit crash consistency issues
To:     Xin Yin <yinxin.x@bytedance.com>
Cc:     "Theodore Y. Ts'o" <tytso@mit.edu>,
        Andreas Dilger <adilger.kernel@dilger.ca>,
        Ext4 Developers List <linux-ext4@vger.kernel.org>,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Thanks for the patches, these are good finds.

Reviewed-by: Harshad Shirwadkar <harshadshirwadkar@gmail.com>

On Wed, Dec 22, 2021 at 7:24 PM Xin Yin <yinxin.x@bytedance.com> wrote:
>
> This patch sets fix 2 crash-consistency issues of fast commit.
> First patch change to use ext4_ext_remove_space instead of
> ext4_punch_hole during replay delete range procedure. This
> avoid replay procedure being affeced by incorrect inode->i_size.
> Second patch correct the trank range logic for ftruncte.
>
> After testing this patch sets with xfstests-bld, in the "log" and
> "quick" group with config "fast_commit" is selected. No regressions
> was found.
>
> Signed-off-by: Xin Yin <yinxin.x@bytedance.com>
>
> Xin Yin (2):
>   ext4: use ext4_ext_remove_space() for fast commit replay delete range
>   ext4: fast commit may miss tracking unwritten range during ftruncate
>
>  fs/ext4/fast_commit.c | 13 ++++++++-----
>  fs/ext4/inode.c       |  3 +--
>  2 files changed, 9 insertions(+), 7 deletions(-)
>
> --
> 2.20.1
>