Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C247C433EF for ; Tue, 4 Jan 2022 14:23:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234134AbiADOXz (ORCPT ); Tue, 4 Jan 2022 09:23:55 -0500 Received: from szxga03-in.huawei.com ([45.249.212.189]:31139 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231665AbiADOXz (ORCPT ); Tue, 4 Jan 2022 09:23:55 -0500 Received: from dggpeml500023.china.huawei.com (unknown [172.30.72.56]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4JSvtQ6wVkz8vnq; Tue, 4 Jan 2022 22:21:18 +0800 (CST) Received: from dggpeml100016.china.huawei.com (7.185.36.216) by dggpeml500023.china.huawei.com (7.185.36.114) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 4 Jan 2022 22:23:53 +0800 Received: from [10.174.176.102] (10.174.176.102) by dggpeml100016.china.huawei.com (7.185.36.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 4 Jan 2022 22:23:52 +0800 Message-ID: <9dcadf7a-b12a-c977-2de2-222e20f0cebe@huawei.com> Date: Tue, 4 Jan 2022 22:23:52 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 To: Theodore Ts'o CC: , , From: zhanchengbin Subject: [PATCH v2] resize2fs: resize2fs disk hardlinks will be error Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.176.102] X-ClientProxiedBy: dggpeml500009.china.huawei.com (7.185.36.209) To dggpeml100016.china.huawei.com (7.185.36.216) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Resize2fs disk hardlinks which mounting after the same name as tmpfs filesystem it will be error. The items in /proc/mounts are traversed, when you get to tmpfs,file!=mnt->mnt_fsname, therefore, the stat(mnt->mnt_fsname, &st_buf) branch is used, however, the values of file_rdev and st_buf.st_rdev are the same. As a result, the system mistakenly considers that disk is mounted to /root/tmp. As a result , resize2fs fails. example: dev_name="/dev/sdc" (ps: a disk in you self) mkdir /root/tmp mkdir /root/mnt mkfs.ext4 -F -b 1024 -E "resize=10000000" "${dev_name}" 32768 mount -t tmpfs "${dev_name}" /root/tmp mount "${dev_name}" /root/mnt ln "${dev_name}" "${dev_name}"-ln resize2fs "${dev_name}"-ln 6G Signed-off-by: zhanchengbin Signed-off-by: Zhiqiang Liu --- lib/ext2fs/ismounted.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/lib/ext2fs/ismounted.c b/lib/ext2fs/ismounted.c index aee7d726..463a82a6 100644 --- a/lib/ext2fs/ismounted.c +++ b/lib/ext2fs/ismounted.c @@ -98,6 +98,7 @@ static errcode_t check_mntent_file(const char *mtab_file, const char *file, { struct mntent *mnt; struct stat st_buf; + struct stat dir_st_buf; errcode_t retval = 0; dev_t file_dev=0, file_rdev=0; ino_t file_ino=0; @@ -144,8 +145,12 @@ static errcode_t check_mntent_file(const char *mtab_file, const char *file, if (stat(mnt->mnt_fsname, &st_buf) == 0) { if (ext2fsP_is_disk_device(st_buf.st_mode)) { #ifndef __GNU__ - if (file_rdev && (file_rdev == st_buf.st_rdev)) - break; + if (file_rdev && (file_rdev == st_buf.st_rdev)) { + if (stat(mnt->mnt_dir, &dir_st_buf) != 0) + continue; + if (file_rdev == dir_st_buf.st_dev) + break; + } if (check_loop_mounted(mnt->mnt_fsname, st_buf.st_rdev, file_dev, file_ino) == 1) -- 2.27.0