From:   "Theodore Ts'o" <tytso@mit.edu>
To:     Jan Kara <jack@suse.cz>
Cc:     "Theodore Ts'o" <tytso@mit.edu>,
        Lukas Czerner <lczerner@redhat.com>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: Avoid trim error on fs with small groups
Date:   Tue,  4 Jan 2022 22:14:36 -0500
Message-Id: <164135246476.257673.18374747677460683644.b4-ty@mit.edu>
In-Reply-To: <20211112152202.26614-1-jack@suse.cz>
References: <20211112152202.26614-1-jack@suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Fri, 12 Nov 2021 16:22:02 +0100, Jan Kara wrote:
> A user reported FITRIM ioctl failing for him on ext4 on some devices
> without apparent reason.  After some debugging we've found out that
> these devices (being LVM volumes) report rather large discard
> granularity of 42MB and the filesystem had 1k blocksize and thus group
> size of 8MB. Because ext4 FITRIM implementation puts discard
> granularity into minlen, ext4_trim_fs() declared the trim request as
> invalid. However just silently doing nothing seems to be a more
> appropriate reaction to such combination of parameters since user did
> not specify anything wrong.
> 
> [...]

Applied, thanks!

[1/1] ext4: Avoid trim error on fs with small groups
      commit: a4934e25c01ed056dc4af8bef086616e3b083a14

Best regards,
-- 
Theodore Ts'o <tytso@mit.edu>