Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C3E0C433FE for ; Wed, 5 Jan 2022 23:39:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245453AbiAEXjy (ORCPT ); Wed, 5 Jan 2022 18:39:54 -0500 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:33803 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S245446AbiAEXjw (ORCPT ); Wed, 5 Jan 2022 18:39:52 -0500 Received: from cwcc.thunk.org (pool-108-7-220-252.bstnma.fios.verizon.net [108.7.220.252]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 205NdlW2017581 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 5 Jan 2022 18:39:47 -0500 Received: by cwcc.thunk.org (Postfix, from userid 15806) id EABF615C00E1; Wed, 5 Jan 2022 18:39:46 -0500 (EST) From: "Theodore Ts'o" To: cgel.zte@gmail.com Cc: "Theodore Ts'o" , Zeal Robot , luo penghao , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, Andreas Dilger Subject: Re: [PATCH v2] ext4: Remove redundant statement Date: Wed, 5 Jan 2022 18:39:43 -0500 Message-Id: <164142575580.441490.1970718885277055650.b4-ty@mit.edu> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20211104063406.2747-1-luo.penghao@zte.com> References: <20211104063406.2747-1-luo.penghao@zte.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu, 4 Nov 2021 06:34:06 +0000, cgel.zte@gmail.com wrote: > From: luo penghao > > The local variable assignment at the end of the function is meaningless. > > The clang_analyzer complains as follows: > > fs/ext4/fast_commit.c:779:2 warning: > > [...] Applied, thanks! [1/1] ext4: remove redundant statement commit: 756e311f7f200754096117caf9ef9d656edb280f Best regards, -- Theodore Ts'o