Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24023C433FE for ; Thu, 6 Jan 2022 04:42:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233688AbiAFEmA (ORCPT ); Wed, 5 Jan 2022 23:42:00 -0500 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:39509 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229729AbiAFEl7 (ORCPT ); Wed, 5 Jan 2022 23:41:59 -0500 Received: from cwcc.thunk.org (pool-108-7-220-252.bstnma.fios.verizon.net [108.7.220.252]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 2064ftFE003548 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 5 Jan 2022 23:41:55 -0500 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 0A6A415C00E3; Wed, 5 Jan 2022 23:41:55 -0500 (EST) From: "Theodore Ts'o" To: cgel.zte@gmail.com Cc: "Theodore Ts'o" , Andreas Dilger , linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org, luo penghao , Zeal Robot Subject: Re: [PATCH linux-next] ext4: Remove redundant o_start statements Date: Wed, 5 Jan 2022 23:41:50 -0500 Message-Id: <164144408579.468293.9021095894366334797.b4-ty@mit.edu> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20211208075157.404535-1-luo.penghao@zte.com.cn> References: <20211208075157.404535-1-luo.penghao@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, 8 Dec 2021 07:51:57 +0000, cgel.zte@gmail.com wrote: > From: luo penghao > > The if will goto out of the loop, and until the end of the > function execution, o_start will not be used again. > > The clang_analyzer complains as follows: > > [...] Applied, thanks! [1/1] ext4: Remove redundant o_start statements commit: b687e7ba0849122bf862639b98256a0b984a940a Best regards, -- Theodore Ts'o