Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <008b5ff4-dd53-d652-46dd-5ce771c69a0a@oracle.com>
Date:   Thu, 20 Jan 2022 12:36:21 +0000
Subject: Re: [PATCH v3 03/10] mm/gup: fail get_user_pages for LONGTERM dev
 coherent type
Content-Language: en-US
To:     Alex Sierra <alex.sierra@amd.com>
Cc:     amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        hch@lst.de, jglisse@redhat.com, apopple@nvidia.com,
        willy@infradead.org, akpm@linux-foundation.org,
        Felix.Kuehling@amd.com, linux-mm@kvack.org, rcampbell@nvidia.com,
        linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org,
        jgg@nvidia.com
References: <20220110223201.31024-1-alex.sierra@amd.com>
 <20220110223201.31024-4-alex.sierra@amd.com>
From:   Joao Martins <joao.m.martins@oracle.com>
In-Reply-To: <20220110223201.31024-4-alex.sierra@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y0E3aC9mZ2l5WUE5TnNBTkQ5VHFFc1E2VEgwdHp4YTlyRFJRa2IrUGdFYkFQ?=
 =?utf-8?B?RnhLaTkvQjljRFVrelcwU0cyeUc3UVJlUnlPZmxZWXpHc09XQUZyZElGWWpa?=
 =?utf-8?B?alNjbEZCaXRpamFJMll1WmhKUURDc1krb09DMWpGMlFZN280RjdvTXVpODVX?=
 =?utf-8?B?VVI5dTlRSEtWSmdKTlA3bnJLYWxyRi9XWXZVRTVWbjNtS3Vvbm9ub3dLeXdl?=
 =?utf-8?B?bk1xTWc5aStQamJ4NnNQOEhtQkRmZUVIa2ExY0xZZFBsU0lVUGVLOFRITWdv?=
 =?utf-8?B?YVgwRGxqNUtwVDNjQ1ZlR0pZM2VKMVFOR0k0YmRJekxFMEdUcnA1c3NtdVRq?=
 =?utf-8?B?c2RJTFhwdE9UaERweTBlK2pjVVovcCtCVUtaNUtGZUJtRjBoc0thdEVSQVZU?=
 =?utf-8?B?MnlPVGl0bThlZkVLdEVEcVJlUGpwSVJ4V2dWRTZCNDkxSjF6K21GZTJiZFdB?=
 =?utf-8?B?R2kzTVpjaUZ6bDBPTWtMNGptZXJMZTZJL3VNRW9QcVpkVG1FdHNaRzhabFZs?=
 =?utf-8?B?ako1Y2hVWmxvUHpzZUdkMTdmVjY1L1RWTmp3OXp4K3JTMGFEMmFHVW10K01G?=
 =?utf-8?B?MjlVQkRqM25VS3ZXMmoxV2k1NXdqbUJuS0RmbDYzNVZSZjE3Rm1YVjdhbm9I?=
 =?utf-8?B?azZiQVkxUjZjdlBWaGRlcjAvRVhaalJnOTVLa3liTjYrSUE3ZnQ1eEFNeS85?=
 =?utf-8?B?OGFKSHkvQXN6YVE1djJ3NzVtakV3Qm1YWXN3bzNuTkREVmk3UkF6cGVkUENV?=
 =?utf-8?B?ZGlDZjNTVnM0dTVQaGhidzJ1Z1Yzb2E4UFUxSnFyT2pDNzJrajNTWCtBWkVh?=
 =?utf-8?B?VzlZOEV4WXhCMjVqNit5dThPOUxYUUFad1F6UVcxVnMvT2FFRUFzbjR4UHU4?=
 =?utf-8?B?bzhjY0E2SHgza2JzTnVxVzVpZ0pycUlXdVJpR1VSM1plV1FCanJOWm9NRlla?=
 =?utf-8?B?VDk2QkFBYzZiVWZLaGw3d1VqWHl2UCtweU5UcnkrQ3ZSTmNMcmJ1RkJPNjFW?=
 =?utf-8?B?OFY1NlVMc1g3Y1l5ZFRwL0ZjbWljak1CL1QvWWRuZXJmekJ4SWJQQnVRZzRH?=
 =?utf-8?B?VkovUlRCNGFUZkdkM3NFNzBIRHZhU3oyWElZYnd1RmJMaG52azNEV2o0cTNl?=
 =?utf-8?B?d3cxZTZObU5LSEVEeldiWjJZVWpkUzNLL1diV1d1cHVBM29xWm5VMWhHZnJl?=
 =?utf-8?B?bkRaYmNYbXl5L0lONVY0Q2tNUGRWaXZyQ0FYMnBMd1RhME1aSUU5SG9YTGV0?=
 =?utf-8?B?Y2h5OUl5a0hLZlJweUxhSEFCbnBBWEo1ZGc0ZlBHUTFCdE5kbU1PbWJPdmp2?=
 =?utf-8?B?TjRoeXhyZFpMMlNiMGJLckZ3NzNHclBSSlM5bndHZzM4MVM1ZkVua2IrYUE4?=
 =?utf-8?B?VXNMMjlXTzJuT1dsREV0aG1odGVIQ3JSdXI1L213clNaYitMSHdZYnpzVmlV?=
 =?utf-8?B?NUtGcDAvTGFwNXd5SVNkdm1HSDJ4R01HcktEMUVIcStON042TDN5OUU1RlVU?=
 =?utf-8?B?dkNkeEs5S0JoRzk1WVQzOGJYOFRiVHhtU1hseXFwSUhDN1daM21MWmJpYmtD?=
 =?utf-8?B?dzZuNUNiQkNjc2pLWS92RHFuU0t3clR5SHlPWFkvMWVZSFEzUDlvTWtWSXBE?=
 =?utf-8?B?U09oNDdlUTliL1hTamZHWnF5ZnhBYnJxVHJoMFZOMzhVK256ZW9KaXQ3SGZv?=
 =?utf-8?B?cHI4cTd6ejJCMlJEeUNoYURNVEFPaGRFWUEwVUR1NkpXSjB5SUc0ZHovT2hN?=
 =?utf-8?B?OEVPYW5naVNjeHI5VktldG5XSGZxblBKdVBPay9ab2g0ejVBZ0NqQnNxRkZw?=
 =?utf-8?B?ekVUNlhueGcrWUswSTQxQ1R3YlhKb1R2VVVTb2dpRXR2ck9tRzB6ZXBISVhr?=
 =?utf-8?B?RS9HdlVnRDdyRWdvTVVUdmJyS2gwWEZxRUJpekFWbm9ZOWdvcE5lY2QrYXBJ?=
 =?utf-8?B?ZVNlVmFLSnA2YjZsallMY3BtanFZbVpGOUdObWZaRlBWQ2ZXdWxNRkVEWDZz?=
 =?utf-8?B?amxDT2FwTEZOQ1RjcS9xcFBNMWplSmxLcGQ5eTNqcVpwTGZBbzRNcEQrZ1Mx?=
 =?utf-8?B?RGhqQ0hrRzdGa2NGVFJGcmc1SXF4bTZpTkJhY3UrN0V0QWVyV3Z5a1Rla09Q?=
 =?utf-8?B?K3Q4VlhEc2hjRTdLdnFMSlZYNFFEcXhRemQ3aEVlZER0Mmp0RktVanMzWThM?=
 =?utf-8?B?eFppZ2RvV05wK09ad2FkbEFla0NYeDdoU1ZSdjdPV2FQVDd0YWdtWUROTk1B?=
 =?utf-8?B?YlMrOVplemc5NVNMNTRoVWV6cjh3PT0=?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c79a1f61-50d7-465f-a7e2-08d9dc117b30
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB4835.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jan 2022 12:36:29.1646
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IqQK43xXyUQX8Iqs3ZJsRNZg10A+DVOksBzE/gAdWtuxm/ZhMaZGHJngWzMWEfUcavY+STLchI3fqQoDheOC7kisFHEyKiXhtzDmE4QV4WM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB2875
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10232 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 spamscore=0 malwarescore=0
 mlxlogscore=999 bulkscore=0 adultscore=0 phishscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2201200064
X-Proofpoint-GUID: tHeIP4Q7TKRV0_2V9Kuc-G2WaLkrPUbF
X-Proofpoint-ORIG-GUID: tHeIP4Q7TKRV0_2V9Kuc-G2WaLkrPUbF
Precedence: bulk
List-ID: <linux-ext4.vger.kernel.org>
X-Mailing-List: linux-ext4@vger.kernel.org

On 1/10/22 22:31, Alex Sierra wrote:
> Avoid long term pinning for Coherent device type pages. This could
> interfere with their own device memory manager. For now, we are just
> returning error for PIN_LONGTERM Coherent device type pages. Eventually,
> these type of pages will get migrated to system memory, once the device
> migration pages support is added.
> 
> Signed-off-by: Alex Sierra <alex.sierra@amd.com>
> ---
>  mm/gup.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/mm/gup.c b/mm/gup.c
> index 886d6148d3d0..9c8a075d862d 100644
> --- a/mm/gup.c
> +++ b/mm/gup.c
> @@ -1720,6 +1720,12 @@ static long check_and_migrate_movable_pages(unsigned long nr_pages,
>  		 * If we get a movable page, since we are going to be pinning
>  		 * these entries, try to move them out if possible.
>  		 */
> +		if (is_device_page(head)) {
> +			WARN_ON_ONCE(is_device_private_page(head));
> +			ret = -EFAULT;
> +			goto unpin_pages;
> +		}
> +

Wouldn't be more efficient for you failing earlier instead of after all the pages are pinned?

Filesystem DAX suffers from a somewhat similar issue[0] -- albeit it's more related to
blocking FOLL_LONGTERM in gup-fast while gup-slow can still do it. Coherent devmap appears
to want to block it in all gup.

On another thread Jason was suggesting about having different pgmap::flags to capture
these special cases[1] instead of selecting what different pgmap types can do in various
different places.

[0] https://lore.kernel.org/linux-mm/6a18179e-65f7-367d-89a9-d5162f10fef0@oracle.com/
[1] https://lore.kernel.org/linux-mm/20211019160136.GH3686969@ziepe.ca/