Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp1285569pxb; Fri, 21 Jan 2022 14:22:10 -0800 (PST) X-Google-Smtp-Source: ABdhPJy2vOHNDkLJ1lCnAPB/Y/OP76TLieypDr0PsjXdBNdRfnqvyzlA+agKwLbCUNArQtKp5p+n X-Received: by 2002:a17:902:e5c9:b0:14a:8379:bb9f with SMTP id u9-20020a170902e5c900b0014a8379bb9fmr5856386plf.142.1642803730118; Fri, 21 Jan 2022 14:22:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642803730; cv=none; d=google.com; s=arc-20160816; b=K7HJaxpDVJ2UsI09ixod6M4r8mDP1MHGLfv0PtpXsMiUXI5PpM/+VXVQympRbgQx1A 9yZMqaD+tszdiToT9NjkiWbPEeDoergTpF10PG/L5jL2IZlxeqezb7OOcXy9c7la2QNi +QPYY4M2ku+TgVoRimVBOXN3u+gln8Hlflb1WDCJBwYd/3jJus7TnqDMtoSMUlE6t3AO 4lAkzTgPoAxeIKPx+ekF5nVmkpQW8duJnf6kb5w3dv+L3E35sWwESbxpKime4WDZDJT2 31wnrclMDEQmedQ2aHaxmEvfeB9Ca1b+j59V7gxzhMYg/8p+LOjw7j6GN5MoOW9IS6si akzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=VzjsJeCJzduJLx28SCvk6OpA9bIQN800pcpPNYGtyOU=; b=ofuRTZWx23JJbj2JK7zex7li+9ov54/qDjFs0sPDyxSZfHCx2ymYHkjbdgyWYYRGCr N++xJSZQ+GFZIi1OaoFpqtwujNyFF0DgjH2y1bgS9bEKMV/j3hG7m/QFhO5lbbXaddaz mfZkGy5h0dJL1bCL4MiTJpELY6L0R/1fca3X99aalT4FA87caiZFpaRKbbqGvQpPq03M PcHrV2yfM5/eS8UjJuU15o4yGtBjAjXL82x6yOonPkSDugKixNUPeTgkIehrC8CKpE8X P8uhWoKzyhsNJ7vtN5DcOp14rUwDmk7APdNRawemNdXusjqtQaR+AX8CUODOgTfGm076 SdEw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m4si7305984pgj.203.2022.01.21.14.21.50; Fri, 21 Jan 2022 14:22:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376736AbiATPoY (ORCPT + 99 others); Thu, 20 Jan 2022 10:44:24 -0500 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:35111 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1376782AbiATPoY (ORCPT ); Thu, 20 Jan 2022 10:44:24 -0500 Received: from cwcc.thunk.org (pool-108-7-220-252.bstnma.fios.verizon.net [108.7.220.252]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 20KFiCYi027868 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 20 Jan 2022 10:44:12 -0500 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 2477E15C41B7; Thu, 20 Jan 2022 10:44:12 -0500 (EST) From: "Theodore Ts'o" To: adilger.kernel@dilger.ca, Xin Yin , harshadshirwadkar@gmail.com Cc: "Theodore Ts'o" , riteshh@linux.ibm.com, dan.carpenter@oracle.com, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/2] ext4: fix issues when fast commit work with jbd Date: Thu, 20 Jan 2022 10:44:08 -0500 Message-Id: <164269344020.116615.10466472564814944952.b4-ty@mit.edu> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20220117093655.35160-1-yinxin.x@bytedance.com> References: <20220117093655.35160-1-yinxin.x@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Mon, 17 Jan 2022 17:36:53 +0800, Xin Yin wrote: > When test fast commit with xfstests generic/455, some logic issues were > found. When a full commit is ongonig, the logic of fast commit tracking seems > not correct. The first patch fix the ineligible commit case , and the > second patch fix the common fast commit case. > > After testing this patch set with xfstests log and quick group, no > regressions were found, and the generic/455 can pass now. > > [...] Applied, thanks! [1/2] ext4: fast commit may not fallback for ineligible commit commit: b4facf2d8a22262f945975d23e29bbfa94ab5d27 [2/2] ext4: fast commit may miss file actions commit: 4a404adb1978f0a3f2ec9ee6c257bcc5b2452ee3 Best regards, -- Theodore Ts'o