Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp1359642pxb; Fri, 21 Jan 2022 16:28:39 -0800 (PST) X-Google-Smtp-Source: ABdhPJz17MmGp2VqG4+6eVLibFxHSHa6bmn1xTNKH0qr51zjE2b854gQIP320QL9VD6VtpmcE4hi X-Received: by 2002:a17:90a:bb13:: with SMTP id u19mr3059909pjr.41.1642811319022; Fri, 21 Jan 2022 16:28:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642811319; cv=none; d=google.com; s=arc-20160816; b=WBhQD/8NPFhtLQgDmdmZDiJYEs8DhpbyVUyU7t0J0T8Ne5dIvBhb7SI6td9u0ceswc zsOW+SqvxjQage2U6hqG7wZRnkYCmSUaA2AETEcvBVSkAVtvQNle7sXgA4xmDcW4SOqC xwRuabNUvUGj/MDq/ATntRAXEZeggetkKn2t8H9nioXD4XPN2vYf2LgcRZMXBlDb0eBF WYUhCTDpxdRMV1etkr9LMyFMSgVgynW2LgZ0cn83LQ+8+0WBFGkzH1QRhl5P+d9fC3yi e1VaR4JtFtSstJNPwBoZdANkuQ8vJcs2eTB1YqlMs8OttHH1Gxr72YX/OINy9lh5mXmr Ul/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:organization:subject:cc:to:from:dkim-signature; bh=5q7WlQD6Vh2kbqt2X4lfyI8Lp08JDSbIfYVgFkgvU5o=; b=oAVYoO/lnb7ld2W80Kb0MMbHz1dNJCZTXNIJwxlIg3A0+7BbNidicWaZQZA5yjeByp EnlwTWthvahV33/D8MFKk9RaMvWJmBtH5JYfX3tQuVB2V2LEAGtfLzLOSMnHSrLV2dIg x1bNZlvjANX3TLOhe4jsb3j4SRX0xxlDAOzyuneD0bVrBcEB6vaFxFkQSZhD8s8EAzrH sC8BrNcdJ0nhVM6z2q0nnGO/96iX51m/krKnpIM8clCxWZusgOKDLX3eU2BvSsorQjft AWnNFKuA69uO4xt5U+zI++orjYw/Y4ynD/X0T45WN70mLfUvaKdJRhnhplVTE9yjSCp9 Bxrw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b="d/45kpz7"; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x184si6621079pgb.676.2022.01.21.16.28.24; Fri, 21 Jan 2022 16:28:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b="d/45kpz7"; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233999AbiAUBKx (ORCPT + 99 others); Thu, 20 Jan 2022 20:10:53 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:40204 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232558AbiAUBKw (ORCPT ); Thu, 20 Jan 2022 20:10:52 -0500 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: krisman) with ESMTPSA id 3ED411F45843 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1642727451; bh=jHIs3XKzhPz//rxsayW/LeWaylwWk5P+YYlJwHwjTNc=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=d/45kpz7h1Gh3Fee/A+jedC+TvoXnUVF7l8ZKMR6NoSTrSg5ujani40PMzMSnbnwN WP6wYw9iU883Yw18oiZSo5NNTEzFpxK8Zm8XhrtpDRO9siR//g1CzQCHVm1HNidhjt EjAkMzEMH6i/H6SVFxfhKlkW73E7C5F13zKxKs0Zlb/mztZUt/Ea3+HiOkgeTVrdsP +CMe27c4rvBR/8P80dE/AJqC/ZZFrgy33rxC0hc7RagSfMQbDZRiW3DQ4PAztXYwLF LaYWkxlKNb+z8mhY2LG2/uY15OKOGIHfYhy/aryR3L+9+XpqJYac/JjmemufolP/tI 8ykwdwKmLHupA== From: Gabriel Krisman Bertazi To: Christoph Hellwig Cc: Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [PATCH] unicode: clean up the Kconfig symbol confusion Organization: Collabora References: <20220118065614.1241470-1-hch@lst.de> Date: Thu, 20 Jan 2022 20:10:47 -0500 In-Reply-To: <20220118065614.1241470-1-hch@lst.de> (Christoph Hellwig's message of "Tue, 18 Jan 2022 07:56:14 +0100") Message-ID: <87zgnp51wo.fsf@collabora.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Christoph Hellwig writes: > Turn the CONFIG_UNICODE symbol into a tristate that generates some always > built in code and remove the confusing CONFIG_UNICODE_UTF8_DATA symbol. > > Note that a lot of the IS_ENALBED() checks could be turned from cpp > statements into normal ifs, but this change is intended to be fairly > mechanic, so that should be cleaned up later. Hi, Just a typo s/ENALBED/ENABLED/. > Fixes: 2b3d04787012 ("unicode: Add utf8-data module") > Reported-by: Linus Torvalds > Signed-off-by: Christoph Hellwig I fixed the typo and pushed the patch to a linux-next visible branch https://git.kernel.org/pub/scm/linux/kernel/git/krisman/unicode.git/commit/?h=for-next&id=5298d4bfe80f6ae6ae2777bcd1357b0022d98573 I'm also sending a patch series shortly turning IS_ENABLED into part of the code flow where possible. Thank you, -- Gabriel Krisman Bertazi