Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <6963d9ea-7ecc-a09f-6256-a2a132782fe8@amd.com>
Date:   Fri, 28 Jan 2022 12:09:06 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v4 00/10] Add MEMORY_DEVICE_COHERENT for coherent device
 memory mapping
Content-Language: en-US
To:     "Sierra Guiza, Alejandro (Alex)" <alex.sierra@amd.com>,
        Andrew Morton <akpm@linux-foundation.org>
Cc:     linux-mm@kvack.org, rcampbell@nvidia.com,
        linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org,
        amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        hch@lst.de, jgg@nvidia.com, jglisse@redhat.com, apopple@nvidia.com,
        willy@infradead.org,
        "Deucher, Alexander" <Alexander.Deucher@amd.com>
References: <20220127030949.19396-1-alex.sierra@amd.com>
 <20220127143258.8da663659948ad1e6f0c0ea8@linux-foundation.org>
 <6434ba24-a219-6a5a-d902-0b48974a0e43@amd.com>
From:   Felix Kuehling <felix.kuehling@amd.com>
In-Reply-To: <6434ba24-a219-6a5a-d902-0b48974a0e43@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NlZnSEJBUGtMWkthU1dSRC9CNnF4UzZ1VFRKd09aWGQ4VEhIYm1hU2JkKzhO?=
 =?utf-8?B?eFo3L0RvOUpGR3piUW9JQmp5WWRTRDJBbms3VTdXcXVyMnBFTzlvRzlwVjJy?=
 =?utf-8?B?M2EwYkErb05vN2hxRDVWT3UxVWF6Ty9oNWl5cGNYRGVkRzlmVkx4TExWZnBl?=
 =?utf-8?B?QnppNWhySWpVY2pKV29CdllSaEdiblRCMWVZNVBEZmZnVHVvU2pSWktZQjUy?=
 =?utf-8?B?bklDTHpuS2ZlL2cxeUtkVFlSMGdjbS9Fd0FSaUI5aWFtaW9iU3NtQTF5bVcr?=
 =?utf-8?B?VnVTYVNTYWovT2FLWnFIbXFsQmIya0p4aTZleThyd1JLWW4xZUJ4UktvNXNy?=
 =?utf-8?B?MWtSRWV6bTlVd2oyc0M1bTdHUW9SMVozdnJzMVFrYWZETVUwV0xpQ0NMcGZu?=
 =?utf-8?B?QzBFVE1WVk9qa0Y4ZTVjNHJYeDlvWU1DUnJtRi9xYTgxdHg0T0JNbFRubXR2?=
 =?utf-8?B?bk1Vc1E2ZTFDN092WGlhN3ErMlVseW1rYlA3MWVrcU5DSHg5K0NjWEhrSGRv?=
 =?utf-8?B?ZktockJlVHJCLytrdE0xRGxEcGdEYnU3OE5BcXM4bEtwVUN4cktVTUgvYzBn?=
 =?utf-8?B?M0RKdVJzb0ZBMUtLUXBDdy9kdHRBVkQ2bjc4RER5MEl3ckJiK0pHWFdLeFFr?=
 =?utf-8?B?ajhtTGRKdDhiYmNjTFE3Z2JYS20xSWo0b20yYnNUN25nbU1Xa01aTGNIZzl2?=
 =?utf-8?B?NnAxRmFQMzlzbkpieFZ5anRPNkpiZFZsMkJxampqQzlTdHNTYk9vekFwdEdl?=
 =?utf-8?B?VFNHL2ZCZ1UzVFh6QVNML1NSaXlleVI5M3AzbHV3Wm9CWVQxOGJURHZ4SmVh?=
 =?utf-8?B?UVMxVDRtSzdhTzNJREZFa3IyRlFZNGI3TzJVbFRqZTEwVE1MUnoyRzUvQnB3?=
 =?utf-8?B?eEY3eTVwSVkvaVlxRFNORHpBWUE1bEYrYkZURkdkeVdScWZiK1FyY2tveklB?=
 =?utf-8?B?cmhSdlF2U1UxRnJkMjIzSVlId2xZc3QzMGlPdjhhK0lVNHRrZWdZS2Z2bWJ2?=
 =?utf-8?B?Wm1kQWgzalY2VDduNWMwUE9TS1hpMGV3ekZBSEh5bVdmTHpPK2hhQzV0MW5L?=
 =?utf-8?B?MW5sOUk0QTZXYnlVOFpHVWRPS09JdVo5bHJnazlVTWRWNnFRRUp4cjVkWjdQ?=
 =?utf-8?B?ZEl1THRZV0VjMHJwMDh5WW0rL1JIRUoxQ0dYakJ6alhFWmV2K3hLZEtVWXFH?=
 =?utf-8?B?QlBWbjBJQWZvVXR1dDB1c2g4MFhRN21zQ3orL3ZnTytYUW85QWhoSnZDb3FN?=
 =?utf-8?B?dTl3eTNIQStwU2NONHNVaEhnWWUvclRwZjF0UHVGQnpVcUc5TFVhaEUydHFa?=
 =?utf-8?B?bWJGWjlZc2s3TzNhVDkzWDY2dW45UFZkUllxT3pLTW1qaDJXeVp0bkQ1VWtI?=
 =?utf-8?B?bnlCQmlZM1ZyMnQ5WU5tMjdtb3lZUVlzREVSTXBOOGRGZnRXMXJLeTIralhi?=
 =?utf-8?B?bE1DTGJYZnUwVVFnb1UrdmhTMHNtYVNzN0pkaVgvdFZvRWhEZ084b1I1L3Y2?=
 =?utf-8?B?cFRCang1NTVtRFVYeWR1K05qSCsybCsvR0NsREZMRkhCbjFNeHFjeTN1bWN6?=
 =?utf-8?B?TmNKaEU4YitJNi9nTWdweFhvV1U5dERyZ3BDV1VXQzJHMzQyK0JnYUE0U1R2?=
 =?utf-8?B?YjdiYjBhbjNKRzlOU2s1WTZaTkdwRHNEQWI2Vzl3L3lOVnB0SWRCODRLVWVN?=
 =?utf-8?B?a1p0cTdjL29GVFF1WFg3TElhaEl1SDRibTU0TTBGM3hVRW5yY3dqamFxYS9m?=
 =?utf-8?B?c0lUblhLelFiRFJRbm45RE1jdkhnMkpvRllNbWtrWThVY1VZeXlPYkRkdXcr?=
 =?utf-8?B?eFRvQmx4VjZSd3ZGVnBBam0yUHJpSTJNV0hCUmdCTVd3ZW8xd0xwRWRXSUgw?=
 =?utf-8?B?YjhBMVQ5YTlKYlo0djhFdmk1ZnpQZXp3TWdLZ0UvMU5aQWQ0ZkZIbmhZN2dE?=
 =?utf-8?B?Nm5aMEo3NjhKVW5xUFhTTDRTYVFvVVg3c3V1UkhHRDd6UDNPbmRzUWhmWXZr?=
 =?utf-8?B?RlBuaWFVZTlwY3pGcUdQRUlXNDhkOHFQTHAxWlYvSFc3RXVEWWxBZzlkMCt5?=
 =?utf-8?B?aTJZeFErQzdiN3ZuQkJUU3NrSW94YkFOQTV3cit3NUIzNEFTTWVvT0ZpRCsw?=
 =?utf-8?B?R0hmc084M3FETXhPK25MMmh5cmJYc0JBUFBIQ2pUbXFOQ3ZpczYwY2xuM0tv?=
 =?utf-8?Q?De3vkJuPYSBakf9Z+UVmlf8=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 092dfd78-f42a-4d7d-2a9c-08d9e280e644
X-MS-Exchange-CrossTenant-AuthSource: BN9PR12MB5115.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jan 2022 17:09:09.9536
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rXTXyvkNCdrtny0tBRT8kr8M4beHH0u2Gu0LN9vfetGva5MrKbjnv+m0G1pBjAM33XNnfaDeU0vrrTdepZYoIw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB3188
Precedence: bulk
List-ID: <linux-ext4.vger.kernel.org>
X-Mailing-List: linux-ext4@vger.kernel.org

Thank you, Alex for your persistence with this patch series. Fee free to 
add my Acked-by to all the patches that don't already have my R-b. I 
have done pretty through reviews of previous versions of those patches, 
but obviously missed a lot of issues pointed out by real MM experts.

Thank you Alistair for your reviews, feedback and collaboration!

Regards,
   Felix


Am 2022-01-27 um 18:20 schrieb Sierra Guiza, Alejandro (Alex):
> Andrew,
> We're somehow new on this procedure. Are you referring to rebase this 
> patch series to
> git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git 
> <5.17-rc1 tag>?
>
> Regards,
> Alex Sierra
>
> Alex Deucher,
> Just a quick heads up. This patch series contains changes to the 
> amdgpu driver which we're
> planning to merge through Andrew's tree, If that's ok with you.
>
> Regards,
> Alex Sierra
>
> On 1/27/2022 4:32 PM, Andrew Morton wrote:
>> On Wed, 26 Jan 2022 21:09:39 -0600 Alex Sierra <alex.sierra@amd.com> 
>> wrote:
>>
>>> This patch series introduces MEMORY_DEVICE_COHERENT, a type of memory
>>> owned by a device that can be mapped into CPU page tables like
>>> MEMORY_DEVICE_GENERIC and can also be migrated like
>>> MEMORY_DEVICE_PRIVATE.
>> Some more reviewer input appears to be desirable here.
>>
>> I was going to tentatively add it to -mm and -next, but problems.
>> 5.17-rc1's mm/migrate.c:migrate_vma_check_page() is rather different
>> from the tree you patched.  Please redo, refresh and resend?
>>