Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp52481pxb; Mon, 31 Jan 2022 15:01:50 -0800 (PST) X-Google-Smtp-Source: ABdhPJyzJHcoo5l37jsH/6ZQ/g+LiPIAU0zuh7ThSc2bKtwlaEh4i3IhCsGpu8CNEYggqAScPstg X-Received: by 2002:a17:90b:2513:: with SMTP id ns19mr27266933pjb.29.1643670107702; Mon, 31 Jan 2022 15:01:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643670107; cv=none; d=google.com; s=arc-20160816; b=rR2WQ90EduOHUeRVefDzULSuunJFPt3Mx5BbjJzDMK91TVUfsGZC3RtjuSCtA5lFiF L6URY2MCGdPjVjzjgzkP4lo8p5Stsqlb1/wnixtQCgxsC/A5iKp8XfpsU968I92juuTk 17UMPLk5ixlYIfagwKQMV5YEmSuKGJvFoVFaHGf5Op7ezDp9yuTEBmTvrxumrzTeQDjB B3cqRrmH701oxvBVocjESUtOp3z3itA0JmqmYammaZpG4d81GwsxZ7gSMTkd35jX/KEO ltXEI266yH+kwnZeddAE7KnXlMfa12XvBVoJroucZa9ia+5I4rfhQk+OeNCidSLvwQwH 5XZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=h6nxvJ+gKQBOFc1VhUD78cyEHVVNLtoIeZHYzlCbl4g=; b=D5pjLUjzIvukffvBC+cBQHx5WNUNUk6afYYVTIv95oi+BFYv22pfJdO0H+dQaK81f4 aHzWJUUoCtRHz+G9twWa++WJmOCK871gpAfqPNBV4Xa6iPQ5xs4mRoUF3OGhn14alYcM pVs345U9CkLMJFrMWcpKiGYuCCqVr7PECdOn4PfWH2SQX0ck2X/RLuWDXp8EDJ5vqeSN CXibCLiywFLiMKkKSncfkX/WOMhdAl7ITD45prqkotzhoH84yqXnkBXCMYXJKWbQeJZs cRTbjM7TrocIxcnbp1f1HTP2w+S099KJE68bxE60VBpLD6RNB1tcjF/G4fWGffzl9Vn2 onhQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id il16si793936pjb.106.2022.01.31.15.01.34; Mon, 31 Jan 2022 15:01:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344578AbiA2EfZ (ORCPT + 99 others); Fri, 28 Jan 2022 23:35:25 -0500 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:34298 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S230242AbiA2EfY (ORCPT ); Fri, 28 Jan 2022 23:35:24 -0500 Received: from cwcc.thunk.org (pool-108-7-220-252.bstnma.fios.verizon.net [108.7.220.252]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 20T4ZEqh031387 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 28 Jan 2022 23:35:15 -0500 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 2AC2915C0040; Fri, 28 Jan 2022 23:35:14 -0500 (EST) From: "Theodore Ts'o" To: Yang Li , jack@suse.com Cc: "Theodore Ts'o" , linux-kernel@vger.kernel.org, Abaci Robot , linux-ext4@vger.kernel.org Subject: Re: [PATCH -next -v2] ext4: Fix jbd2_journal_shrink_scan() and jbd2_journal_shrink_count() kernel-doc comment Date: Fri, 28 Jan 2022 23:35:11 -0500 Message-Id: <164343088807.815725.18138313955361994857.b4-ty@mit.edu> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20220110132841.34531-1-yang.lee@linux.alibaba.com> References: <20220110132841.34531-1-yang.lee@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Mon, 10 Jan 2022 21:28:41 +0800, Yang Li wrote: > Add the description of @shrink and @sc in jbd2_journal_shrink_scan() and > jbd2_journal_shrink_count() kernel-doc comment to remove warnings found > by running scripts/kernel-doc, which is caused by using 'make W=1'. > fs/jbd2/journal.c:1296: warning: Function parameter or member 'shrink' > not described in 'jbd2_journal_shrink_scan' > fs/jbd2/journal.c:1296: warning: Function parameter or member 'sc' not > described in 'jbd2_journal_shrink_scan' > fs/jbd2/journal.c:1320: warning: Function parameter or member 'shrink' > not described in 'jbd2_journal_shrink_count' > fs/jbd2/journal.c:1320: warning: Function parameter or member 'sc' not > described in 'jbd2_journal_shrink_count' > > [...] Applied, thanks! [1/1] ext4: Fix jbd2_journal_shrink_scan() and jbd2_journal_shrink_count() kernel-doc comment commit: be74a53334ad38b11cc2998749837e87796375e2 Best regards, -- Theodore Ts'o